Didn't have the time to patch the whole thing. But a first few lines of
the patch would read as attached to this mail - and obviousy would need
an review as everybody gets this kind of thing wrong.
I'm not sure if all the strings we sprintf'ed into actually had the
right length to accomodate the '
On Sun, Sep 23, 2018 at 11:43:38PM +0100, Bruno Postle wrote:
>
>
> On 23 September 2018 13:48:10 BST, Andreas Metzler wrote:
> >
> >building libpano with gcc 8 (instead of 7) triggers a couple of new
> >warnings that might be interesting:
> >
> >parser.c: In function 'ReadImageDescription':
> >p
Can we have a patch? This is exactly the sort of thing that I mess up - Bruno
On 24 September 2018 06:04:49 BST, "Gunter Königsmann" wrote:
>My advise is to replace the sprintf by an snprintf before the final
>release: snprintf requires an additional parameter that tells it how
>many
>bytes the b
My advise is to replace the sprintf by an snprintf before the final
release: snprintf requires an additional parameter that tells it how many
bytes the buffer it is about to write into is long; using an ordinary
sprintf always means you are risking needing to issue an security update
because someon
On September 23, 2018 12:43:38 PM HST, Bruno Postle wrote:
>
>
>On 23 September 2018 13:48:10 BST, Andreas Metzler wrote:
>>
>>building libpano with gcc 8 (instead of 7) triggers a couple of new
>>warnings that might be interesting:
>>
>>parser.c: In function 'ReadImageDescription':
>>parser.c:1854
On Sunday, 23 September 2018 at 23:43:38 +0100, Bruno Postle wrote:
>
>
> On 23 September 2018 13:48:10 BST, Andreas Metzler wrote:
>>
>> building libpano with gcc 8 (instead of 7) triggers a couple of new
>> warnings that might be interesting:
>>
>> parser.c: In function 'ReadImageDescription':
>>
On 23 September 2018 13:48:10 BST, Andreas Metzler wrote:
>
>building libpano with gcc 8 (instead of 7) triggers a couple of new
>warnings that might be interesting:
>
>parser.c: In function 'ReadImageDescription':
>parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes
>into a regi
Hello,
building libpano with gcc 8 (instead of 7) triggers a couple of new
warnings that might be interesting:
---
parser.c: In function 'ReadImageDescription':
parser.c:1854:38: warning: '%s' directive writing up to 65535 bytes into a
region of size 256 [-Wformat-overflow=]