How about HWLOC_UNSUPPORTED_SYS?
On Nov 11, 2009, at 2:38 AM, wrote:
Author: bgoglin
Date: 2009-11-11 05:38:26 EST (Wed, 11 Nov 2009)
New Revision: 1330
URL: https://svn.open-mpi.org/trac/hwloc/changeset/1330
Log:
Add hwloc_topology_get_support()
This also defines UNSUPPORTED_SYS on not supp
Jeff Squyres wrote:
> How about HWLOC_UNSUPPORTED_SYS?
>
We currently have a mix of internal LINUX/SOLARIS/../UNSUPPORTED_SYS and
one public HWLOC_LINUX_SYS. I could merge all of them into HWLOC_*_SYS,
sure.
Brice
I just pushed the PLPA stuff to trunk. One problem we have is that we
cannot the binding-capability in the PLPA-interface. The reason is that
PLPA wants to bind a thread given by a pid (ie do sched_setaffinity).
hwloc only has the ability to bind the current thread, or to bind an
entire process giv
Jeff Squyres, le Wed 11 Nov 2009 05:54:00 -0800, a écrit :
> How about HWLOC_UNSUPPORTED_SYS?
I don't think it's a good idea to make it a compile-time thing rather
than a runtime-time thing: if we expose to the application the fact
that the OS on which the application is building is not supported,
Brice Goglin, le Wed 11 Nov 2009 17:34:30 +0100, a écrit :
> Would it make sense to add support for the CPUBIND_THREAD policy in
> set_proc_cpubind? (and maybe rename it into set_pid_cpubind, or add
> set_thread_pid_cpubind).
I answered in the ticket itself: linux 2.4 insanely mixed the notion of
bgog...@osl.iu.edu, le Wed 11 Nov 2009 11:33:31 -0500, a écrit :
> + /* FIXME: should be SET_THREAD_CPUBIND given with a pid */
> + if (flags & HWLOC_SUPPORT_SET_PROC_CPUBIND)
> +*api_type = HWLOC_PLPA_PROBE_OK;
> + else
> +*api_type = HWLOC_PLPA_PROBE_NOT_SUPPORTED;
> + return 0;
> +}
bgog...@osl.iu.edu, le Wed 11 Nov 2009 11:33:31 -0500, a écrit :
> +/** \brief Bind thread given by \p pid to CPU set \p cpuset.
> + *
> + * \note This function now manipulates hwloc cpusets.
> + */
> +static __inline int
> +hwloc_plpa_sched_setaffinity(hwloc_topology_t topology, hwloc_pid_t pid,
Samuel Thibault wrote:
> bgog...@osl.iu.edu, le Wed 11 Nov 2009 11:33:31 -0500, a écrit :
>
>> +/** \brief Bind thread given by \p pid to CPU set \p cpuset.
>> + *
>> + * \note This function now manipulates hwloc cpusets.
>> + */
>> +static __inline int
>> +hwloc_plpa_sched_setaffinity(hwloc_top
Brice Goglin, le Thu 12 Nov 2009 00:31:48 +0100, a écrit :
> The problem is that our hwloc/Linux does not implement
> set_proc_cpubind() so far.
But it can implement one that assumes that the target process is
singlethreaded, i.e. in hwloc_set_proc_cpubind distinguish between
HWLOC_CPUBIND_PROCESS
Another way to go is in hwloc_plpa_sched_setaffinity put in
#ifdef HWLOC_LINUX_SYS some code that calls the internal
hwloc_linux_set_tid_cpubind (with a strong comment that nobody else
should call it), so that
- existing linux plpa users can have the same behavior, but we can
document here that
Jeff Squyres, le Mon 09 Nov 2009 08:05:47 -0500, a écrit :
> Fair enough. What about if we have an AC check for
> pthread_setaffinity_np and use that if it exists, and if it doesn't
> use the PLPA way?
Err, remember that pthread_setaffinity_np alone doesn't permit to bind
another process, and
Brice Goglin, le Thu 05 Nov 2009 17:22:15 +0100, a écrit :
> + int hwloc_plpa_sched_getaffinity(pid_t pid, hwloc_cpuset_t cpuset);
>
> It's just a hwloc_get_cpubind(), but we don't have it since it would not
> be supported on all OS. But I think we should add it anyway.
Being discussed in another
Creating nightly hwloc snapshot SVN tarball was a success.
Snapshot: hwloc 1.0a1r1335
Start time: Wed Nov 11 21:01:02 EST 2009
End time: Wed Nov 11 21:02:54 EST 2009
Your friendly daemon,
Cyrador
Brice Goglin, le Mon 09 Nov 2009 15:18:11 +0100, a écrit :
> I don't think we need SET_CPUBIND since (from what I understand) it
> would be equivalent to SET_PROC_CPUBIND | SET_THREAD_CPUBIND.
Being able to set oneself's cpuset is not the same as being able to set
the cpuset of other processes or
14 matches
Mail list logo