Re: [hwloc-devel] sometimes unused params

2010-01-08 Thread Samuel Thibault
Jeff Squyres, le Fri 08 Jan 2010 12:22:59 -0500, a écrit : > On Jan 8, 2010, at 12:22 PM, Samuel Thibault wrote: > > >> How do you guys want to handle params that are *sometimes* unused? > > > > I'd just mark them unused. > > Is it harmful to mark them unused when they're actually used? No.

Re: [hwloc-devel] sometimes unused params

2010-01-08 Thread Jeff Squyres
On Jan 8, 2010, at 12:22 PM, Samuel Thibault wrote: >> How do you guys want to handle params that are *sometimes* unused? > > I'd just mark them unused. Is it harmful to mark them unused when they're actually used? -- Jeff Squyres jsquy...@cisco.com

[hwloc-devel] sometimes unused params

2010-01-08 Thread Jeff Squyres
How do you guys want to handle params that are *sometimes* unused? For example, topology.c:1450 is: - int hwloc_topology_set_fsroot(struct hwloc_topology *topology, const char *fsroot_path) { /* cleanup existing backend */ hwloc_backend_exit(topology); #ifdef HWLOC_LINUX_SYS if