Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Jeff Squyres
On Jan 26, 2010, at 10:09 AM, Brice Goglin wrote: > * should we enforce the ordering of pages size+count structures ? I am > sorting by page size for now Seems like a neighborly thing to do. If it's not hard, I say keep that functionality. > * how is the pages array terminated ? size = 0 ? or

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Jeff Squyres
On Jan 19, 2010, at 3:15 PM, Brice Goglin wrote: > IIRC, it was changed into a pointer before the first release to reduce > ABI changes inside the the main hwloc_obj struct when attributes are > changed. I don't think hwloc_obj and attributes will be stable before > hwloc 2.0 so I don't really

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Samuel Thibault
Brice Goglin, le Tue 26 Jan 2010 16:09:13 +0100, a écrit : > = 0 ? if some OS fail to give the size of normal pages or huge pages, we > might have count !=0 while size = 0 in some cases. In that case the size wouldn't be advertised at all. count == 0 is however plausible when you run out of big

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Brice Goglin
I have pushed some changes in the memoryattrs branch. See the new memory attributes starting at line 138 of https://svn.open-mpi.org/trac/hwloc/browser/branches/memoryattrs/include/hwloc.h I am still working on the XML backend. It'd be good if people could complain about the API before I convert