[hwloc-devel] Create success (hwloc r1.1a1r2050)

[MPI Team]

Creating nightly hwloc snapshot SVN tarball was a success.

Snapshot:   hwloc 1.1a1r2050
Start time: Tue May  4 21:01:04 EDT 2010
End time:   Tue May  4 21:02:59 EDT 2010

Your friendly daemon,
Cyrador

Re: [hwloc-devel] Windows 7 problems

[Jeff Squyres]

I'm told by my local Microsoft rep that Windows does not currently expose the 
total number of pages per numa node.

Do we document that these numbers on Windows are *available* memory?


On May 3, 2010, at 5:25 PM, Samuel Thibault wrote:

> Brice Goglin, le Tue 04 May 2010 00:15:42 +0200, a écrit :
>> If this gives access to the SRAT table or things like that, it may give
>> us a lot of locality info (IIRC, that's what Linux reads to get NUMA and
>> I/O locality information). But I hope I won't be the one writing the
>> ACPI table parser :)
> 
> I'd rather avoid that too :/.
> 
> Samuel
> ___
> hwloc-devel mailing list
> hwloc-de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel


-- 
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/

Re: [hwloc-devel] [hwloc-svn] svn:hwloc r2044

[Samuel Thibault]

bgog...@osl.iu.edu, le Tue 04 May 2010 01:32:00 -0400, a écrit :
> @@ -326,6 +330,10 @@
>  if (nr_tids == max_tids) {
>max_tids += 8;
>tids = realloc(tids, max_tids*sizeof(pid_t));
> +  if (!tids) {
> +errno = ENOMEM;
> +return -1;
> +  }
>  }
>  if (!strcmp(dirent->d_name, ".") || !strcmp(dirent->d_name, ".."))
>continue;

We also need to free the original allocated array.

Samuel

Re: [hwloc-devel] want 1.0rc4?

[Samuel Thibault]

Brice Goglin, le Tue 04 May 2010 07:54:47 +0200, a écrit :
> line 41 of src/misc.c in hwloc_snprintf():
> 
>  str = malloc(size);
> 
> 
> I am not sure what to do about this one... Is there any value we could return
> without possibly breaking the caller ?

0 seems relatively safe to me. At worse the caller allocates 0 bytes,
which might also return ENOMEM, but that's up to him to handle it.

Samuel

Re: [hwloc-devel] want 1.0rc4?

[Brice Goglin]

On 04/05/2010 03:57, Christopher Samuel wrote:
>
> On 03/05/10 09:57, Jeff Squyres wrote:
>
> > 1.0rc4 is up.
>
> Running coccicheck on 1.0rc4 flags up this construct, I presume
> as an ambiguous construction:
>
> if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) {
>
> That's at line 1518 of src/topology.c in hwloc_discover(). The
> check file simply says:
>
> // !x combines boolean negation with bitwise and
>
>
> It's also flagged some unchecked malloc()'s in various bits:
>

Thanks a lot, I think I fixed most of these.

> line 41 of src/misc.c in hwloc_snprintf():
>
>  str = malloc(size);
>

I am not sure what to do about this one... Is there any value we could
return without possibly breaking the caller ?

Brice