Brice / Samuel --
Can you confirm that this is the correct fix? I need someone to review it so
that I can CMR it into OMPI release branches.
Thanks!
Begin forwarded message:
> From:
> Subject: [hwloc-svn] svn:hwloc r5588 - trunk/config
> Date: May 6, 2013
Creating nightly hwloc snapshot SVN tarball was a success.
Snapshot: hwloc 1.8a1r5587
Start time: Mon May 6 21:01:01 EDT 2013
End time: Mon May 6 21:05:39 EDT 2013
Your friendly daemon,
Cyrador
On 05/06/2013 07:24 AM US Central Time, Brice Goglin wrote:
> I am testing your patches on FreeBSD 9.1 under POSIX_SOURCE, things
> compile fine but hwloc complains that it cannot find the number of
> processors (because it needs sysctl or sysconf to do so, not available
> without BSD types). So
On 05/06/2013 01:25 AM US Central Time, Brice Goglin wrote:
> I think we removed C99 use (and configure check) from the code in 1.2
> because some compilers didn't properly support it.
I looked at the code once more. It seems to assume fixed width integers
all over the place. These are all
On 05/06/2013 06:07 AM US Central Time, Pavan Balaji wrote:
>
> On 05/06/2013 04:08 AM US Central Time, Brice Goglin wrote:
>> Le 05/05/2013 19:26, Pavan Balaji a écrit :
>>> -autoreconf -ivf
>>> +autoreconf ${autoreconf_args:"-ivf"}
>>> -- 1.8.1.2
>>
>> This needs an additional dash:
>>
>>
On 05/06/2013 04:08 AM US Central Time, Brice Goglin wrote:
> Le 05/05/2013 19:26, Pavan Balaji a écrit :
>> -autoreconf -ivf
>> +autoreconf ${autoreconf_args:"-ivf"}
>> -- 1.8.1.2
>
> This needs an additional dash:
>
> -autoreconf -ivf
> +autoreconf ${autoreconf_args:-"-ivf"}
Where did you
On 05/06/2013 01:25 AM US Central Time, Brice Goglin wrote:
> I think we removed C99 use (and configure check) from the code in 1.2
> because some compilers didn't properly support it.
Wow. That was a while ago, and I totally missed that change.
We noticed some errors on FreeBSD (oh yeah, I
Le 05/05/2013 19:26, Pavan Balaji a écrit :
> From d5bee8b50ccefd1ae9f7cd6d69639bfc45b3b0b3 Mon Sep 17 00:00:00 2001
> From: Pavan Balaji
> Date: Sun, 5 May 2013 12:21:14 -0500
> Subject: [PATCH 2/2] Allow users to specify other flags to autoreconf.
>
> No reviewer.
> ---
>
I think we removed C99 use (and configure check) from the code in 1.2
because some compilers didn't properly support it.
Brice
Le 06/05/2013 03:14, Pavan Balaji a écrit :
> Is hwloc supposed to support c89 only (no c99)? I remember having this
> discussion earlier and the hwloc developers said