[hwloc-devel] Create success (hwloc git dev-1095-gf683068)

2016-04-05 Thread MPI Team
Creating nightly hwloc snapshot git tarball was a success. Snapshot: hwloc dev-1095-gf683068 Start time: Tue Apr 5 21:01:02 EDT 2016 End time: Tue Apr 5 21:02:58 EDT 2016 Your friendly daemon, Cyrador

Re: [hwloc-devel] Three patches for MSVC/ICL builds on Windows.

2016-04-05 Thread Peyton, Jonathan L
> This one is applied (not pushed yet). Great! > Samuel pushed a better fix > I am dropping the dirent changes and just disabling hwloc-ps entirely on > Windows. > The user32 part is applied. This sounds good to me. > For strdup and putenv, my MSVC fails with "The POSIX name for this item is >

Re: [hwloc-devel] Three patches for MSVC/ICL builds on Windows.

2016-04-05 Thread Brice Goglin
More comments about individual changes below. > add-ifndef-guard-around-gnu-source.patch > diff --git a/config/hwloc.m4 b/config/hwloc.m4 > index f249713..855244d 100644 > --- a/config/hwloc.m4 > +++ b/config/hwloc.m4 > @@ -486,7 +486,9 @@ EOF]) > # program_invocation_name and __progname may

Re: [hwloc-devel] Three patches for MSVC/ICL builds on Windows.

2016-04-05 Thread Samuel Thibault
Brice Goglin, on Tue 05 Apr 2016 10:39:29 +0200, wrote: > Le 05/04/2016 10:26, Samuel Thibault a écrit : > > The bug here is that that HWLOC_CHECK_DECL assumed that availability > > of the function was tested before, i.e. > >> conftest.c(96) : fatal error C1083: Cannot open include file: 'sched.h':

Re: [hwloc-devel] Three patches for MSVC/ICL builds on Windows.

2016-04-05 Thread Brice Goglin
Le 05/04/2016 10:26, Samuel Thibault a écrit : > The bug here is that that HWLOC_CHECK_DECL assumed that availability > of the function was tested before, i.e. >> conftest.c(96) : fatal error C1083: Cannot open include file: 'sched.h': No >> such file or directory > was unexpected. > Adding a chec

Re: [hwloc-devel] Three patches for MSVC/ICL builds on Windows.

2016-04-05 Thread Samuel Thibault
Hello, Peyton, Jonathan L, on Mon 04 Apr 2016 22:09:19 +, wrote: > Fundamentally, I think _HWLOC_CHECK_DECL()’s macro logic is broken. It was not, originally :) The problem of AC_CHECK_DECL is that it only checks that a declaration exists (by referencing it as a right-value, not a function).