Re: [hwloc-devel] memory size attributes

2010-01-27 Thread Brice Goglin
I pushed the last bunch of changes to the memoryattrs branch. I don't plan any other changes about this. I'll probably merge into trunk by the end of the week unless somebody complains ;) Brice

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Jeff Squyres
On Jan 26, 2010, at 3:11 PM, Jeff Squyres (jsquyres) wrote: > It might still be nice to have a total_descendants_memory field (or a shorter > field) that represents the sum of all children memory since it is probably > not an uncommon action to just want to know how much memory I can access > *

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Jeff Squyres
On Jan 26, 2010, at 10:09 AM, Brice Goglin wrote: > * should we enforce the ordering of pages size+count structures ? I am > sorting by page size for now Seems like a neighborly thing to do. If it's not hard, I say keep that functionality. > * how is the pages array terminated ? size = 0 ? or

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Jeff Squyres
On Jan 19, 2010, at 3:15 PM, Brice Goglin wrote: > > I say "bytes" instead of "kilobytes" because it might be easier to avoid > > getting into the "what does kilo mean -- 1000 or 1024?" arguments. > > kilo mean 1000, otherwise it's called kibi :) Forgot to mention -- I think that comment proves

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Jeff Squyres
On Jan 19, 2010, at 3:15 PM, Brice Goglin wrote: > IIRC, it was changed into a pointer before the first release to reduce > ABI changes inside the the main hwloc_obj struct when attributes are > changed. I don't think hwloc_obj and attributes will be stable before > hwloc 2.0 so I don't really car

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Samuel Thibault
Brice Goglin, le Tue 26 Jan 2010 16:09:13 +0100, a écrit : > = 0 ? if some OS fail to give the size of normal pages or huge pages, we > might have count !=0 while size = 0 in some cases. In that case the size wouldn't be advertised at all. count == 0 is however plausible when you run out of big pa

Re: [hwloc-devel] memory size attributes

2010-01-26 Thread Brice Goglin
I have pushed some changes in the memoryattrs branch. See the new memory attributes starting at line 138 of https://svn.open-mpi.org/trac/hwloc/browser/branches/memoryattrs/include/hwloc.h I am still working on the XML backend. It'd be good if people could complain about the API before I convert e

Re: [hwloc-devel] memory size attributes

2010-01-19 Thread Brice Goglin
Jeff Squyres wrote: > On Jan 19, 2010, at 3:20 AM, Brice Goglin wrote: > >> I propose the following changes to the object attributes. struct >> hwloc_obj now contains a struct hwloc_memory pointer: >> > > Is there any reason not to make this a sub-struct included in hwloc_obj (vs. > a poin

Re: [hwloc-devel] memory size attributes

2010-01-19 Thread Samuel Thibault
Jeff Squyres, le Tue 19 Jan 2010 07:03:55 -0500, a écrit : > On Jan 17, 2010, at 6:31 AM, Brice Goglin wrote: > > > Right now we have total amount + number of hugepages + size of > > hugepages. I was only talking about modifying the way to store all this > > so as it'd be to easier to add multiple

Re: [hwloc-devel] memory size attributes

2010-01-19 Thread Jeff Squyres
On Jan 19, 2010, at 3:20 AM, Brice Goglin wrote: > I propose the following changes to the object attributes. struct > hwloc_obj now contains a struct hwloc_memory pointer: Is there any reason not to make this a sub-struct included in hwloc_obj (vs. a pointer that requires an additional malloc)?

Re: [hwloc-devel] memory size attributes

2010-01-19 Thread Jeff Squyres
On Jan 17, 2010, at 6:31 AM, Brice Goglin wrote: > Right now we have total amount + number of hugepages + size of > hugepages. I was only talking about modifying the way to store all this > so as it'd be to easier to add multiple hugepage size x number one day. > I wasn't talking about adding norm

Re: [hwloc-devel] memory size attributes

2010-01-19 Thread Brice Goglin
I propose the following changes to the object attributes. struct hwloc_obj now contains a struct hwloc_memory pointer: struct hwloc_memory { unsigned long total_kB; /* Total memory in this object and its children */ unsigned long local_kB; /* Local memory in this object */ struct hwloc_memo

Re: [hwloc-devel] memory size attributes

2010-01-17 Thread Brice Goglin
Jeff Squyres (jsquyres) wrote: > > Just so I understand - are you saying hwloc should track both the > total amount of memory *and* the makeup of that amount, broken up by > page size? > I don't know if we need this. Right now we have total amount + number of hugepages + size of hugepages. I was

Re: [hwloc-devel] memory size attributes

2010-01-16 Thread Jeff Squyres (jsquyres)
Hardware locality development list Sent: Sat Jan 16 07:08:46 2010 Subject: Re: [hwloc-devel] memory size attributes Brice Goglin wrote: > Hello, > > While cleaning the System/Machine root types, I wondered what we > actually want to store in memory_kB attributes. It looks obvious for

Re: [hwloc-devel] memory size attributes

2010-01-16 Thread Jeff Squyres (jsquyres)
meanings separate. -jms Sent from my PDA. No type good. - Original Message - From: hwloc-devel-boun...@open-mpi.org To: hwloc development Sent: Wed Jan 13 08:40:49 2010 Subject: [hwloc-devel] memory size attributes Hello, While cleaning the System/Machine root types, I wondered

Re: [hwloc-devel] memory size attributes

2010-01-16 Thread Brice Goglin
Brice Goglin wrote: > Hello, > > While cleaning the System/Machine root types, I wondered what we > actually want to store in memory_kB attributes. It looks obvious for > Caches and NUMA nodes. But I am not sure about Machines and Systems. > > If we have a machine with 2 NUMA nodes, should the mach

Re: [hwloc-devel] memory size attributes

2010-01-13 Thread Samuel Thibault
Brice Goglin, le Wed 13 Jan 2010 14:40:49 +0100, a écrit : > * system: set of memory that is virtually accessible, but may not be > cache-coherent Mmm, I believe with kerrighed systems shared memory is cache-coherent (yes it's expensive). Samuel

[hwloc-devel] memory size attributes

2010-01-13 Thread Brice Goglin
Hello, While cleaning the System/Machine root types, I wondered what we actually want to store in memory_kB attributes. It looks obvious for Caches and NUMA nodes. But I am not sure about Machines and Systems. If we have a machine with 2 NUMA nodes, should the machine memory size be the sum the s