Re: [hwloc-devel] want 1.0rc4?

2010-05-04 Thread Samuel Thibault
Brice Goglin, le Tue 04 May 2010 07:54:47 +0200, a écrit : > line 41 of src/misc.c in hwloc_snprintf(): > > str = malloc(size); > > > I am not sure what to do about this one... Is there any value we could return > without possibly breaking the caller ? 0 seems relatively safe to

Re: [hwloc-devel] want 1.0rc4?

2010-05-04 Thread Brice Goglin
On 04/05/2010 03:57, Christopher Samuel wrote: > > On 03/05/10 09:57, Jeff Squyres wrote: > > > 1.0rc4 is up. > > Running coccicheck on 1.0rc4 flags up this construct, I presume > as an ambiguous construction: > > if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) { > > That's at line

Re: [hwloc-devel] want 1.0rc4?

2010-05-03 Thread Jeff Squyres
Awesome; thanks Chris! On May 3, 2010, at 8:57 PM, Christopher Samuel wrote: > On 03/05/10 09:57, Jeff Squyres wrote: > > > 1.0rc4 is up. > > Running coccicheck on 1.0rc4 flags up this construct, I presume > as an ambiguous construction: > > if (!topology->flags &

Re: [hwloc-devel] want 1.0rc4?

2010-05-03 Thread Christopher Samuel
On 03/05/10 09:57, Jeff Squyres wrote: > 1.0rc4 is up. Running coccicheck on 1.0rc4 flags up this construct, I presume as an ambiguous construction: if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) { That's at line 1518 of src/topology.c in hwloc_discover(). The check file simply

Re: [hwloc-devel] want 1.0rc4?

2010-05-03 Thread Jeff Squyres
Posted. On May 3, 2010, at 10:37 AM, Samuel Thibault wrote: > Jeff Squyres, le Mon 03 May 2010 09:57:09 -0400, a écrit : > > 1.0rc4 is up. Send me a windows binary when you get a chance. > > http://dept-info.labri.fr/~thibault/tmp/hwloc-win32-build-1.0rc4.zip > > Samuel >

Re: [hwloc-devel] want 1.0rc4?

2010-05-03 Thread Samuel Thibault
Jeff Squyres, le Mon 03 May 2010 09:57:09 -0400, a écrit : > 1.0rc4 is up. Send me a windows binary when you get a chance. http://dept-info.labri.fr/~thibault/tmp/hwloc-win32-build-1.0rc4.zip Samuel

Re: [hwloc-devel] want 1.0rc4?

2010-05-03 Thread Jeff Squyres
1.0rc4 is up. Send me a windows binary when you get a chance. On May 3, 2010, at 9:30 AM, Samuel Thibault wrote: > Jeff Squyres, le Mon 03 May 2010 09:28:41 -0400, a écrit : > > I see a flurry of windows-related activity over the weekend. > > > > Do you guys want me to cut rc4? > > I'm done

Re: [hwloc-devel] want 1.0rc4?

2010-05-03 Thread Samuel Thibault
Jeff Squyres, le Mon 03 May 2010 09:28:41 -0400, a écrit : > I see a flurry of windows-related activity over the weekend. > > Do you guys want me to cut rc4? I'm done with what I wanted to fix in rc3. Samuel