Re: [hwloc-devel] more embedded

2009-12-16 Thread Jeff Squyres
On Dec 16, 2009, at 10:40 AM, Brice Goglin wrote:

> > ...or do you want me to bring over the embedding stuff to the svn trunk RSN?
> 
> I vote for merging as soon as possible. We'll merge before 1.0 anyway,
> so we'll have to fix things one day or another. By the way, once it's
> merged, I'll have to fix conflicts in the libpci branch, I'd rather do
> that when my cache is full of embedding knowledge.

Ok.  Lemme tie up loose ends and merge today.

-- 
Jeff Squyres
jsquy...@cisco.com




Re: [hwloc-devel] more embedded

2009-12-16 Thread Samuel Thibault
Jeff Squyres, le Wed 16 Dec 2009 10:35:22 -0500, a écrit :
> Actually, do you mind if I add it?

No pb, you can as well just add the whole file indeed.

Samuel


Re: [hwloc-devel] more embedded

2009-12-16 Thread Jeff Squyres
Actually, do you mind if I add it?

The m4 stuff changed *significantly* in the embedding code -- so every time 
something changes in configure or m4 on the svn trunk, it's a real PITA to 
re-merge it into the embedding hg.

...or do you want me to bring over the embedding stuff to the svn trunk RSN?


On Dec 16, 2009, at 9:49 AM, Samuel Thibault wrote:

> Jeff Squyres, le Wed 16 Dec 2009 09:42:21 -0500, a écrit :
> > Yes -- we (OMPI) have m4 for checking for oodles of attributes.
> 
> Ok, found it in config/ompi_check_attributes.m4.
> 
> > Want me to bring them over and you and trim want you don't want?
> 
> I'll pick up directly from openmpi.
> 
> Samuel
> ___
> hwloc-devel mailing list
> hwloc-de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
> 


-- 
Jeff Squyres
jsquy...@cisco.com




Re: [hwloc-devel] more embedded

2009-12-16 Thread Samuel Thibault
Jeff Squyres, le Wed 16 Dec 2009 09:42:21 -0500, a écrit :
> Yes -- we (OMPI) have m4 for checking for oodles of attributes.

Ok, found it in config/ompi_check_attributes.m4.

> Want me to bring them over and you and trim want you don't want?

I'll pick up directly from openmpi.

Samuel


Re: [hwloc-devel] more embedded

2009-12-16 Thread Jeff Squyres
On Dec 16, 2009, at 9:10 AM, Samuel Thibault wrote:

> > > Would it be desirable to have compiler visibility enabled in hwloc?
> >
> > Yes.  I don't have an m4 fragment to check for visibility off-hand,
> 
> BTW, do you have an m4 fragment off-hand to check for the unused
> attribute?

Yes -- we (OMPI) have m4 for checking for oodles of attributes.  Want me to 
bring them over and you and trim want you don't want?

-- 
Jeff Squyres
jsquy...@cisco.com




Re: [hwloc-devel] more embedded

2009-12-16 Thread Samuel Thibault
Samuel Thibault, le Wed 16 Dec 2009 15:06:15 +0100, a écrit :
> Jeff Squyres, le Tue 15 Dec 2009 21:13:55 -0500, a écrit :
> > Would it be desirable to have compiler visibility enabled in hwloc?
> 
> Yes.  I don't have an m4 fragment to check for visibility off-hand,

BTW, do you have an m4 fragment off-hand to check for the unused
attribute?

Samuel


Re: [hwloc-devel] more embedded

2009-12-16 Thread Jeff Squyres
On Dec 16, 2009, at 9:06 AM, Samuel Thibault wrote:

> > Would it be desirable to have compiler visibility enabled in hwloc?
> 
> Yes.  I don't have an m4 fragment to check for visibility off-hand,
> that's why I hadn't done it yet and just relied on the hwloc_ prefix :)
> (which is still useful when debugging bigger applications to know which
> library a stack frame is in)

Coolio.  I'll bring over the vis stuff as part of the embedding stuff.

-- 
Jeff Squyres
jsquy...@cisco.com



Re: [hwloc-devel] more embedded

2009-12-16 Thread Samuel Thibault
Jeff Squyres, le Tue 15 Dec 2009 21:13:55 -0500, a écrit :
> Would it be desirable to have compiler visibility enabled in hwloc?

Yes.  I don't have an m4 fragment to check for visibility off-hand,
that's why I hadn't done it yet and just relied on the hwloc_ prefix :)
(which is still useful when debugging bigger applications to know which
library a stack frame is in)

> Such things can be copied over from the OMPI code base.

That should be fine, yes.

Samuel