Re: [hwloc-users] Build warnings with hwloc-2.0.3
> On Mar 18, 2019, at 9:14 AM, Brice Goglin wrote: > I am planning to fix this in 2.1 (to be released before summer). I'll > backport the trivial pieces to 2.0.x too. > > Do you care about a specific value passed to -Wstack-usage=X? or do you > just want to avoid dynamic/unbounded allocs on the stack? Thanks, Brice. The specific value is not so important as long as it's not crazy high. FYI, we use 256K in mpich, but that was somewhat arbitrarily chosen. -- Pavan ___ hwloc-users mailing list hwloc-users@lists.open-mpi.org https://lists.open-mpi.org/mailman/listinfo/hwloc-users
Re: [hwloc-users] Build warnings with hwloc-2.0.3
Hello Pavan I am planning to fix this in 2.1 (to be released before summer). I'll backport the trivial pieces to 2.0.x too. Do you care about a specific value passed to -Wstack-usage=X? or do you just want to avoid dynamic/unbounded allocs on the stack? Brice Le 18/03/2019 à 15:04, Balaji, Pavan via hwloc-users a écrit : > Brice, all, > > Any update on this? Are you guys planning on fixing these? > > -- Pavan > >> On Feb 25, 2019, at 7:33 AM, Balaji, Pavan via hwloc-users >> wrote: >> >> Hi Brice, >> >>> On Feb 25, 2019, at 2:27 AM, Brice Goglin wrote: >>> Are you sure you're not passing -Wstack-usage? My Ubuntu 18.04 with >>> latest gcc-7 (7.3.0-27ubuntu1~18.04) doesn't show any of those warnings. >> Yes, you are right, -Wstack-usage was explicitly added too. Sorry, I missed >> the fact that it wasn't default in -Wall. >> >>> It looks like all these warnings are caused by C99 variable-length >>> arrays (except 2 that I don't understand). I know the kernel devs >>> stopped using VLA recently, and it looks like C11 made them optional. >>> But are we really supposed to stop using VLA already? >> They are optional, which means we cannot assume them for portability >> reasons. FWIW, we have made the rest of mpich stack-usage clean. >> >> -- Pavan >> >> ___ >> hwloc-users mailing list >> hwloc-users@lists.open-mpi.org >> https://lists.open-mpi.org/mailman/listinfo/hwloc-users > ___ > hwloc-users mailing list > hwloc-users@lists.open-mpi.org > https://lists.open-mpi.org/mailman/listinfo/hwloc-users ___ hwloc-users mailing list hwloc-users@lists.open-mpi.org https://lists.open-mpi.org/mailman/listinfo/hwloc-users
Re: [hwloc-users] Build warnings with hwloc-2.0.3
Brice, all, Any update on this? Are you guys planning on fixing these? -- Pavan > On Feb 25, 2019, at 7:33 AM, Balaji, Pavan via hwloc-users > wrote: > > Hi Brice, > >> On Feb 25, 2019, at 2:27 AM, Brice Goglin wrote: >> Are you sure you're not passing -Wstack-usage? My Ubuntu 18.04 with >> latest gcc-7 (7.3.0-27ubuntu1~18.04) doesn't show any of those warnings. > > Yes, you are right, -Wstack-usage was explicitly added too. Sorry, I missed > the fact that it wasn't default in -Wall. > >> It looks like all these warnings are caused by C99 variable-length >> arrays (except 2 that I don't understand). I know the kernel devs >> stopped using VLA recently, and it looks like C11 made them optional. >> But are we really supposed to stop using VLA already? > > They are optional, which means we cannot assume them for portability reasons. > FWIW, we have made the rest of mpich stack-usage clean. > > -- Pavan > > ___ > hwloc-users mailing list > hwloc-users@lists.open-mpi.org > https://lists.open-mpi.org/mailman/listinfo/hwloc-users ___ hwloc-users mailing list hwloc-users@lists.open-mpi.org https://lists.open-mpi.org/mailman/listinfo/hwloc-users
