[hwloc-users] Build warnings with hwloc-2.0.3

Folks, I'm getting the below build warnings with hwloc-2.0.3, gcc-7.3 on Ubuntu (with -Wall -O2): 8< ../../../../../../../../../mpich/src/pm/hydra/tools/topo/hwloc/hwloc/hwloc/distances.c: In function 'hwloc__groups_by_distances':

Re: [hwloc-users] Build warnings with hwloc-2.0.3

Hi Brice, > On Feb 25, 2019, at 2:27 AM, Brice Goglin wrote: > Are you sure you're not passing -Wstack-usage? My Ubuntu 18.04 with > latest gcc-7 (7.3.0-27ubuntu1~18.04) doesn't show any of those warnings. Yes, you are right, -Wstack-usage was explicitly added too. Sorry, I missed the fact

Re: [hwloc-users] Build warnings with hwloc-2.0.3

Brice, all, Any update on this? Are you guys planning on fixing these? -- Pavan > On Feb 25, 2019, at 7:33 AM, Balaji, Pavan via hwloc-users > wrote: > > Hi Brice, > >> On Feb 25, 2019, at 2:27 AM, Brice Goglin wrote: >> Are you sure you're not passing -Ws

Re: [hwloc-users] Build warnings with hwloc-2.0.3

> On Mar 18, 2019, at 9:14 AM, Brice Goglin wrote: > I am planning to fix this in 2.1 (to be released before summer). I'll > backport the trivial pieces to 2.0.x too. > > Do you care about a specific value passed to -Wstack-usage=X? or do you > just want to avoid dynamic/unbounded allocs on

[hwloc-users] hwloc LDFLAGS in embedded builds

Folks, We ran into an issue with the hwloc integration for MPICH. On Mac OS, hwloc detects that OpenCL is available, but the corresponding LDFLAGS are not exported upstream to MPICH, causing application builds to fail at the link stage. See this issue, for example:

Re: [hwloc-users] hwloc LDFLAGS in embedded builds

Thanks, Brice. -- Pavan > On May 25, 2019, at 1:43 AM, Brice Goglin wrote: > > Thanks Pavan, I am pushing this. > > Brice > > > > Le 25/05/2019 à 08:19, Balaji, Pavan via hwloc-users a écrit : >> Folks, >> >> We ran into an issue with the h

[hwloc-users] Unused function

Hello, We are maintaining this patch for hwloc internally in mpich. Can this be upstreamed? https://github.com/pmodels/hwloc/commit/a6d7018f092a0754433a0a2b17a527e64a125d38 It was throwing a warning when compiled with clang (and our usual strict flags): 8< CC

Re: [hwloc-users] Unused function

Hi Brice, > On May 29, 2020, at 3:51 AM, Brice Goglin wrote: > Oh sure, I thought we fixed this a while ago. I pushed it to master. Do > you need in 2.2 only or also earlier stable series? I don't we need a backport for now. We are currently at 2.0.3, but we'll likely upgrade to 2.2 before

Re: [hwloc-users] One more silly warning squash

Hi Samuel, > On Jun 1, 2020, at 4:06 AM, Samuel Thibault wrote: > could you check whether the attached patch avoids the warning? > (we should really not need a cast to const char*) The attached patch is basically the same as what we are using, isn't it? It does avoid the warning. -- Pavan

Re: [hwloc-users] One more silly warning squash

> On Jun 1, 2020, at 4:10 AM, Balaji, Pavan wrote: >> On Jun 1, 2020, at 4:06 AM, Samuel Thibault wrote: >> could you check whether the attached patch avoids the warning? >> (we should really not need a cast to const char*) > > The attached patch is basically the same as what we are using,

[hwloc-users] One more silly warning squash

Folks, We are seeing some warnings with the Intel compiler with hwloc (listed below). The warnings seem to be somewhat silly because there already is a cast to "char *" from the string literal, but it seems to expect a cast to "const char *" before casting to "char *". We are maintaining the

Re: [hwloc-users] One more silly warning squash

> On Jun 1, 2020, at 4:11 AM, Balaji, Pavan via hwloc-users > wrote: >> On Jun 1, 2020, at 4:10 AM, Balaji, Pavan wrote: >>> On Jun 1, 2020, at 4:06 AM, Samuel Thibault >>> wrote: >>> could you check whether the attached patch avoids the warning