Re: Review Request - 8021121: ISO 4217 Amendment Number 156

2013-08-06 Thread Yong Huang
Thanks for all the comments. I will change LV=LVL to LV=LVL;2013-12-31-22-00-00;EUR in CurrencyData.properties and also modify the corresponding regression test. thanks, Yong On 2013/8/7 0:45, Naoto Sato wrote: Yong, There already is a logic in Currency class to deal with such a future tr

Re: [8] Request for review: 8015986 : Incorrect Localization of HijrahChronology

2013-08-06 Thread Naoto Sato
Looks good to me. Naoto On 8/6/13 2:09 AM, Masayoshi Okutsu wrote: Hi, Please review the following fix: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015986 This fix is a workaround until JDK incorporates the chronology name and its translations from CLDR. The English and Arabic names

Re: Review Request - 8021121: ISO 4217 Amendment Number 156

2013-08-06 Thread Naoto Sato
Yong, There already is a logic in Currency class to deal with such a future transition nicely. That's what I meant. Masayoshi, Then it will be a regression till 1/1/2014. I don't see any problem using the transition logic here, IMO. Naoto On 8/6/13 2:13 AM, Masayoshi Okutsu wrote: Hi Yon

Re: Review Request - 8021121: ISO 4217 Amendment Number 156

2013-08-06 Thread Masayoshi Okutsu
Hi Yong, I think it's OK to use EUR without specifying the transition date-time for JDK 8. Thanks, Masayoshi On 8/6/2013 11:44 AM, Yong Huang wrote: Hi Naoto, To place the transition logic, do you mean I need to add comments in source file or do I just need to explain it in this email thre

[8] Request for review: 8015986 : Incorrect Localization of HijrahChronology

2013-08-06 Thread Masayoshi Okutsu
Hi, Please review the following fix: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015986 This fix is a workaround until JDK incorporates the chronology name and its translations from CLDR. The English and Arabic names for the JRE resources are preferred names given by Oracle globalizat