On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Wed, 25 May 2022 17:15:18 GMT, Naoto Sato wrote:
>> Refactoring the leftover self-calculations of the optimized `HashMap`
>> initial value with `newHashMap()` method. Also replaced some string literals
>> using text blocks for better readability. Confirmed that the output resource
>>
On Tue, 17 May 2022 23:40:04 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Wed, 11 May 2022 20:04:39 GMT, Naoto Sato wrote:
>> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
>> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
>> Corresponding CSR is also being drafted.
>
> Naoto Sato has updated the pull
On Wed, 11 May 2022 17:04:41 GMT, Naoto Sato wrote:
>> This is to extend the `Custom ID`s in `java.util.TimeZone` class to support
>> second-level resolution, enabling round trips with `java.time.ZoneOffset`s.
>> Corresponding CSR is also being drafted.
>
> Naoto Sato has updated the pull
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote:
> Trivial fix to 3rd party copyright notices.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8558
On Thu, 14 Apr 2022 18:10:28 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add `@LastModified: Apr 2022` to DocumentCache
Marked as reviewed by
On Thu, 14 Apr 2022 18:05:48 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>> line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2015, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: */
>>
>> The LastModified
On Thu, 14 Apr 2022 17:05:39 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes on ProcessEnvironment
On Thu, 14 Apr 2022 01:13:18 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java
>> line 1819:
>>
>>> 1817: Map items;
>>> 1818: LargeContainer(int size) {
>>> 1819: items =
On Thu, 14 Apr 2022 01:15:05 GMT, XenoAmess wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java
>> line 171:
>>
>>> 169: _current = 0;
>>> 170: _size = size;
>>> 171: _references = HashMap.newHashMap(_size);
>>
>> Not
On Wed, 13 Apr 2022 16:29:11 GMT, XenoAmess wrote:
>> 8186958: Need method to create pre-sized HashMap
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert changes in:
> src/java.desktop
> src/java.management
>
On Tue, 12 Apr 2022 20:33:53 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Tue, 12 Apr 2022 20:33:53 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote:
>> This is to upgrade the CLDR data from version 39 to version 41 which was
>> released yesterday. The vast majority of the changes are basically replacing
>> the CLDR data, along with tools/testcase alignments. Here is the link to
>> CLDR
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
>>
>>> 61: Locale.of("it", "IT", "EURO"),
>>> 62: Locale.forLanguageTag("de-AT"),
>>> 63: Locale.forLanguageTag("fr-CH"),
>>
>> Use the
On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
>>
>>> 79:
>>> 80: /**
>>> 81: * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
>>
>> Locale.France?
>
> The test code parses the input string
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE
> redenomination (removing 3 zeros). Its effective date is 4/1, but I went
> ahead as JDK19 won't be released by 4/1.
Marked as reviewed by joehw (Reviewer).
On Fri, 11 Mar 2022 22:20:38 GMT, Naoto Sato wrote:
>> `DecimalFormat.toLocalizedPattern()` was not honoring the monetary
>> decimal/grouping separator symbols. Fix is straightforward to use the
>> correct symbols depending on the formatter type.
>
> Naoto Sato has updated the pull request
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For the bundles in java.xml:
For files with Oracle copyright, update the year to 2022 and @LastModified Mar
2022. Take XPATHErrorResources_ja.java as an example, the copyright year was
updated to 2021 and
On Mon, 7 Mar 2022 18:20:43 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The
On Mon, 7 Mar 2022 03:00:45 GMT, Roger Riggs wrote:
>> OK, I propose `isIsoBased()` for the name, which I initially thought of. If
>> there is no objection, I will modify the spec/impl.
>
> Is `IsoBased` is fine with me. "isISOLike" is too vague.
That matches the javadoc as well, that it
On Fri, 4 Mar 2022 05:02:37 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote:
> Fixing the definition and implementation of the pattern symbol `F`. Although
> it is an incompatible change, I believe it is worth the fix. For that, a CSR
> has been drafted.
Was the following assessment in the bug report correct?
On Tue, 15 Feb 2022 22:31:28 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/CompactNumberFormat.java line 595:
>>
>>> 593: divisor = (Long) divisors.get(++compactDataIndex);
>>> 594: iPart = getIntegerPart(number, divisor);
>>> 595: }
On Tue, 15 Feb 2022 22:31:47 GMT, Naoto Sato wrote:
>> Fixing an issue in `CompactNumberFormat` which was caused by
>> BigDecimal.divide() that incremented the number in the resulting format
>> string. Also fixing some typos by taking this opportunity.
>
> Naoto Sato has updated the pull
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote:
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
Marked as reviewed by joehw (Reviewer).
On Wed, 9 Feb 2022 22:37:45 GMT, Naoto Sato wrote:
> Fixing an issue in `CompactNumberFormat` which was caused by
> BigDecimal.divide() that incremented the number in the resulting format
> string. Also fixing some typos by taking this opportunity.
On Tue, 8 Feb 2022 19:08:45 GMT, Naoto Sato wrote:
>> Following the prior discussion [1], here is the PR for the subject
>> enhancement. CSR has also been updated according to the suggestion.
>>
>> [1]
>> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
>
> Naoto
On Thu, 3 Feb 2022 23:29:54 GMT, Naoto Sato wrote:
> Following the prior discussion [1], here is the PR for the subject
> enhancement. CSR has also been updated according to the suggestion.
>
> [1]
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-January/085175.html
Hi Naoto,
Looks good to me, and thanks for the explanation. I agree, AIOOBE would
be a separate bug with ofPattern.
Thanks,
Joe
On 1/25/22 2:30 PM, Naoto Sato wrote:
Hi Joe,
On 1/24/22 5:50 PM, Joe Wang wrote:
The 2nd and 3rd statements defined the requestedTemplate,
does it imply
dPattern(Set
template), but not exactly suffices the need.
Naoto
On 1/20/22 9:52 PM, Joe Wang wrote:
Hi Naoto,
The javadoc points to LDML, it seems to me though it might be useful
to add more information similar to that for the ofPattern methods,
what's under the "Patterns for Formattin
Hi Naoto,
The javadoc points to LDML, it seems to me though it might be useful to
add more information similar to that for the ofPattern methods, what's
under the "Patterns for Formatting and Parsing" section, so that for at
least the common use cases we could rely on the javadoc without
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
I like how they changed dizzy face to face with crossed-out eyes. Pistol to
water pistol,
On Mon, 3 Jan 2022 19:37:03 GMT, Naoto Sato wrote:
>> The proposed fix is to address the performance degradation caused by the fix
>> to JDK-8275721. Some amount of the degradation cannot be avoided as the
>> lookup now falls back up to the bundles at Locale.ROOT. However, by lowering
>> the
On Mon, 6 Dec 2021 20:32:55 GMT, Naoto Sato wrote:
>> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
>> display names were incorrectly substituted for CLDR. The reason it worked
>> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the
>> names for
On Sat, 4 Dec 2021 22:34:50 GMT, Naoto Sato wrote:
>> Fixing time zone name provider for CLDR. In some cases, COMPAT's `UTC`
>> display names were incorrectly substituted for CLDR. The reason it worked
>> fine after `zh-Hant-HK` was that by loading names for `zh-Hant-HK`, the
>> names for
On Mon, 29 Nov 2021 18:48:45 GMT, Naoto Sato wrote:
> Fixing tests that fail at DST->STD offset transition. Simply skipping the
> tests on that occasion.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6598
On Wed, 24 Nov 2021 23:25:22 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with two additional
>
On Tue, 23 Nov 2021 23:50:36 GMT, Naoto Sato wrote:
>> This fix intends to honor the type (std/dst/generic) of parsed zone name for
>> selecting the offset at the overlap. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
>
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote:
> While working on tzdata2021c update, I noticed there is a dead code in
> `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for
> `endOfDay` for certain cases. These are no longer needed as JDK's code is
> already capable
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato wrote:
>> Fixing an AIOOBE on normalizing the month value.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed the unnecessary space
Marked as reviewed by joehw (Reviewer).
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote:
> Fixing an AIOOBE on normalizing the month value.
Marked as reviewed by joehw (Reviewer).
src/java.base/share/classes/sun/util/calendar/BaseCalendar.java line 281:
> 279: month = 13 - (xm % 12);
> 280: if (month ==
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote:
>> Small spec clarification. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecting review comment.
Marked as reviewed by
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line
>> 120:
>>
>>> 118: * the locale sensitive services separated by a comma. It is only read
>>> and cached at
>>> 119: * the initialization of this class, so the
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote:
> Small spec clarification. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120:
> 118: * the locale sensitive services separated by a comma. It is only read
> and cached at
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. The root cause of this problem is
> that the currency for the country code `XK` is undefined because the country
> code is user-defined in the ISO 3166 standard. However, it is commonly used
> to
On Wed, 30 Jun 2021 21:38:43 GMT, Naoto Sato wrote:
> A trivial typo fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/187
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
On Mon, 28 Jun 2021 18:45:31 GMT, Lance Andersen wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Refined wording.
>
> src/java.base/share/classes/java/util/Locale.java line 460:
>
>> 458: * back to that of before
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato wrote:
> Please review the fix. The issue was informed yesterday by @amaembo that it
> offends some code analysis tools.
> Although the fix is to change the condition error, it turned out that
> `JapaneseImperialCalendar.roll()` did not work for
On Tue, 18 May 2021 23:35:12 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleTest.java line 683:
>>
>>> 681: * @bug 4052404 4778440 8263202
>>> 682: */
>>> 683: public void TestChangedISO639Codes() {
>>
>> Could probably be simplified with a DataProvider.
>
> That would
On Tue, 18 May 2021 23:39:37 GMT, Naoto Sato wrote:
>> Please review the changes to the subject issue. java.util.Locale class has a
>> long-standing issue for those obsolete ISO 639 languages where its
>> normalization ends up in the obsolete codes. This change intends to flip the
>>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
>
On Wed, 12 May 2021 16:28:54 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. This is to incorporate the
> latest language subtag registry definition into the JDK.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3998
On Mon, 10 May 2021 23:12:04 GMT, Naoto Sato wrote:
> Please review this test case fix for the upcoming jtreg 6. The test was using
> `@BeforeGroups` annotation, and the behavior of it has changed in TestNG 7.1
> so that it is only issued when the test was configured with filtering.
> Changed
On Fri, 16 Apr 2021 21:10:42 GMT, Naoto Sato wrote:
> Please review the fix to the tier4 build failure. The piece of code that made
> into `CLDRLocaleProviderAdapter.java` was also needed in the build tool
> counterpart (`CLDRConverter`).
Marked as reviewed by joehw (Reviewer).
-
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
>
On Thu, 8 Apr 2021 18:19:20 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. It is not actually related to
> "parenthesized", but period-comma sequence was regarded as a break on a
> backward traverse.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. Thanks to the contribution by
> Chris Johnson.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3300
On Fri, 19 Mar 2021 21:23:03 GMT, Naoto Sato wrote:
>> Fixed several broken links to Unicode.org.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments.
Looks all good. Thanks Naoto.
-
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Some minor comments.
src/java.base/share/classes/java/text/Collator.java line 211:
> 209: * FULL_DECOMPOSITION corresponds to Normalization Form KD as
> 210: * described in
> 211: *
On Tue, 23 Feb 2021 02:09:01 GMT, Naoto Sato wrote:
> Please review the fix to this test case failure that occurs with the usage
> tracker enabled JRE.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2683
On Fri, 12 Feb 2021 04:06:55 GMT, Naoto Sato wrote:
>> Please review this doc fix to j.l.Character, which now includes the table of
>> the history of supported Unicode versions. A corresponding CSR will be filed
>> accordingly.
>
> Naoto Sato has updated the pull request incrementally with one
On Tue, 9 Feb 2021 00:04:44 GMT, Naoto Sato wrote:
>> The fix looks ok to me. Just an interesting note that this test took such a
>> long time to run. Given the amount of locales, limit(30) would reduce the
>> time to approximately 1/5 of the time, that would still be about 100,000ms
>>
On Mon, 8 Feb 2021 21:42:36 GMT, Naoto Sato wrote:
> Please review this simple test case fix. By sampling locales to test, it
> reduces the possibility of the time out.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2465
On Mon, 8 Feb 2021 21:52:45 GMT, Lance Andersen wrote:
>> Please review this simple test case fix. By sampling locales to test, it
>> reduces the possibility of the time out.
>
> Marked as reviewed by lancea (Reviewer).
The fix looks ok to me. Just an interesting note that this test took such
On Thu, 4 Feb 2021 22:17:12 GMT, Naoto Sato wrote:
> Please review this fix. The bug was revealed while porting CLDR v39 into the
> JDK, where they switch the Norwegian Bokmal from "nb" to "no". [1] Some
> regression tests started failing with it because COMPAT provider's "nb"
> resource was
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2028
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
Oops, forgot to submit the review ;-)
src/java.base/share/classes/java/text/Normalizer.java line 48:
> 46: * The {@code normalize} method supports the standard normalization forms
> 47: * described in
>
On Tue, 15 Dec 2020 01:36:27 GMT, Brent Christian wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java
>> line 152:
>>
>>> 150: *
>>> 151: * Care must be taken when defining such a filter, as defining
>>> 152: * an accept-list too
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote:
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
>
On Fri, 11 Dec 2020 01:28:59 GMT, Naoto Sato wrote:
>> test/jdk/java/util/Locale/LocaleProvidersRun.java line 177:
>>
>>> 175:
>>> 176: //testing 8257964 fix. (macOS/Windows only)
>>> 177: testRun("HOST", "bug8257964Test", "", "", "");
>>
>> This test runs only if the platform
On Fri, 11 Dec 2020 01:25:48 GMT, Naoto Sato wrote:
>> src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
>> line 78:
>>
>>> 76: // CalendarData value types
>>> 77: private static final int CD_FIRSTDAYOFWEEK = 0;
>>> 78: private static final
On Thu, 10 Dec 2020 21:12:29 GMT, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the subject issue. getMinimalDaysInFirstWeek()
> for Windows has been implemented to suffice the bug claim.
Looks good to me. Some minor comments below.
On Fri, 20 Nov 2020 17:55:55 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes to the subject issue. This is to incorporate the
> latest language subtag registry definition into the JDK.
Marked as reviewed by joehw (Reviewer).
-
PR:
On Tue, 17 Nov 2020 23:19:23 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes for upgrading the CLDR data to version 38. The vast
> majority of the changes are simply the changes in CLDR upstream, and others
> are mainly test changes due to the locale data change.
Looks good to me.
On Thu, 5 Nov 2020 17:12:11 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the changes for the subject issue. This is to enhance the
>> java.time package to support day periods, such as "in the morning", defined
>> in CLDR. It will add a new pattern character 'B' and its supporting builder
On Fri, 30 Oct 2020 11:42:49 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed TCK test failures, added the new pattern char description in
>> DateTimeFormatter
>
> Changes requested by
On Wed, 21 Oct 2020 23:38:23 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the changes to the subject issue. The fix replaces the
>> obsolete/incorrect English language/region/script display names in the
>> COMPAT root locale bundle. The data are derived from CLDR's English names.
>
>
On Thu, 22 Oct 2020 23:20:08 GMT, Naoto Sato wrote:
> Hi Joe,
>
> > Do we need a test similar to ISO3166 where display names of Locale.ROOT and
> > Locale.US are compared? I see LocaleEnhanceTest.java has references to
> > Locale.ROOT and a few selected names were updated. But we don't seem
On Sat, 19 Sep 2020 01:36:38 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the fix to JDK-8253321. As in the issue, uninitialized
>> (cached) hash code was incorrectly referenced in
>> equals() method. Removing it will correct the problem. Also, unrelated to
>> the issue, I fixed a
On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the fix to JDK-8253321. As in the issue, uninitialized (cached)
> hash code was incorrectly referenced in
> equals() method. Removing it will correct the problem. Also, unrelated to the
> issue, I fixed a parameter
On Fri, 18 Sep 2020 01:49:09 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/234
On Mon, 14 Sep 2020 22:18:34 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this simple doc fix.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/159
On Mon, 14 Sep 2020 23:15:10 GMT, Naoto Sato wrote:
>> Thanks, Lance,
>>
>>> The change looks fine. I might have created a CSR just to track the doc
>>> change.
>>
>> Yes, and thanks for the CSR review too!
>
> Thanks, Joe.
>
>> The change looks fine. However, are other methods in the same
On Mon, 14 Sep 2020 22:41:55 GMT, Lance Andersen wrote:
>> Hi,
>>
>> Please review this simple doc fix.
>
> Hi Naoto,
>
> The change looks fine. I might have created a CSR just to track the doc
> change.
The change looks fine. However, are other methods in the same situation, e.g.
void
+1
Or, maybe is not needed for code comments
-Joe
On 8/31/20 10:14 AM, Lance Andersen wrote:
Hi Naoto,
Looks OK to me.
Best
Lance
On Aug 31, 2020, at 12:22 PM, Naoto Sato wrote:
Hello,
Please review this simple javadoc fix to:
https://bugs.openjdk.java.net/browse/JDK-8252552
The
from the method (cnfMultiplier and whether
to return immediately for no-placeholder cases).
https://cr.openjdk.java.net/~naoto/8251499/webrev.02/
Naoto
On 8/17/20 11:52 PM, Joe Wang wrote:
Hi Naoto,
Looks good overall. One nit, blocks 1633-1639 and 1642-1649 may share
a common private method
1 - 100 of 140 matches
Mail list logo