Looks good to me.
Masayoshi
On 10/4/2012 3:08 AM, Naoto Sato wrote:
Hi Masayoshi,
Thank you for the review. I updated LocaleProviderAdapter.java
according to your comments. Also I fixed two instances of "if (locale
== Locale.ROOT)" statements in LocaleProviderAdapter.java and
CalendarDataPr
Hello,
Please review the fix for the following bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7200119
Proposed changes are located at:
http://cr.openjdk.java.net/~naoto/7200119/webrev.00/
This is just to add "en-US" to all the locale sensitive services, as it
is defined in the spec.
Hello,
Please review the fix for the following bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7200341
Proposed changes are located at:
http://cr.openjdk.java.net/~naoto/7200341/webrev.00/
The fix is to re-implement hashCode() correctly. It now also takes all
the fields into consider
Hello,
Please review the fix for the following bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198834
Proposed changes are located at:
http://cr.openjdk.java.net/~naoto/7198834/webrev.00/
The fix is just to not leave one space at the end of format string. Also
corrected a typo in JR
Looks good.
Masayoshi
On 10/5/2012 6:40 AM, Naoto Sato wrote:
Hello,
Please review the fix for the following bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7200119
Proposed changes are located at:
http://cr.openjdk.java.net/~naoto/7200119/webrev.00/
This is just to add "en-US" to
The fix will have a problem when called by multiple threads. Strictly
speaking, DateFormatSymbols isn't thread-safe, but the usage of
cachedHashCode will have a problem even with no set* calls.
I'd suggest the following.
int hashCode =cachedHashCode;
if (hashCode == 0) {
...
