Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-15 Thread naoto . sato
Hi Roger, Thank you for the review. Please find my comments below: On 1/15/20 10:30 AM, Roger Riggs wrote: Hi Naoto, Is it correct to say that there is no impact on startup until there is an explicit reference to HijrahChronology? It would seem that the registering HijrahChronology would trig

Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-15 Thread Roger Riggs
Hi, On 1/15/20 3:06 PM, naoto.s...@oracle.com wrote: Hi Roger, Thank you for the review. Please find my comments below: On 1/15/20 10:30 AM, Roger Riggs wrote: Hi Naoto, Is it correct to say that there is no impact on startup until there is an explicit reference to HijrahChronology? It woul

Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-15 Thread naoto . sato
Updated: https://cr.openjdk.java.net/~naoto/8187987/webrev.02/ The change includes the new naming convention, reduction of properties files reading to once, and utilization of logging. Naoto On 1/15/20 12:37 PM, Roger Riggs wrote: Hi, On 1/15/20 3:06 PM, naoto.s...@oracle.com wrote: Hi Ro