The changes looks fine, should we increment version=1 to other version
or it is not used? Unrelated question is how we validate all these paths
if some of them are absent?
On 23.09.16 8:08, Philip Race wrote:
PING .. any takers on this two week old RFR ?
-phil.
On 9/8/16, 1:12 PM, Philip
hat others get.
The fontset spec. there seems very loose to me ..
I think I18N-DEV should be asked about this too.
-phil.
On 06/19/2018 11:07 AM, Sergey Bylokhov wrote:
Looks fine, if there are no other comments I'll push the fix using the new
bugid.
On 06/06/2018 17:54, Ichiroh Takiguchi wrote:
Hi, Ichiroh.
The fix looks fine, it will be good if someone from i18n team will take a look.
On 04/02/2019 04:53, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix and give me your suggestion, please ?
JDK-8212678 [1] has screen shots and movies.
Please check them also.
[1]
/browse/JDK-8212677
Change: https://cr.openjdk.java.net/~itakiguchi/8212677/webrev.01/
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2018-12-01 09:49, Sergey Bylokhov wrote:
Looks fine, if there are no other comments I'll push the fix.
On 26/11/2018 05:02, Ichiroh Takiguchi wrote:
Hello.
Could you
Hi, Ichiroh.
Why the fix uses the "defined(MACOSX)" in a few places? I assume this code is
never executed on macOS.
Should we update the aix version as well?
.../java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c
On 25/03/2019 09:28, Ichiroh Takiguchi wrote:
Hello.
Could you review
ibX11.html
Thanks,
Ichiroh Takiguchi
On 2019-04-26 08:14, Sergey Bylokhov wrote:
Hi, Ichiroh.
I got this build error when I tried to test this patch:
open/src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c:83:5:
error: cast between incompatible function types from 'int (*)(struc
On 18/04/2019 04:09, Ichiroh Takiguchi wrote:
Should I remove "defined(MACOSX)" from awt_InputMethod.c or just modified code ?
Please give me your suggestion.
Ok, looks fine. Lets move cleanup of "defined(MACOSX)" in the xawt to some
separate task.
--
Best regards, Sergey.
b);
2191 AWT_UNLOCK();
Thanks,
Ichiroh Takiguchi
On 2019-04-11 11:19, Sergey Bylokhov wrote:
Hi, Ichiroh.
Why the fix uses the "defined(MACOSX)" in a few places? I assume this
code is never executed on macOS.
Should we update the aix version as well?
.../java.desktop/aix/nati
On Sun, 6 Sep 2020 13:57:19 GMT, Dmitriy Dumanskiy
wrote:
> **isEmpty** is faster + has less byte code + easier to read. Benchmarks could
> be found
>
> [here](https://medium.com/javarevisited/micro-optimizations-in-java-string-equals-22be19fd8416).
On Fri, 25 Sep 2020 21:45:39 GMT, Sergey Bylokhov wrote:
> We have a number of missing javadoc tags and comments in the desktop module.
> Most of the missing comments are related to the serialized form.
>
> The fix:
> - Adds missing comments to the non-static/non-transi
On Wed, 23 Sep 2020 19:31:28 GMT, Phil Race wrote:
> otherwise where will be the record other than the scattered changes
> themselves ?
> Please summarise along those lines.
The description is updated.
-
PR: https://git.openjdk.java.net/jdk/pull/315
On Wed, 23 Sep 2020 07:03:59 GMT, Sergey Bylokhov wrote:
> Looks like different people use a different style for the new constructors,
> it will be good to unify them.
>
> The text "Constructor for subclasses to call." should be used in the
> protected constructor
Looks like different people use a different style for the new constructors, it
will be good to unify them.
I have started from https://bugs.openjdk.java.net/browse/JDK-8252721
See
On Mon, 28 Sep 2020 06:30:31 GMT, Jayathirth D V wrote:
> Inputs from
> https://mail.openjdk.java.net/pipermail/beans-dev/2020-August/000424.html are
> incorporated or is this fresh
> git review?
It is a fresh update, it changes from the old review request. I made it less
"dangerous".
t change should be reviewed in the CSR(except
> PeerFixer removal)
>
> Note that in some cases I added the comments to the "implementation details",
> so I did not specify it fully.
>
> The old review request:
> https://mail.openjdk.java.net/pipermail/beans-dev/20
On Sat, 3 Oct 2020 03:57:21 GMT, Sergey Bylokhov wrote:
>>> I need advice about what exact change should be reviewed in the CSR(except
>>> PeerFixer removal)
>>
>> Probably almost all of it.
>
> The PeerFixer is extracted to the separate CR:
> https://b
We have a number of missing javadoc tags and comments in the desktop module.
Most of the missing comments are related to the serialized form.
The fix:
- Adds missing comments to the non-static/non-transient fields(even private)
of the "serializable" classes
- Adds comments to the
On Fri, 13 Nov 2020 18:20:37 GMT, Kevin Rushforth wrote:
>> Andy Herrick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8189198: Add "forRemoval = true" to Applet APIs
>
>
On Mon, 2 Nov 2020 09:04:39 GMT, Sergey Bylokhov wrote:
> Most of the broken links were fixed already by the JDK-8225368 and JDK-8214817
> This change fix just a few.
>
> Also two cleanups are applied:
> - The `../../java/awt/doc-files/` in some cases simplified to `doc-files/
Most of the broken links were fixed already by the JDK-8225368 and JDK-8214817
This change fix just a few.
Also two cleanups are applied:
- The `../../java/awt/doc-files/` in some cases simplified to `doc-files/`
- The html links to the java classes via `` replaced by the `{@link }`
On Mon, 2 Nov 2020 09:04:39 GMT, Sergey Bylokhov wrote:
> Most of the broken links were fixed already by the JDK-8225368 and JDK-8214817
> This change fix just a few.
>
> Also two cleanups are applied:
> - The `../../java/awt/doc-files/` in some cases simplified to `doc-files/
Please review the application of @java.io.Serial annotation (JDK-8202385) to
types in the desktop module to enable stricter compile-time checking of
serialization-related declarations.
This annotation can be applied to these methods in the module:
private void
On Wed, 20 Jan 2021 05:19:15 GMT, Ichiroh Takiguchi
wrote:
>> Hello Dmitry.
>> Sorry, I should use GitHub instead of mailing list.
>> I tested your fix, I saw side effect by committing preedit string.
>> I'll give you detail information.
>
> I tried attached testcase.
> import java.awt.*;
>
On Mon, 11 Jan 2021 06:21:52 GMT, Sergey Bylokhov wrote:
> Please review the application of @java.io.Serial annotation (JDK-8202385) to
> types in the desktop module to enable stricter compile-time checking of
> serialization-related declarations.
>
> This annotation
On Wed, 13 Jan 2021 06:10:53 GMT, Prasanta Sadhukhan
wrote:
> Why do we add serialVersionUID in some classes like
> DefaultMutableTreeNode.java but not in other swing classes?
Most Swing classes are marked by the specific "Warning" that "Same-version
serialization only" is supported. (I
On Tue, 12 Jan 2021 11:29:24 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update
>> src/java.desktop/share/classes/java/awt/image/ImagingOpException
d some others are excluded from
> the serialization specification.
>
> A similar fix was implemented for java.base module as well:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062046.html
Sergey Bylokhov has updated the pull request incrementally with two additional
commi
On Fri, 5 Mar 2021 18:53:29 GMT, Claes Redestad wrote:
>> This patch refactors Locale.getDefault(Category) so that the volatile field
>> holding the Locale is typically only read once. This has a small performance
>> advantage, and might be more robust if initialization is racy.
>
> Claes
On Sat, 6 Mar 2021 13:34:14 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/util/Locale.java line 946:
>>
>>> 944: Locale loc = defaultDisplayLocale; // volatile read
>>> 945: if (loc == null) {
>>> 946: loc = getDisplayLocale();
>>
>>
On Fri, 5 Mar 2021 18:53:29 GMT, Claes Redestad wrote:
>> This patch refactors Locale.getDefault(Category) so that the volatile field
>> holding the Locale is typically only read once. This has a small performance
>> advantage, and might be more robust if initialization is racy.
>
> Claes
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
The changes in the src/java.desktop/ looks fine.
Filed: https://bugs.openjdk.java.net/browse/JDK-8272863
-
Marked as reviewed by
On Wed, 25 Aug 2021 17:53:00 GMT, Andrey Turbanov
wrote:
>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
>> use `ArrayList` if a thread-safe implementation is not needed. In
>> post-BiasedLocking times, this is gets worse, as every access is
>> synchronized.
On Fri, 27 Aug 2021 17:52:19 GMT, Andrey Turbanov
wrote:
>> src/java.desktop/share/classes/javax/swing/JMenu.java line 1340:
>>
>>> 1338: }
>>> 1339: MenuElement[] me = new MenuElement[elements.size()];
>>> 1340: elements.toArray(me);
>>
>> Implementation of the
On Tue, 24 Aug 2021 21:13:57 GMT, Andrey Turbanov
wrote:
>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
>> use `ArrayList` if a thread-safe implementation is not needed. In
>> post-BiasedLocking times, this is gets worse, as every access is
>> synchronized.
On Mon, 30 Aug 2021 15:52:05 GMT, Ian Graves wrote:
>> 8271302: Regex Test Refresh
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing some notes re JUnit5
Looks like it was missed that the test fails oi a github
On Fri, 20 Aug 2021 09:41:15 GMT, Сергей Цыпанов
wrote:
> This is a continuation of
>
> - https://bugs.openjdk.java.net/browse/JDK-6736490
> - https://bugs.openjdk.java.net/browse/JDK-8035284
> - https://bugs.openjdk.java.net/browse/JDK-8145680
> -
On Mon, 23 Aug 2021 13:08:02 GMT, Alexey Ivanov wrote:
>> Looks like there's no purpose, `tags` is not used after assignment
>
> Maybe it's kind of a protection from a race. Yet it's possible either way:
> another thread could see `essentialTags == null` before this one initialises
> the
On Fri, 3 Sep 2021 08:04:52 GMT, Andrey Turbanov
wrote:
>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
>> use `ArrayList` if a thread-safe implementation is not needed. In
>> post-BiasedLocking times, this is gets worse, as every access is
>> synchronized.
>>
On Wed, 1 Sep 2021 19:46:51 GMT, Andrey Turbanov
wrote:
>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
>> use `ArrayList` if a thread-safe implementation is not needed. In
>> post-BiasedLocking times, this is gets worse, as every access is
>> synchronized.
>>
On Sun, 4 Jul 2021 20:42:41 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if a thread-safe implementation is not needed. In
> post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I
On Mon, 5 Jul 2021 14:00:07 GMT, Сергей Цыпанов
wrote:
>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
>> use `ArrayList` if a thread-safe implementation is not needed. In
>> post-BiasedLocking times, this is gets worse, as every access is
>> synchronized.
>>
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev
wrote:
> This fix simply describes that the `java.awt.im.InputContext` is a dummy
> implementation, which may not conform its spec.
I am fine with any solution but think the check will be simpler and safer, and
later we will be able to
On Tue, 12 Oct 2021 13:39:21 GMT, Alexander Zvegintsev
wrote:
>> This fix simply describes that the `java.awt.im.InputContext` is a dummy
>> implementation, which may not conform its spec.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since
On Fri, 8 Oct 2021 19:37:35 GMT, Andrey Turbanov wrote:
> Cycles with 'Iterator' are error-prone. It's better to use more high-level
> code, which easier to read.
> We can use enhanced-for or Collection.removeIf
src/java.desktop/share/classes/javax/swing/JDesktopPane.java line 330:
> 328:
On Sat, 9 Oct 2021 11:16:29 GMT, Alexander Zvegintsev
wrote:
>> This fix simply describes that the `java.awt.im.InputContext` is a dummy
>> implementation, which may not conform its spec.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since
On Tue, 5 Oct 2021 08:13:53 GMT, Andrey Turbanov wrote:
> 8274893: Update java.desktop classes to use try-with-resources
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java line
587:
> 585: // Pending: verify character encoding spec for gconf
> 586:
On Wed, 20 Oct 2021 16:48:41 GMT, Phil Race wrote:
>> The code this test exercises is very obsolete. So this removes the test that
>> triggers it along with that code.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8198336:
On Wed, 20 Oct 2021 04:12:46 GMT, Phil Race wrote:
> The code this test exercises is very obsolete. So this removes the test that
> triggers it along with that code.
src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java line 696:
> 694: && ((SunFontManager)
On Sun, 26 Sep 2021 20:57:58 GMT, Sergey Bylokhov wrote:
>> Agree.
>
> I still suggest to remove the local tag completely.
@jayathirthrao @stsypanov Looks like this was not addressed? It will be good
to include it in some future cleanup.
-
PR: https://git.openjdk.
On Fri, 8 Oct 2021 18:44:41 GMT, Alexey Ivanov wrote:
>> @jayathirthrao @stsypanov Looks like this was not addressed? It will be
>> good to include it in some future cleanup.
>
> As far as I can see, it was. [Line
>
On Fri, 8 Oct 2021 19:37:35 GMT, Andrey Turbanov wrote:
> Cycles with 'Iterator' are error-prone. It's better to use more high-level
> code, which easier to read.
> We can use enhanced-for or Collection.removeIf
Marked as reviewed by serb (Reviewer).
-
PR:
On Mon, 23 Aug 2021 18:31:08 GMT, Alexey Ivanov wrote:
>> I think we can drop it completely.
>
> Agree.
I still suggest to remove the local tag completely.
-
PR: https://git.openjdk.java.net/jdk/pull/5197
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov
wrote:
> Flipping arguments of 'equals' method, allows simplifying boolean
> expressions: now we can remove redundant null check before.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5794
On Mon, 4 Oct 2021 14:54:27 GMT, Alexander Zvegintsev
wrote:
> This fix simply describes that the `java.awt.im.InputContext` is a dummy
> implementation, which may not conform its spec.
If the problem is in the validation of the parameters maybe we can enforce it?
-
PR:
On Mon, 4 Oct 2021 18:07:48 GMT, Alexander Zvegintsev
wrote:
> Another solution is to make this class abstract.
It won't help, since they will subclass this class and call the parent methods,
which they do a few times already for some other cases.
-
PR:
On Mon, 4 Oct 2021 18:07:48 GMT, Alexander Zvegintsev
wrote:
> So those validation of the parameters enforcements will be an almost dead
> code, only used by synthetic specification test.
But is it worth it to update the spec in stone that these methods will return
null/false/no-exceptions
On Sat, 2 Oct 2021 09:14:49 GMT, Andrey Turbanov
wrote:
> Flipping arguments of 'equals' method, allows simplifying boolean
> expressions: now we can remove redundant null check before.
Looks fine
src/java.desktop/share/classes/javax/swing/JSplitPane.java line 1000:
> 998:
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote:
> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial
> checking are out for review (#5709) and various client libraries would need
> some changes to pass under the expanded checks.
>
> The changes are to suppress
On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy wrote:
>> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial
>> checking are out for review (#5709) and various client libraries would need
>> some changes to pass under the expanded checks.
>>
>> The changes are to suppress
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
> I updated only private and package-private classes. Didn't touch
> public/protected to not break external code.
> Similar cleanup in
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API
On Wed, 13 Oct 2021 07:35:16 GMT, Andrey Turbanov wrote:
>> 8274893: Update java.desktop classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8274893: Update java.desktop classes to use
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
> I updated only private and package-private classes. Didn't touch
> public/protected to not break external code.
> Similar cleanup in
On Tue, 23 Nov 2021 20:52:40 GMT, Andrey Turbanov wrote:
>> 8274893: Update java.desktop classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8274893: Update java.desktop classes to use
On Mon, 10 Jan 2022 05:25:51 GMT, Prasanta Sadhukhan
wrote:
> The changes done under JDK-8278175 suppress on a per-file basis various
> missing comments that would otherwise trigger doclint warnings. Fixed them so
> as to remove the doclint:missing warnings.
On Thu, 20 Jan 2022 06:12:29 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7189
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has
On Mon, 24 Jan 2022 06:03:42 GMT, Prasanta Sadhukhan
wrote:
>> The changes done under JDK-8278175 suppress on a per-file basis various
>> missing comments that would otherwise trigger doclint warnings. Fixed them
>> so as to remove the doclint:missing warnings.
>
> Prasanta Sadhukhan has
69 matches
Mail list logo
