Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v4]

2022-09-30 Thread Naoto Sato
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote: >> Problem: Unnecessary instances of StringBuffer within java.text (internal >> only) >> >> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method >> names > > Justin Lu has updated the pull request incrementally with two

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v4]

2022-09-30 Thread Justin Lu
> Problem: Unnecessary instances of StringBuffer within java.text (internal > only) > > Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method > names Justin Lu has updated the pull request incrementally with two additional commits since the last revision: - Remove

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-30 Thread Roger Riggs
On Fri, 30 Sep 2022 16:52:40 GMT, Brent Christian wrote: >> Due to some [bootstrapping >> issues](https://stackoverflow.com/questions/71834059/why-invokedynamic-based-string-concatenation-is-not-available-for-javac-in-java) >> in `java.base` explicit String concatenation is not translated into

Integrated: 8294307: ISO 4217 Amendment 173 Update

2022-09-30 Thread Justin Lu
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote: > Problem: Amendment number outdated > > Fix: Update amendment number + date in properties file and test case data file This pull request has now been integrated. Changeset: 3b1bc217 Author:Justin Lu Committer: Naoto Sato URL:

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-30 Thread Brent Christian
On Fri, 30 Sep 2022 16:14:38 GMT, Сергей Цыпанов wrote: >> src/java.base/share/classes/java/text/PatternEntry.java line 291: >> >>> 289: // We re-use these objects in order to improve performance >>> 290: private StringBuilder newChars = new StringBuilder(); >>> 291:

Re: RFR: 8294307: ISO 4217 Amendment 173 Update

2022-09-30 Thread Naoto Sato
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote: > Problem: Amendment number outdated > > Fix: Update amendment number + date in properties file and test case data file LGTM - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.org/jdk/pull/10499

Re: RFR: 8294397: Replace StringBuffer with StringBuilder within java.text [v3]

2022-09-30 Thread Сергей Цыпанов
On Thu, 29 Sep 2022 22:29:43 GMT, Brent Christian wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweak indentation in PaternEntry > > src/java.base/share/classes/java/text/PatternEntry.java line 291: > >> 289:

Re: RFR: 8294307: ISO 4217 Amendment 173 Update

2022-09-30 Thread Brian Burkhalter
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote: > Problem: Amendment number outdated > > Fix: Update amendment number + date in properties file and test case data file Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10499

Re: RFR: 8282227: Locale information for nb is not working properly

2022-09-30 Thread Eivind Bergstøl
On Tue, 26 Apr 2022 00:32:48 GMT, Naoto Sato wrote: > This was caused by incorporating CLDR v39, which switched the Norwegian > locale inheritance from `no` -> `nb` to `nb` ->`no` and moved the resources > from `nb` to `no`, which now contradicts Java's locale fallback. Explicitly >

Integrated: 8294357: (tz) Update Timezone Data to 2022d

2022-09-30 Thread Yoshiki Sato
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote: > Please review this PR. The change include some code changes in > ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks > TestZoneInfo310.java. This pull request has now been integrated. Changeset: f0157336 Author:

Re: RFR: 8294357: (tz) Update Timezone Data to 2022d

2022-09-30 Thread Naoto Sato
On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato wrote: > Please review this PR. The change include some code changes in > ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks > TestZoneInfo310.java. Marked as reviewed by naoto (Reviewer). - PR:

Re: RFR: 8294357: (tz) Update Timezone Data to 2022d

2022-09-30 Thread Naoto Sato
On Fri, 30 Sep 2022 04:54:27 GMT, Yoshiki Sato wrote: >> test/jdk/java/util/TimeZone/TimeZoneData/displaynames.txt line 170: >> >>> 168: Europe/Vilnius EET EEST >>> 169: Europe/Warsaw CET CEST >>> 170: Europe/Zaporozhye EET EEST >> >> Do we need to remove those newly linked zone ids from