Re: RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

2022-10-29 Thread Сергей Цыпанов
On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu wrote: > Issue: Duplication of methods between Basic*.java test classes, due to auto > generation by genBasic.sh > > Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. > Toggled -nel flag for generation script

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-29 Thread Alexey Ivanov
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-29 Thread Alexey Ivanov
On Mon, 24 Oct 2022 19:29:41 GMT, Andy Goryachev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Remove check for .properties from jcheck" >> >>This reverts commit