[15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-14 Thread naoto . sato
Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8187987 The proposed CSR and changeset are located at: CSR: https://bugs.openjdk.java.net/browse/JDK-8236810 Webrev: https://cr.openjdk.java.net/~naoto/8187987/webrev.00/ The spec of

Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-14 Thread Joe Wang
Hi Naoto, Since it's dealing with non-standard properties files, is there a need to verify the files? The constructor (HijrahChronology) does check whether the id or type is empty. If there is no existing process to validate, it's probably not worth it to spend time as it's rare and it's

Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-14 Thread naoto . sato
Hi Joe, Thank you for the review. Please find my comments below: On 1/14/20 3:35 PM, Joe Wang wrote: Hi Naoto, Since it's dealing with non-standard properties files, is there a need to verify the files? The constructor (HijrahChronology) does check whether the id or type is empty. If there

Re: [15] RFR: 8187987: Add a mechanism to configure custom variants in HijrahChronology

2020-01-14 Thread Joe Wang
On 1/14/20 6:04 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for the review. Please find my comments below: On 1/14/20 3:35 PM, Joe Wang wrote: Hi Naoto, Since it's dealing with non-standard properties files, is there a need to verify the files? The constructor (HijrahChronology)