A New Internet-Draft is available from the on-line Internet-Drafts directories.
This draft is a work item of the Interface to Network Security Functions WG of
the IETF.
Title : I2NSF NSF Monitoring Interface YANG Data Model
Authors : Jaehoon (Paul) Jeong
Tom,
What you suggested seems pretty simple to fix. Hope the authors will address
them soon.
p.s. the YANG doctor review didn't mention using this style.
Thank you very much.
Linda
-Original Message-
From: tom petch
Sent: Thursday, April 29, 2021 5:24 AM
To: Linda Dunbar ;
to detect the source and destination (as a victim) of security
> attacks
> > such as DDoS attack.
> > ---
> > If you have questions and comments, please let me know.
> >
> > Thanks.
> >
> > Best Regards,
> > Paul
> >
> >
> > O
}
>>> }
>>>
>>>
>>> // could add sub-events via augments at any time
>>> augment "/i2nsf-event/sub-event-type" {
>>>case i2nsf-system-detection-event {
>>> if-feature "i2nsf-system-detection-event";
>>> container i2nsf-system-detection-event {
>>>// contents of i2nsf-system-detection-event data
>>> }
>>>}
>>> }
>>>
>>>
>>> Nits:
>>>
>>> 4) underscore vs. hyphen
>>>
>>> There are many field names in sec. 7 that are incorrect
>>> because they use an underscore instead of a hyphen char
>>> (e.g. req_cookies but leaf name is req-cookies)
>>>
>>> 5) verbose SNMP-style names
>>>
>>> The term -configuration in the object names is unusual.
>>> Repeating the parent name (like SMIv2) is not usually done in YANG.
>>> (e.g., i2nsf-system-detection-event-configuration)
>>>
>>> 6) identifiers should use well-known abbreviations or spell
>>> out the word if not too long. E.g "ave" -> "average"
>>>
>>> 7) Is there a reason some identities are ALL-CAPS and others
>>> are all-lower-case? This should be explained in the YANG module.
>>>
>>>
>>>
>>>
>>>
>>>
>>>
Revision-Letter-for-NSF-Monitoring-YANG-Data-Model-version-08-20210429.pdf
Description: Adobe PDF document
___
I2nsf mailing list
I2nsf@ietf.org
https://www.ietf.org/mailman/listinfo/i2nsf
Hi Tom,
According to your comments, we authors will minimize the usage of range
matches in the revision.
Thanks.
Best Regards,
Paul
On Thu, Apr 29, 2021 at 7:24 PM tom petch wrote:
> From: Linda Dunbar
> Sent: 27 April 2021 16:49
> Tom,
>
> Can you please provide the concrete suggestions to
From: Linda Dunbar
Sent: 29 April 2021 15:27
Tom,
What you suggested seems pretty simple to fix. Hope the authors will address
them soon.
p.s. the YANG doctor review didn't mention using this style.
Linda,
Yes. I notice that YANG doctors and I pick up on different things and also that
From: Linda Dunbar
Sent: 27 April 2021 16:49
Tom,
Can you please provide the concrete suggestions to the authors on the changes
you like to see?
Linda
I hope that you are still happy:-)
I thought some more (a bad habit of mine:-) about range and exact values and
wonder why capability