enrique, queued up.
--
Darren Hart
VMware Open Source Technology Center
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http
e argued
to outweigh the risks - or that it would be worth the effort.
Henrique, I'm going to stop there and let you chime in if you feel
differently about any of the above.
--
Darren Hart
VMware Open Source Technology Center
On Tue, Jan 02, 2018 at 04:49:43PM -0800, Joe Perches wrote:
> On Tue, 2018-01-02 at 16:10 -0800, Darren Hart wrote:
> > > > Leave those pr_ messages alone, please,
> []
> > Andy and Henrique raised a few reasons why these patches should not be
> > accepted:
> &g
inkpad driver for this
reason.
So it isn't that we place a low value on coding style guidelines, but
rather we place higher value on not perturbing code we can't fully test
without a demonstrable functional reasons to do so.
Thanks,
--
Darren Hart
VMware Open Source Technology Ce
On Wed, Dec 20, 2017 at 10:23:30PM +0100, Ognjen Galić wrote:
> On 20/12/2017, Darren Hart wrote:
> > On Wed, Dec 20, 2017 at 03:30:18PM +0100, Ognjen Galić wrote:
> >> On 18/12/2017, Rafael J. Wysocki wrote:
> >> > Also, what if someone attempts to ad
fail to load with the following
>
> > [ 149.259127] thinkpad_acpi: Unknown symbol battery_hook_register (err 0)
> > [ 149.259158] thinkpad_acpi: Unknown symbol battery_hook_unregister (err 0)
Will a synchronous request_module() address this concern?
--
Darren Hart
; /sys/devices/platform/thinkpad_acpi/.
> Sysfs device attributes for the sensors and fan are on the
> thinkpad_hwmon device's sysfs attribute space, but you should locate it
> looking for a hwmon device with the name attribute of "thinkpad", or
> -better yet, through lib
saying that in a 00/11 email, I
> forgot that for this series.
OK, no dependencies that I see, but it's a simple mechanical change. Happy for
it to go through Greg's tree.
Reviewed-by: Darren Hart (VMware)
--
Darren Hart
VMware Open Source Technology Center
---
bug on hardware, I will presume the same approach was
taken here. I'm dropping this patch as "changes requested" because at the very
least this needs a commit log which documents the problem manifested and why the
behavioral change is appropriate.
--
Darren Hart
VMware Open Source T
ignore those voices until the voices understand the current
> >>> design :-).
> >>
> >> Sheer user is not interested in design, but in usability.
> >
> > Well, end user is not expected to touch /sys
you like the approach of this patch?
> >
> > It is not related, but if above is truth, then another rewrite (also of
> > those your changes!) is needed. So maybe it would be better to postpone
> > (or
>
> Acked-by: Henrique de Moraes Holschuh
>
Queued to testing, thank you.
--
Darren Hart
Intel Open Source Technology Center
--
Check out the vibrant tech community on one of the world's most
engaging
wo deltas:
1) HKEY_HID is LEN0268
2) MHKV is 0x200
This patch appears to address only #1. Is another patch needed for #2?
(I'm digging myself out of a deep backlog, so if it's here already, I'll find
it, but it might expedite things to point it out to me).
Thanks for the pa
e.
> Values on this handle are either 0x1, laptop mode, or 0x6, tablet mode.
>
> Tested-by: Daniel Martin
> Signed-off-by: Lyude
Our apologies for the delay. Thank you for the updates.
Queued to testing.
--
Darren Hart
Inte
acement of "v2" in the subject [PATCH vX N/M] prefix.
Most all of my feedback here is minor, but there were enough little things that
added up and I'd like to see this resubmitted as a series with those addressed
that applies cleanly - largely to make sure I haven't missed cont
) {
> + /* For X1 Yoga (2016) */
> + tp_features.hotkey_tablet = TP_HOTKEY_TABLET_USES_CMMD;
> + type = "CMMD";
> }
>
> if (!tp_features.hotkey_tablet)
> @@ -3928,6 +3951,12 @@ static bool hotkey_notify_6xxx(const u32 hkey,
> *ignore_a
let" : "laptop");
> - res = add_to_attr_set(hotkey_dev_attributes,
> - &dev_attr_hotkey_tablet_mode.attr);
> - }
> -
> if (!res)
> res = register_attr_set_with_sysfs(
> hotkey_
On Sat, Nov 05, 2016 at 11:45:22AM -0700, Darren Hart wrote:
> On Thu, Oct 27, 2016 at 03:46:44PM -0400, Lyude wrote:
> > For whatever reason, the X1 Yoga doesn't support the normal method of
> > querying for tablet mode. Instead of providing the MHKG method under the
>
tion/SubmittingPatches.
I've queued this to testing as it addresses Henrique's change request. Henrique,
I'll add your Reviewed-by if you send it along, or drop it if you have more
reservations.
Thanks,
ese for pdx86 unless a compelling argument arises for including
them (like - the only subsystem not taking these is pdx86...)
--
Darren Hart
Intel Open Source Technology Center
--
_
On Thu, Jun 09, 2016 at 06:04:52PM -0300, Henrique de Moraes Holschuh wrote:
> On Thu, 09 Jun 2016, Darren Hart wrote:
> > On Thu, Jun 09, 2016 at 01:05:12AM -0400, Marco Trevisan (Treviño) wrote:
> > > 2016-06-08 10:54 GMT-04:00 Lyude :
> > > > From: Dennis Wass
a...@vger.kernel.org so that it can be imported
> there once merged?
It doesn't meet stable kernel rules unfortunately, with 143 lines diff.
Henrique, do you want to weigh in on whether this goes back to stable?
One thing I could do is includ
+ break;
> +
> + case 2:
> + /*
> + * MHKV 0x200 in X1, T460s, X260, T560, X1 Tablet (2016)
> + */
> +
> + /* Paranoia c
testing.
> > There's a few things that need changing, I've outlined them below: (for the
> > future, it's recommended to send patches for the kernel inline in emails to
> > make
> > them easier to review).
If someone would please update the patch with any pendin
e 16:
> bright_maxlvl = 15;
> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> break;
> case 8:
> case 0:
> bright_maxlvl = 7;
> - pr_info("detected a 8-l
ot
> use it as is since thinkpad_acpi caches the return value.
>
> This reverts commit 7714687a2b2d ("thinkpad_acpi: Use
> acpi_video_handles_brightness_key_presses()").
>
Rafael, I presume this would go through your tree?
No objection from me. Henrique?
Acked-by: Darre
supported.
>
> > I've dropped this patch. Please let me know if I should pick it back up.
>
> Please pick it back up.
>
Gah, these two threads landed next to each other in my Inbox and I didn't p
. If there is a way to add an "alias" of
> kbd_backlight that won't drive userspace crazy, we might do that though.
> But it looks quite risky to me...
Henrique, so are you taking back your Ack from 10 minutes prior?
I've dropped this patch. Please let me know if I should pick
On Mon, Jan 04, 2016 at 09:51:23PM +0100, Pali Rohár wrote:
> On Monday 04 January 2016 21:40:20 Darren Hart wrote:
> > On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote:
> > > On Monday 04 January 2016 21:04:25 Darren Hart wrote:
> > > > On Wed, Dec 30,
On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote:
> On Monday 04 January 2016 21:04:25 Darren Hart wrote:
> > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote:
> > > This patch adds support for controlling keyboard backlight via
> > > standar
enrique, I'm holding off a bit more to give you time to respond given the
holiday season.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
--
___
ibm-acpi-devel
ying similarly broken paltforms to the Vostro V131, and
provide users with a temporary solution until the DMI match can be added. Very
practical.
I have no objection to the changes in platform-drivers-x86.
Reviewed-by: Darren Hart
--
Da
,7 +2087,8 @@ bool acpi_video_handles_brightness_key_presses(void)
> have_video_busses = !list_empty(&video_bus_head);
> mutex_unlock(&video_list_lock);
>
> - return have_video_busses;
> +
_keymap_report_entry(dell_wmi_input_dev, key, 1, true);
> @@ -398,7 +397,6 @@ static int __init dell_wmi_init(void)
> }
>
> dmi_walk(find_hk_type, NULL);
> - acpi_video = acpi_vide
On Fri, Nov 06, 2015 at 03:19:43PM +0100, David Herrmann wrote:
> Hi Darren!
>
> On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart wrote:
> > On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote:
> >> On Wed, Oct 21, 2015, at 08:46, David He
) and stop telling people
> > to report it to IBM.
>
> IBM? Those reports go directly to me.
>
> > Signed-off-by: David Herrmann
>
> Acked-by: Henrique de Moraes Holschu
On Sun, Oct 11, 2015 at 09:12:54AM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 10 Oct 2015, Darren Hart wrote:
> > The Lenovo ThinkPad Yogo 12 has a button on the side by the power and volume
> > keys with a padlock icon on it, I presume intended to be used as Screenlock.
&g
instead (as a
hotkey).
Is this a keymap change candidate? If so, How do I map 0x6020 to a scancode?
--
Darren Hart
Intel Open Source Technology Center
--
___
ibm-acpi-devel mailing
On Sat, Oct 10, 2015 at 06:40:34PM -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 10 Oct 2015, Darren Hart wrote:
> > On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote:
> > > From: Darren Hart
> > >
> > > thinkpad_acpi reports "un
From: Darren Hart
thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching
between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is
reported by atkbd serio0 as e058 and e059.
Add TP_HKEY_EV_SCREEN_FLIP to the list of ignored events and silence the
warning
On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote:
> From: Darren Hart
>
> thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching
> between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is
> reported by atkbd serio0 a
me
> > 609186184 824 67926 10956
> > drivers/platform/x86/thinkpad_acpi.o.new
> > 609276184 824 67935 1095f
> > drivers/platform/x86/thinkpad_acpi.o.old
> >
> > Signed-off-by: Joe Perches
>
> Ack
On Wed, Jun 17, 2015 at 11:36:13AM +0200, Rafael J. Wysocki wrote:
> On Wed, Jun 17, 2015 at 5:39 AM, Darren Hart wrote:
> > On Tue, Jun 16, 2015 at 01:22:40AM +0200, Rafael Wysocki wrote:
> >> On Friday, June 12, 2015 01:23:19 PM Hans de Goede wrote:
> >> > Hi All,
ly instead and which is now
> in my linux-next branch.
>
> Can you please rebase the series on top of linux-pm.git/linux-next and resend
> it?
Rafael, do you intent to carry this entire series and submit via linux-pm?
--
Darren Hart
Intel Open Source Technology Center
acpi video "
> +"or gpu drivers");
Please run checkpatch on your patch (don't break quoted strings - it makes it
hard to find them with grep).
> return 1;
>
> if (!brightness_enable) {
> --
> 1.9.1
>
>
--
Darren H
On Wed, Jun 03, 2015 at 07:37:13AM -0300, Henrique de Moraes Holschuh wrote:
> On Wed, Jun 3, 2015, at 00:34, Darren Hart wrote:
> > On Tue, Jun 02, 2015 at 07:09:28AM -0300, Henrique de Moraes Holschuh
> > wrote:
> > > Test results were sent to me privately,
r
pull request.
Reviewed-by: Darren Hart
--
Darren Hart
Intel Open Source Technology Center
--
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.s
de Moraes Holschuh
> > Signed-off-by: Bjørn Mork
> > ---
> > v2: kept the original function names, using the DEVICE_ATTR instead
>
> Acked-by: Henrique de Moraes Holschuh
Thanks for the catch Bjørn, much appreciated. Queued for 4.1 fixes.
--
Darren Hart
Intel Open Sour
hotkey_mask_warn_incomplete_mask(void)
> > ^
> >
> > Signed-off-by: Jean Delvare
> > Cc: Henrique de Moraes Holschuh
> > Cc: Darren Hart
>
> Acked-by: Henrique de Moraes Holschuh
Queued, thank you.
--
Darren Hart
Intel Open Source Technology Center
---
ne yet, so I presume whoever is pushing the move to next
will pick this up as well and keep it all together.
Acked-by: Darren Hart
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/thinkp
cludes
> anything in linux-next) - what you do in your own (logically private)
> development tree is your own business.
Thanks for the guidance Stephen. Unless a more compelling argument comes up,
I'll stick to this goi
tatic int adaptive_keyboard_get_next_mode(int mode)
>
> static bool adaptive_keyboard_hotkey_notify_hotkey(unsigned int scancode)
> {
> - u32 current_mode = 0;
> + int current_mode = 0;
> int new_mode = 0;
> int keycode;
>
>
--
Darren Hart
In
d8557084 ('thinkpad_acpi: Add support for more adaptive kbd
> buttons')
> Signed-off-by: Dan Carpenter
Queued, thanks.
--
Darren Hart
Intel Open Source Technology Center
--
Dive into the World of Para
r
>
Queued, thanks Dan!
--
Darren Hart
Intel Open Source Technology Center
--
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media
On Tue, Mar 03, 2015 at 03:39:54PM -0300, Henrique de Moraes Holschuh wrote:
> On Tue, Mar 3, 2015, at 13:52, Darren Hart wrote:
> > Henrique, I believe I may have overstepped with thinkpad-acpi and dealt
> > with it like the other drivers in platform/drivers/x86, when instea
On Fri, Feb 27, 2015 at 08:16:19AM -0300, Henrique de Moraes Holschuh wrote:
> On Fri, Feb 27, 2015, at 08:05, Henrique de Moraes Holschuh wrote:
> > On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote:
> > > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote:
&
es a
careful code review. No need for both.
I'm queueing these for testing in the pdx86 tree because we've been discussing
that approach. However, I've asked Henrique to let me know how he prefers to
handle this dri
nrique?
Henrique, when you're satisfied, please provide a Reviewed-by for the series.
Thanks,
--
Darren Hart
Intel Open Source Technology Center
--
Dive into the World of Parallel Programming The Go Parallel Website, s
scancode < FIRST_ADAPTIVE_KEY ||
> + scancode > FIRST_ADAPTIVE_KEY +
> + TPACPI_HOTKEY_MAP_LEN -
> + ADAPTIVE_KEY_OFFSET) {
> + pr_info("Unhandled adaptive keyboard key: 0x%x\n",
> +
+ __ATTR(adaptive_kbd_mode, S_IWUSR | S_IRUGO,
> + adaptive_kbd_mode_show, adaptive_kbd_mode_store);
> +
Please use DEVICE_ATTR_RW() macros for new sysfs files.
I'd very much like to see a cleanup of the driver to use these as well.
Henrique, your thoughts / preference?
-
} else {
> - new_mode = adaptive_keyboard_get_next_mode(
> - current_mode);
> - }
> + new_mode = adaptive_keyboard_get_nex
board_prev_mode)) {
> - pr_err("Cannot set adaptive keyboard mode.\n");
> - }
> + if (tp_features.has_adaptive_kbd) {
> + if (!acpi_evalf(hkey_handle,
> + NULL,
> +
return true;
No need to duplicate the logic here, just add TP_HKEY_EV_KEY_FN_ESC to the list
of fallthrough keys (right after TP_HKEY_EV_KEY_FN).
--
Darren Hart
Intel Open Source Technology Center
--
Download BIRT
On Tue, Feb 10, 2015 at 08:45:18AM +0100, Xavier Naveira wrote:
> Pressing Fn+Esc in a Lenovo Thinkpad x240 to lock the Fn keys generates
> an unhandled hkey event
>
> Signed-off-by: Xavier Naveira
Queued, thanks.
--
Darren Hart
Intel Open Source Techn
= 'T' || s[3] == 'N') &&
> - tpacpi_is_fw_digit(s[4]) &&
> - tpacpi_is_fw_digit(s[5]);
> + tpacpi_is_fw_digit(s[2]) &&
> + s[3] == t &&
> + (s[4] == 'T' || s[4] ==
ame is sufficient, no need to preface with
x86:. Always capitalize the first word after the filename:
thinkpad_acpi: Fix sparse warning
Corrected and applied, thanks!
--
Darren Hart
Intel Open Source Technology Center
---
u treat the mute button as just another key of the
>keyboard and let the software deal with it.
>
>It is a shame that manufacturers can't keep standards (de facto or
>actual) on top of not delivering proper Linux modules.
>
>My interest on how Linux kernel and drivers has
On Mon, Feb 09, 2015 at 08:44:26PM +0100, Xavier Naveira wrote:
> On 2015-02-07 05:22, Darren Hart wrote:
> >On Sat, Jan 31, 2015 at 07:52:03PM +0100, Xavier Naveira wrote:
> >>Pressing Fn+Esc in a Lenovo Thinkpad x240 to lock the Fn keys generates
> >>an unhandled hke
) &&
As far as I can tell, the only significant difference here (compared to above)
is an additional leading digit and the subsequent string indices?
Seems to me this could be done fairly easily in the same block with only a minor
adjustment at the beginning and the use of an increment
s renamed to strncasecmp, and strnicmp made into a wrapper
> for the new strncasecmp to avoid breaking existing users.
When was this done? As of this morning I still see them as independent functions
in lib/string.c.
--
Darren Hart
Intel Open Source Te
On Wed, Sep 17, 2014 at 12:01:08AM +0200, Jan van den Berg wrote:
> Fixed 22 similar coding style issues: "ERROR: spaces required around that '?'"
>
> Signed-off-by: Jan van den Berg
Queued, thanks.
--
Darren Hart
Intel
71 matches
Mail list logo
