Re: [ibm-acpi-devel] Second fan on Thinkpad P50

2016-04-20 Thread Matthias Hochsteger
> On Sun, 10 Apr 2016, Matthias Hochsteger wrote: > > Here is the latest version of my patch. I added quirks to recognize the > > second fan and cleaned the code, any comments are welcome: > > http://pastebin.com/eVPcnvfK > > > > > From your patch, I understand the select_fan() thing we already ha

Re: [ibm-acpi-devel] Second fan on Thinkpad P50

2016-04-10 Thread Henrique de Moraes Holschuh
On Sun, 10 Apr 2016, Matthias Hochsteger wrote: > Here is the latest version of my patch. I added quirks to recognize the > second fan and cleaned the code, any comments are welcome: > http://pastebin.com/eVPcnvfK > > > From your patch, I understand the select_fan() thing we already have for the >

Re: [ibm-acpi-devel] Second fan on Thinkpad P50

2016-04-10 Thread Matthias Hochsteger
Here is the latest version of my patch. I added quirks to recognize the second fan and cleaned the code, any comments are welcome: http://pastebin.com/eVPcnvfK > From your patch, I understand the select_fan() thing we already have for the > X60/X61 actually changes which fan is being controlled on

Re: [ibm-acpi-devel] Second fan on Thinkpad P50

2016-04-09 Thread Henrique de Moraes Holschuh
On Sat, 09 Apr 2016, Matthias Hochsteger wrote: > This way I managed to control both fans individually. As I mentioned, > this code is just a hack and what's totally missing is some detection of > the second fan. I would appreciate some help there. Two-fan thinkpads are rare enough that we can use

[ibm-acpi-devel] Second fan on Thinkpad P50

2016-04-09 Thread Matthias Hochsteger
Hi, I discovered that the thinkpad-acpi module does not recognize the second fan on my Thinkpad P50. I discovered some support for a second fan in the source code, so I hard-coded the 'second_fan' bit to 1 an added some functions to expose a second PWM interface. This way I managed to control both