[ibm-acpi-devel] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Roel Kluin
Roland Dreier wrote: > > /* safety net should the EC not support AUTO > > * or FULLSPEED mode bits and just ignore them */ > > if (level & TP_EC_FAN_FULLSPEED) > > level |= 7; /* safety min speed 7 */ > >

Re: [ibm-acpi-devel] [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Roland Dreier
> /* safety net should the EC not support AUTO > * or FULLSPEED mode bits and just ignore them */ > if (level & TP_EC_FAN_FULLSPEED) > level |= 7; /* safety min speed 7 */ > else if (level & TP_EC_FAN_

[ibm-acpi-devel] [drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Roel Kluin
in drivers/misc/thinkpad_acpi.c: 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 */

[ibm-acpi-devel] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'

2008-02-08 Thread Roel kluin
in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads: /* safety net should the EC not support AUTO * or FULLSPEED mode bits and just ignore them */ if (level & TP_EC_FAN_FULLSPEED) level |= 7; /* safety min speed 7 *

Re: [ibm-acpi-devel] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Greg KH
On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote: > Henrique de Moraes Holschuh wrote: > > On Tue, 05 Feb 2008, Roel Kluin wrote: > >> Roland Dreier wrote: > >>> > /* safety net should the EC not support AUTO > >>> > * or FULLSPEED mode bits and just ign

Re: [ibm-acpi-devel] [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Greg KH
On Wed, Feb 06, 2008 at 11:18:50PM -0200, Henrique de Moraes Holschuh wrote: > On Thu, 07 Feb 2008, Roel Kluin wrote: > > It's a oneliner and the patch is from linus' tree. > > Roel, better to just let me and Len Brown handle it. I will add your patch > to my thinkpad-acpi queue and send it to Le

Re: [ibm-acpi-devel] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Roel Kluin
Greg KH wrote: > On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote: >> Henrique de Moraes Holschuh wrote: >>> On Tue, 05 Feb 2008, Roel Kluin wrote: Roland Dreier wrote: > > Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should > > this be replaced by > >>>

Re: [ibm-acpi-devel] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Roel Kluin
Henrique de Moraes Holschuh wrote: > On Tue, 05 Feb 2008, Roel Kluin wrote: >> Roland Dreier wrote: >>> > /* safety net should the EC not support AUTO >>> > * or FULLSPEED mode bits and just ignore them */ >>> > if (level & TP_EC_FAN_FULLSPEED) >>

Re: [ibm-acpi-devel] [stable] [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)

2008-02-08 Thread Greg KH
On Thu, Feb 07, 2008 at 12:48:24AM +0100, Roel Kluin wrote: > Greg KH wrote: > > On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote: > >> Henrique de Moraes Holschuh wrote: > >>> On Tue, 05 Feb 2008, Roel Kluin wrote: > Roland Dreier wrote: > > > > Note the duplicate test 'if (le