[ibm-acpi-devel] [PATCH 4/7] ACPI: thinkpad-acpi: WLSW overrides other rfkill switches

2008-07-01 Thread Henrique de Moraes Holschuh
On ThinkPads where the WLSW switch exists, the firmware or the hardware ANDs the WLSW state with the device-specific switches (WWAN, Bluetooth). It is downright impossible to enable WWAN or Bluetooth when WLSW is blocking the radios. This reality does not necessarily carry over to the WWAN and Blu

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi changes for 2.6.27 merge window

2008-07-01 Thread Henrique de Moraes Holschuh
Andi, Here a patchset with the thinkpad-acpi changes scheduled for 2.6.27. It depends on the rfkill changes in net-next-2.6 (already in linux-next). Usually, I provide a git tree for pulling and also send the patches. Due to the linux-next dependency, this one is going out just as patches. Pl

[ibm-acpi-devel] [PATCH 1/7] ACPI: thinkpad-acpi: minor refactor on radio switch init

2008-07-01 Thread Henrique de Moraes Holschuh
Change the code of hotkey_init, wan_init and bluetooth_init a bit to make it much easier to add some Kconfig-selected debugging code later. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 49 ++--- 1 files cha

[ibm-acpi-devel] [PATCH 2/7] ACPI: thinkpad-acpi: consolidate wlsw notification function

2008-07-01 Thread Henrique de Moraes Holschuh
Rename tpacpi_input_send_radiosw() to tpacpi_send_radiosw_update(), and make it a central point to issue "radio switch changed state" notifications by consolidating also the poll() notification in the same function. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/t

[ibm-acpi-devel] [PATCH 6/7] ACPI: thinkpad-acpi: bump up version to 0.21

2008-07-01 Thread Henrique de Moraes Holschuh
rfkill support deserves a new version checkpoint... Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- Documentation/laptops/thinkpad-acpi.txt |4 ++-- drivers/misc/thinkpad_acpi.c|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentati

[ibm-acpi-devel] [PATCH 5/7] ACPI: thinkpad-acpi: add bluetooth and WWAN rfkill support

2008-07-01 Thread Henrique de Moraes Holschuh
Add a read/write rfkill interface to the bluetooth radio switch on the bluetooth submodule, and one for the wireless wan radio switch to the wan submodule. Since rfkill does care for when a switch changes state, use WLSW notifications to also check if the WWAN or Bluetooth switches did not change

[ibm-acpi-devel] [PATCH 7/7] ACPI: thinkpad-acpi: don't misdetect in get_thinkpad_model_data() on -ENOMEM

2008-07-01 Thread Henrique de Moraes Holschuh
Explicitly check for memory allocation failures, and return status to indicate that we could not collect data due to errors. This lets the driver have a far more predictable failure mode on ENOMEM in that codepath: it will refuse to load. This is far better than trying to proceed with missing dat

[ibm-acpi-devel] [PATCH 3/7] ACPI: thinkpad-acpi: prepare for bluetooth and wwan rfkill support

2008-07-01 Thread Henrique de Moraes Holschuh
Get rid of some forward definitions by moving code around, this will make the rfkill conversion of wwan and bluetooth a bit cleaner. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 154 -- 1 files changed,

Re: [ibm-acpi-devel] [PATCH 1/7] ACPI: thinkpad-acpi: minor refactor on radio switch init

2008-07-01 Thread Andi Kleen
Henrique de Moraes Holschuh wrote: > Change the code of hotkey_init, wan_init and bluetooth_init a bit to make it > much easier to add some Kconfig-selected debugging code later. The later seems to be wrong, the debugging code is already included? Description seems to be incomplete. -Andi -

Re: [ibm-acpi-devel] [PATCH 1/7] ACPI: thinkpad-acpi: minor refactor on radio switch init

2008-07-01 Thread Henrique de Moraes Holschuh
On Tue, 01 Jul 2008, Andi Kleen wrote: > Henrique de Moraes Holschuh wrote: > > Change the code of hotkey_init, wan_init and bluetooth_init a bit to make it > > much easier to add some Kconfig-selected debugging code later. > > The later seems to be wrong, the debugging code is already included?

[ibm-acpi-devel] Typo on patch name

2008-07-01 Thread jieryn
I think there is a small typo in the naming of this patch: http://downloads.sourceforge.net/ibm-acpi/thinkpad-acpi-0.21-20080629_v2.6.28-rc8.patch.gz Thanks for the latest round of updates, Henrique, all! -jesse -- There are 10 types of people in this world, those that can read binary and th

Re: [ibm-acpi-devel] Typo on patch name

2008-07-01 Thread Henrique de Moraes Holschuh
On Tue, 01 Jul 2008, [EMAIL PROTECTED] wrote: > I think there is a small typo in the naming of this patch: > > > http://downloads.sourceforge.net/ibm-acpi/thinkpad-acpi-0.21-20080629_v2.6.28-rc8.patch.gz Oops, indeed :-) will fix. Thanks for the report. -- "One disk to rule them all, One