Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix return value of volume callbacks

2010-02-25 Thread Henrique de Moraes Holschuh
On Tue, 23 Feb 2010, Clemens Ladisch wrote: > Henrique de Moraes Holschuh wrote: > > On Mon, 22 Feb 2010, Clemens Ladisch wrote: > > > Fix up the volume status setting functions to return a non-zero value if > > > the control value has changed, so that the ALSA framework can correctly > > > generat

[ibm-acpi-devel] [PATCH 1/6] thinkpad-acpi: document HKEY event 3006

2010-02-25 Thread Henrique de Moraes Holschuh
Event 0x3006 is used to help power management of the ODD in the UltraBay. The EC generates this event when the ODD eject button is pressed (even if the bay is powered down). Normally, Linux doesn't need this as we keep the SATA link powered up (which wastes power). The EC powers up the bay by it

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi fixes for the merge window and -stable

2010-02-25 Thread Henrique de Moraes Holschuh
Len, This is the current queue of thinkpad-acpi changes for the merge window. They are all fixes or "stop asking users for information we already have" patches, and should also go to 2.6.32 and 2.6.33. Please merge in acpi-test. Thanks! Shortlog: Henrique de Moraes Holschuh (6): thinkpad

[ibm-acpi-devel] [PATCH 3/6] thinkpad-acpi: fix poll thread auto-start

2010-02-25 Thread Henrique de Moraes Holschuh
The driver was not starting the NVRAM polling thread if the input device was bound immediately after registration. This fixes: http://bugzilla.kernel.org/show_bug.cgi?id=15118 Reported-by: Florian Zumbiehl Signed-off-by: Henrique de Moraes Holschuh Cc: sta...@kernel.org --- drivers/platform/x8

[ibm-acpi-devel] [PATCH 2/6] thinkpad-acpi: R52 brightness_mode has been confirmed

2010-02-25 Thread Henrique de Moraes Holschuh
We can stop pestering users for confirmation of the brightness_mode default for firmware TP-76. While at it, add a few missing comments in that quirk table. Reported-by: Whoopie Signed-off-by: Henrique de Moraes Holschuh Cc: sta...@kernel.org --- drivers/platform/x86/thinkpad_acpi.c |6 +++

[ibm-acpi-devel] [PATCH 5/6] thinkpad-acpi: fix bluetooth/wwan resume

2010-02-25 Thread Henrique de Moraes Holschuh
Studying the DSDTs of various thinkpads, it looks like bit 3 of the argument to SBDC and SWAN is not "set radio to last state on resume". Rather, it seems to be "if this bit is set, enable radio on resume, otherwise disable it on resume". So, the proper way to prepare the radios for S3 suspend is:

[ibm-acpi-devel] [PATCH 4/6] thinkpad-acpi: make driver events work in NVRAM poll mode

2010-02-25 Thread Henrique de Moraes Holschuh
Thadeu Lima de Souza Cascardo reports this: Brightness notification does not work until the user writes to hotkey_mask attribute. That's because the polling thread will only run if hotkey_user_mask is set and someone is reading the input device or if hotkey_driver_mask is set. In this second cas

[ibm-acpi-devel] [PATCH 6/6] thinkpad-acpi: lock down video output state access

2010-02-25 Thread Henrique de Moraes Holschuh
Given the right combination of ThinkPad and X.org, just reading the video output control state is enough to hard-crash X.org. Until the day I somehow find out a model or BIOS cut date to not provide this feature to ThinkPads that can do video switching through X RandR, change permissions so that o

Re: [ibm-acpi-devel] T20: display stays dark when booting with closed lid switch

2010-02-25 Thread Florian Zumbiehl
Hi, > On Mon, 22 Feb 2010, Florian Zumbiehl wrote: > > > > Text mode, no framebuffer. > > > > > > Maybe rmmod+modprobe on the acpi drivers (video, button) fixes it? > > > > video.ko would be produced by THINKPAD_ACPI_VIDEO? I didn't compile that, > > given the warnings in the help ;-) > > No, i