Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-05 Thread Andrew Morton
On Tue, 5 Mar 2013 09:34:43 -0800 Mandeep Singh Baines wrote: > Fixes the following lockdep error: > > [ BUG: ktpacpi_nvramd/446 still has locks held! ] > > hotkey_kthread() calls set_freezable() after acquiring the > hotkey_kthread_mutex(). set_freezable() calls try_to_freeze(). > This could

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-05 Thread Henrique de Moraes Holschuh
On Tue, 05 Mar 2013, Mandeep Singh Baines wrote: > This mutex seems wrong. Its held the entire time the kthread is > running. I think its used to synchronize on the exit of the kthread. A > completion would more appropriate in that case. >From the top of the driver source: /* Acquired while the p