Re: [ibm-acpi-devel] [PATCH v5 3/6] leds: triggers: Add support for read-only triggers

2016-11-18 Thread Hans de Goede
Hi, On 18-11-16 09:52, Jacek Anaszewski wrote: > Hi Hans, > > Thanks for the new patch set. > > On 11/17/2016 11:24 PM, Hans de Goede wrote: >> In some cases an LED is controlled through a hardwired (taken care of >> in firmware outside of the kernels control) trigger. >> >> Add an LED_TRIGGER_REA

Re: [ibm-acpi-devel] [PATCH v5 2/6] leds: triggers: Add a keyboard backlight trigger

2016-11-18 Thread Hans de Goede
Hi, On 18-11-16 09:55, Jacek Anaszewski wrote: > Hi Hans, > > Thanks for the patch. > > I think we need less generic trigger name. > With present name we pretend that all kbd-backlight controllers > can change LED brightness autonomously. > > How about kbd-backlight-pollable ? This is a trigger t

Re: [ibm-acpi-devel] [PATCH v5 3/6] leds: triggers: Add support for read-only triggers

2016-11-18 Thread Hans de Goede
Hi, On 18-11-16 11:49, Jacek Anaszewski wrote: > Hi, > > On 11/18/2016 10:04 AM, Hans de Goede wrote: >> Hi, >> >> On 18-11-16 09:52, Jacek Anaszewski wrote: >>> Hi Hans, >>> >>> Thanks for the new patch set. >>> >>> On 11/17/2016 11:24 PM, Hans de Goede wrote: In some cases an LED is control

Re: [ibm-acpi-devel] [PATCH v5 2/6] leds: triggers: Add a keyboard backlight trigger

2016-11-18 Thread Hans de Goede
HI, On 18-11-16 17:03, Jacek Anaszewski wrote: > Hi, > > On 11/18/2016 10:07 AM, Hans de Goede wrote: >> Hi, >> >> On 18-11-16 09:55, Jacek Anaszewski wrote: >>> Hi Hans, >>> >>> Thanks for the patch. >>> >>> I think we need less generic trigger name. >>> With present name we pretend that all kbd-