Re: [ibm-acpi-devel] [PATCH v1 1/2] platform/x86: thinkpad_acpi: Sort headers for better maintenance

2022-06-22 Thread Hans de Goede
Hi, On 6/17/22 00:49, Andy Shevchenko wrote: > It's quite hard to understand in that zillions of headers that are included > if any specific one is already listed. Sort headers for better maintenance. > > Signed-off-by: Andy Shevchenko > --- > drivers/platform/x86/thinkpad_acpi.c | 58 +

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Fix a memory leak of EFCH MMIO resource

2022-06-22 Thread Hans de Goede
Hi, On 6/21/22 15:55, Jean Delvare wrote: > Unlike release_mem_region(), a call to release_resource() does not > free the resource, so it has to be freed explicitly to avoid a memory > leak. > > Signed-off-by: Jean Delvare > Fixes: 455cd867b85b ("platform/x86: thinkpad_acpi: Add a s2idle resume