intended.
Signed-off-by: Andy Shevchenko
---
drivers/platform/x86/thinkpad_acpi.c | 182 +--
1 file changed, 65 insertions(+), 117 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 7740b5e1b998..e6fbb2579dd9
On Tue, 2017-05-09 at 21:24 -0300, Henrique de Moraes Holschuh wrote:
> On Tue, May 9, 2017, at 14:33, Andy Shevchenko wrote:
> > On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh
> > wrote:
> > > > While here, print negative error without changin
On Tue, 2017-05-09 at 14:10 -0300, Henrique de Moraes Holschuh wrote:
Thanks for review, my comments below.
> On Tue, 09 May 2017, Andy Shevchenko wrote:
> > There is no point to keep string literal split. It even makes
> > slightly
> > harder to maintain and debug.
>
&
ned-off-by: Andy Shevchenko
---
drivers/platform/x86/thinkpad_acpi.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 7b6cb0c69b02..7740b5e1b998 100644
--- a/drivers/platform/x86/think
On Tue, 2017-05-09 at 14:02 -0300, Henrique de Moraes Holschuh wrote:
Thanks for review, my comments below.
> On Tue, 09 May 2017, Andy Shevchenko wrote:
> > The commit 4be73005e4dc
> >
> > ("thinkpad-acpi: remove uneeded tp_features.hotkey tests in
> > hotke
://patchwork.ozlabs.org/patch/713245/
Cc: Richard Weinberger
Signed-off-by: Andy Shevchenko
---
drivers/platform/x86/thinkpad_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index e6fbb2579dd9..f5bc888b2ef4 100644
immutable tag / branch.
P.S. Change is good to me, though let's give a chance to Darren and
Henrique to comment.
> Cc: Henrique de Moraes Holschuh
> Cc: Darren Hart
> Cc: Andy Shevchenko
> Cc:
> Cc:
> Signed-off-by: Greg Kroah-Hartman
> ---
>
ode.
I dunno why this one didn't appear in our patchwork database.
I'll go to apply manually soon.
Sorry for the delay.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibran
On Sun, Oct 1, 2017 at 12:31 PM, Andy Shevchenko
wrote:
> On Mon, Sep 18, 2017 at 7:00 PM, Lyude Paul wrote:
>> Reviewed-by: Lyude Paul
>>
>> On Fri, 2017-09-15 at 15:20 +0200, Benjamin Berg wrote:
>>> Many thinkpad laptops and convertibles provide the GMMS met
in_tablet_mode = hotkey_gmms_get_tablet_mode(res,
> +
> &has_tablet_mode);
> + if (has_tablet_mode)
> + tp_features.hotkey_tablet =
> TP_HOTKEY_TABLET_USES_GMMS;
> + type = "GMMS&
_FLAT |
> TP_ACPI_MULTI_MODE_TABLET |
> TP_ACPI_MULTI_MODE_STAND |
> TP_ACPI_MULTI_MODE_TENT;
> break;
--
With Best Regards,
Andy Shevchenko
-
ot understand the ABI of this module.
So, obvious NAK for this patch.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! ht
On Wed, Nov 15, 2017 at 1:14 AM, Simranjit Singh
wrote:
> From: Simranjit Singh
>
> Added parentheses around complex macros following checkpatch.pl for
> thinkpad_acpi.c
Same story.
--
With Best Regards,
And
On Sun, Dec 10, 2017 at 8:01 PM, Ognjen Galic wrote:
> drivers/acpi/battery.h | 11
> include/acpi/battery.h | 21
Just a hint to the future: use -M -C (with perhaps some non-default
thresholds in some cases) to avoid above.
--
With Best Regards,
Andy Shev
(&battery->dev, &battery_start))
> + return -ENODEV;
> +
> + if (device_create_file(&battery->dev, &battery_stop))
> + return -ENODEV;
Shouldn't be done via group attribures?
> +
> + return 0;
> +
LTI_MODE_TENT;
> break;
> default:
> pr_err("Unknown multi mode status type %d with value 0x%04X,
> please report this to %s\n",
>type, value, TPACPI_MAIL);
> return 0;
> --
> 2.13.6
>
tchset for it
> to get merged?
Through which tree it's supposed to go?
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdo
On Mon, Dec 18, 2017 at 7:31 PM, Rafael J. Wysocki wrote:
> On Mon, Dec 18, 2017 at 1:36 PM, Andy Shevchenko
> wrote:
>> On Mon, Dec 18, 2017 at 12:21 PM, Ognjen Galić wrote:
>>> On 16/12/2017, Rafael J. Wysocki wrote:
>>
>>>> I would reorder it as the f
orth at this point.
Sorry, but NAK for both.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech community on one of the world's most
engaging tech sites
лоб расшибёт.
Which has English equivalent: Give a man enough rope and he’ll hang himself.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech community on one of
ws(struct device *parent,
> extern void power_supply_unregister(struct power_supply *psy);
> extern int power_supply_powers(struct power_supply *psy, struct device *dev);
>
> +#define to_power_supply(device) container_of(device, struc
or_each for the module
> exit function where deletion of nodes occurs
Just two workflow / style comments:
- usually we put changelog under --- line;
- when you prepare patch series you may use -v to create a version
automatically.
--
With Best Regards,
Andy Shevchenko
---
On Thu, Dec 21, 2017 at 5:24 PM, Ognjen Galić wrote:
> On 21 Dec 2017 2:53 pm, "Andy Shevchenko" wrote:
> On Thu, Dec 21, 2017 at 12:00 PM, Ognjen Galic wrote:
You need stop using HTML as well.
>> +DEVICE_ATTR(charge_start_threshold, 0644,
>> +
ges in this patch in v10
>
> Signed-off-by: Ognjen Galic
Missed:
Suggested-by: Andy Shevchenko
> ---
> drivers/power/supply/power_supply_core.c | 2 +-
> include/linux/power_supply.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/
On Sat, Dec 30, 2017 at 1:49 AM, Ognjen Galić wrote:
> On Čet, 2017-12-28 at 10:19 +0200, Andy Shevchenko wrote:
>> On Sat, Dec 23, 2017 at 12:53 PM, Ognjen Galic
>> wrote:
>> >
>> > This patch adds the to_power_supply macro to upcast
>> > a device t
On Sun, Dec 31, 2017 at 1:17 PM, Rafael J. Wysocki wrote:
> On Sun, Dec 31, 2017 at 10:37 AM, Andy Shevchenko
> wrote:
>> On Sat, Dec 30, 2017 at 1:49 AM, Ognjen Galić wrote:
>> You definitely need to send a new revision with all comments
>> addressed. So far you didn&
gt; + hook = list_entry(position, struct acpi_battery_hook, list);
Ditto.
> + list_for_each_safe(position, temp, &battery_hook_list) {
> + hook = list_entry(position, struct acpi_battery_hook, list);
Ditto.
> --- a/drivers/acpi/battery.h
> +++
w-level operations via a macro.
The patch 5 must be folded into this one. I told you that.
Otherwise you will leave bisectability issue.
> Suggested-by: Andy Shevchenko
> Signed-off-by: Ognjen Galic
>
> v9:
> * Split the pm changes from the thinkpad_acpi patch
> into its own p
the ds278* battery modules that does the
> same thing, thus clashing and producing build errors.
>
> This patch removes that private implementation.
Must be folded into patch 2.
--
With Best Regards,
Andy Shevchenko
-
y %s, assuming primary", battery_name);
> + return BAT_PRIMARY;
> +}
> +
> +/* sysfs interface */
> +
> +static ssize_t tpacpi_battery_store(int what,
> + s
utex_destroy(&hook_mutex);
> +}
> battery->bat = power_supply_register_no_ws(&battery->device->dev,
> &battery->bat_desc, &psy_cfg);
>
> +
w-level operations via a macro.
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Ognjen Galic
It took me a while to understand if those private implementations are
equivalent to what you introduced.
Looks so sysfs_create_group() adds the attributes to power supply
device kobject, thus t
suggested to use plain
int.
One more question: why don't you use dev_err()/dev_*() macros instead
of pr_*() ones?
(Note, it's a question, needs a bit of discussion, I would like to
hear a rationale of this, I think it might be one)
--
With Best Regards,
Andy Shevchenko
-
rk has been added to also report correctly.
>
> Now the "status" attribute returns "Not Charging" when the
> battery on ThinkPads is not physicaly charging.
>
> Signed-off-by: Ognjen Galic
Reviewed-by: Andy Shevchenko
> ---
>
> Notes:
> v7:
>
On Wed, Jan 3, 2018 at 4:53 PM, Ognjen Galić wrote:
> On Wed, Jan 03, 2018 at 04:25:42PM +0200, Andy Shevchenko wrote:
>> On Wed, Jan 3, 2018 at 1:58 PM, Ognjen Galic wrote:
>> Thanks for an update. I have couple of minors. Otherwise look pretty much
>> good!
>>
&
happened to
> ibm-acpi-devel@lists.sourceforge.net
> thinkpad_acpi: unknown possible thermal alarm or keyboard event received
> thinkpad_acpi: unhandled HKEY event 0x60f0
> thinkpad_acpi: please report the conditions when this event happened to
> ibm-acpi-devel@lists.sourceforge.
send a new version which addresses comments.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://s
),
> TPACPI_FAN_QI('7', '6', TPACPI_FAN_Q1),
> TPACPI_FAN_QI('7', '0', TPACPI_FAN_Q1),
> TPACPI_FAN_QL('7', 'M', TPACPI_FAN_2FAN),
> + TPACPI_FAN_QL_BIOS('N', '1', TPACPI_FAN_2FAN) /
_FAN_Q1),
> TPACPI_FAN_QI('7', '6', TPACPI_FAN_Q1),
> TPACPI_FAN_QI('7', '0', TPACPI_FAN_Q1),
> TPACPI_FAN_QL('7', 'M', TPACPI_FAN_2FAN),
> + TPACPI_FAN_QL_BIOS('N', '1', TPACPI_FAN_
to respin the patches with the tested-by and without the
> untested prefix, or can you take them directly?
Yes, please.
It will make our life easier.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech
received\n");
> - known = false;
> + /* report simply as unknown, no sensor dump */
> + return false;
> }
>
> thermal_dump_all_sensors();
> -
> - return known;
> + r
e nice to have just kstrtobool() called instead for such
options, but see above. It would need a (huge) refactoring of the
driver first.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech
t likely our case)
- by DMI matching (only for old BIOS'es)
- by ACPI ID
So, does the ACPI contain one of the listed IDs?
#define TPACPI_ACPI_IBM_HKEY_HID"IBM0068"
#define TPACPI_ACPI_LENOVO_HKEY_HID "LEN0068&quo
h.
The patches you submitted before had been applied.
Please, rebase your stuff against our for-next branch and resend.
--
With Best Regards,
Andy Shevchenko
--
Check out the vibrant tech community on one of
tion that the quirk is needed, however.
I see. Care to Cc that guy (if they wish, of course, to be Cc:ed)?
> - TPACPI_Q_LNV3('R', '0', 'C', true), /* Thinkpad 13 */
> + TPACPI_Q_LNV3('R', '0', 'C', true), /* 13 */
P
t tpacpi_battery_init(struct ibm_init_struct *ibm)
> {
> + memset(&battery_info, 0, sizeof(battery_info));
> +
> tp_features.battery_force_primary = tpacpi_check_quirks(
> battery_quirk_table,
>
/* Thinkpad 11e */
> + TPACPI_Q_LNV3('R', '0', 'B', true), /* Thinkpad 11e gen 3 */
> TPACPI_Q_LNV3('R', '0', 'C', true), /* Thinkpad 13 */
init hotkey_init(struct ibm_init_struct
> *iibm)
> KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN,
> KEY_UNKNOWN,
> -KEY_FAVORITES, /* Favorite app, 0x311 */
> +KEY_BOOKMARKS, /* Favorite app, 0x311 */
> KEY_RESERVED,/* Clipping tool */
> KE
Ah, last but not least, you forgot to include subsystem/driver
maintainers in the Cc list (in my mailbox it's even got directly to a
spam).
On Mon, Oct 29, 2018 at 4:05 PM Andy Shevchenko
wrote:
>
> On Sat, Oct 27, 2018 at 9:15 PM Milan Hauth wrote:
>
> Thank you for the
new stuff will be used by HD-audio codec driver and some platform
> drivers (thinkpad_acpi and dell-laptop, also upcoming huawei-wmi).
> +#include
> +#include
Only on of above is needed, I think you meant module.h.
--
With Best Regards,
Andy Shevchenko
_
while (--i >= 0)
Needs { } due to two liner below.
Might be converted to simple
while (i--) {
...
}
btw.
> + if (led_tables[i].state >= 0)
> +
> led_classdev_unregister(&am
have some piece of changes for huawei-wmi, so
> please ping me if needed.
>
> I checked briefly on my Dell laptop, and a Thinkpad model.
> Wider tests are appreciated, of course.
>
Few minor comments, otherwise I like this series.
Acked-by: Andy Shevchenko
for PDx86 bits.
>
>
te whole system.
>
> OK, I'll wait for more comments in today and update accordingly.
sys sounds plausible to me. In any case we may revisit in the future
if something happens to it. OTOH it would be part of ABI, right?
--
With Best Regards,
Andy Shevchenko
__
1.1.2.4.3) + '::' + name ?
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
gt; Signed-off-by: Milan Hauth
> >
> > I am not confortable signing-off on this one.
...I'm not familiar with this interface and I rely on Henrique's
opinion, so, I can't take it.
Sorry.
--
With Best Regards,
Andy Shevchenko
___
ACPI_FAN_QB('N', '1', TPACPI_FAN_2FAN),
> + TPACPI_QEC_IBM('1', 'Y', TPACPI_FAN_Q1),
> + TPACPI_QEC_IBM('7', '8', TPACPI_FAN_Q1),
> + TPACPI_QEC_IBM('7', &
On Tue, Dec 4, 2018 at 1:20 PM Henrique de Moraes Holschuh
wrote:
>
> On Mon, 03 Dec 2018, Andy Shevchenko wrote:
> > On Fri, Nov 16, 2018 at 3:18 PM Jouke Witteveen
> > wrote:
> >
> > Please, submit a new version with changelog.
> >
> > Though, before
7;, TPACPI_FAN_Q1),
> + TPACPI_QEC_IBM('7', '6', TPACPI_FAN_Q1),
> + TPACPI_QEC_IBM('7', '0', TPACPI_FAN_Q1),
> + TPACPI_QEC_LNV('7', 'M', TPACPI_FAN_2FAN),
> + TPACPI_Q_LNV('N', '1', TPACPI_FAN_2FAN),
> };
>
> -#undef TPACPI_FAN_QL
> -#undef TPACPI_FAN_QI
> -#undef TPACPI_FAN_QB
> -
> static int __init fan_init(struct ibm_init_struct *iibm)
> {
> int rc;
> --
> 2.19.2
>
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
/* bluetooth not supported on 570, 600e/x, 770e, 770x, A21e, A2xm/p,
G4x, R30, R31, R40e, R50e, T20-22, X20-21 */
tp_features.bluetooth = hkey_handle &&
acpi_evalf(hkey_handle, &status, "GBDC", "qd");
Is it possible to integrate your
>> Probe these models by DMI match and disable bluetooth subdriver
> >> if specified Intel wireless card exist.
> Thanks for remind.
>
> Should I resend this patch in correct way?
It still needs a bit of work, and as I told you, we are now
BM('7', '0', TPACPI_FAN_Q1),
> TPACPI_QEC_LNV('7', 'M', TPACPI_FAN_2FAN),
> - TPACPI_Q_LNV('N', '1', TPACPI_FAN_2FAN),
> + TPACPI_Q_LNV3('N', '1', 'E', TPACPI_FAN_2FAN),
> };
>
> static int _
V('7', 'M', TPACPI_FAN_2FAN),
> - TPACPI_Q_LNV('N', '1', TPACPI_FAN_2FAN),
> + TPACPI_Q_LNV3('N', '1', 'E', TPACPI_FAN_2FAN),
> };
>
> static int __init fan_init(struct ibm_init_struct *iibm)
>
gt; > am I screwed with this machine and have to wait for Lenovo to patch this?
> > You see this really bugs me :-) and I'm looking forward to your council.
> >
> > Greetings,
> > Sebastian Dörner
> >
>
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
e_fw_id(ec_fw_string,
> +&tp->ec_model, &tp->ec_release);
> + if (t != 'H') {
> + pr_notice("ThinkPad firmware release %s doesn't match
> the known patterns\n",
> + ec_fw_string);
=auto, 1=volume and mute,
> > 2=mute only");
> >
> > module_param_named(volume_control, volume_control_allowed, bool, 0444);
> > MODULE_PARM_DESC(volume_control,
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
to enable
> >>> -Wimplicit-fallthrough.
> >>>
> >>> Signed-off-by: Gustavo A. R. Silva
> >>
> >> Reviewed-by: Kees Cook
> >
> > Acked-by: Henrique de Moraes Holschuh
> >
>
> Thank you both, Kees and Henrique.
if (!rc)
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures)
> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
hwork.kernel.org/project/platform-driver-x86/list/
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
******
>
> *
> @@ -10210,6 +10314,10 @@ static struct ibm_init_struct ibms_init[] __initdata
> = {
> .init = tpacpi_battery_init,
> .data = &battery_driver_data,
> },
> + {
> + .init = tpacpi_lcdshadow_init,
> + .data = &lcdshadow_driver_data,
> + },
> };
>
> static int __init set_ibm_param(const char *val, const struct kernel_param
> *kp)
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
acpi_keymaps[keymap_id],
> + TPACPI_HOTKEY_MAP_SIZE, GFP_KERNEL);
> + if (!hotkey_keycode_map) {
> + pr_err("failed to allocate memory for key map\n");
> + res = -ENOMEM;
&g
EY_MAP_SIZE, GFP_KERNEL);
> + if (!hotkey_keycode_map) {
> + pr_err("failed to allocate memory for key map\n");
> + res = -ENOMEM;
> + goto err_exit;
> + }
>
> input_set_capability(tpacpi_inputdev, EV_MSC, MSC_SCAN);
>
;
> +
> + return lcdshadow_set(state);
> +}
> +
> +static struct ibm_struct lcdshadow_driver_data = {
> + .name = "lcdshadow",
> + .resume = lcdshadow_resume,
> + .read = lcdshadow_read,
> + .write = lcdshadow_write,
> +};
> +
&g
; +
> + return lcdshadow_set(state);
> +}
> +
> +static struct ibm_struct lcdshadow_driver_data = {
> + .name = "lcdshadow",
> + .resume = lcdshadow_resume,
> + .read = lcdshadow_read,
> + .write = lcdshadow_write,
> +};
> +
> /*
API to this kind of devices
somewhere in GPU mailing lists.
This interface is custom and probably shall never have been appeared.
However no-one prevented this from happening.
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
ay to cover other
possible users.
I Cc this to people from that discussion.
[1]:
https://lore.kernel.org/dri-devel/cal_quvrknssvvxn3q_se0hrziw2otns3ennoehyhvcicrq9...@mail.gmail.com/
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel maili
an_init(struct ibm_init_struct *iibm)
> @@ -8813,8 +8835,7 @@ static int __init fan_init(struct ibm_init_struct *iibm)
> fan_quirk1_setup();
> if (quirks & TPACPI_FAN_2FAN) {
> tp_features.second_fan = 1;
> -dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_FAN,
> -"secondary fan support enabled\n");
> +pr_info("secondary fan support enabled\n");
> }
> } else {
> pr_err("ThinkPad ACPI EC access misbehaving, fan status and
> control unavailable\n");
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
ixed them, no need to resend) with
this. Commit message lines are too long and...
> (In the first version my mail client botched the white-spacing - my
> apologies, this is my first Kernel patch. Used git send-email and gmail this
> time.)
...this kind of comments should go after cut li
8812,8 +8834,7 @@ static int __init fan_init(struct ibm_init_struct *iibm)
> fan_quirk1_setup();
> if (quirks & TPACPI_FAN_2FAN) {
> tp_features.second_fan = 1;
> - dbg_printk(TPACPI_DBG_
+ TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL), /* X1 Extreme (1st
> gen) */
> + TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL), /* X1 Extreme (2nd
> gen) */
This has been expanded, but commit message still old, p
fan_init(struct ibm_init_struct
> *iibm)
> fan_quirk1_setup();
> if (quirks & TPACPI_FAN_2FAN) {
> tp_features.second_fan = 1;
> - dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_FAN,
&
rs your real name here? [1]
[1]:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
ars
>
> On Friday, April 24, 2020, 4:12:05 AM PDT, Andy Shevchenko
> wrote:
>
>
>
>
>
> On Fri, Apr 24, 2020 at 12:57 AM Lars wrote:
> >
> > This adds dual fan control for the following models:
> > P50, P51, P52, P70, P71, P72, P1 gen1, X1E gen1, P
, so doesn't the patch.
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
ns): 0Snoop(ns): 0
> CURRENT_PLATFORMLTR: RAW: 0x40201
> Non-Snoop(ns): 0Snoop(ns): 0
> AGGREGATED_SYSTEM LTR: RAW: 0x904824
> Non-Snoop(ns): 0
by reading the associated files in
> the power folder.
>
> If this doesn't work, then it's possible that your device doesn't
> support runtime pm. This may be purposely for reliability reasons or
> the driver may just lack support. Check forums discussing issue
tc_attr_group);
> +
> + return res;
return ...(...);
So, we create a group for all possible error cases but ENODEV. Why?
> +}
...
> + sysfs_remove_group(&tpacpi_pdev->dev.kobj,
> + &dytc_attr_group);
One line?
...
> +static struct
ot;thinkpad_acpi native brightness control enabled\n");
'notice' level is quite high, why do we spam users with this?
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.s
On Thu, Jul 2, 2020 at 1:45 PM Mark Pearson wrote:
> On 7/2/2020 5:29 AM, Andy Shevchenko wrote:
> > On Mon, Jun 29, 2020 at 10:23 PM Mark Pearson
> > wrote:
...
> > You specifically added a new ABI, where is documentation? It's a show
> > stopper.
> Ah -
On Thu, Jul 2, 2020 at 1:51 PM Aaron Ma wrote:
> On 7/2/20 5:30 PM, Andy Shevchenko wrote:
> > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote:
> >>
> >> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
> >>
> >> brightne
viewed-by: Sugumaran
> Reviewed-by: Bastien Nocera
> Signed-off-by: Mark Pearson
> ---
> Changes in v5:
> - Updated with review changes from Andy Shevchenko
> - Added ABI information to thinkpad-acpi.rst
> - improved error handling and parameter passing as recommended
>
d_acpi native brightness control enabled\n");
In both cases don't you see the duplication of module name in the messages?
--
With Best Regards,
Andy Shevchenko
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
On Fri, Jul 10, 2020 at 11:00 AM Hans de Goede wrote:
>
> Hi,
>
> On 7/9/20 8:02 PM, Andy Shevchenko wrote:
> > On Fri, Jul 3, 2020 at 4:24 AM Mark Pearson wrote:
> >>
> >> Newer Lenovo Thinkpad platforms have support to identify whether the
> >> sys
interface not available\n");
> + return 1;
> }
>
> + pr_notice("ACPI native brightness control enabled\n");
> +
> /*
> * Check for module parameter bogosity, note that we
> * init brightness_mode to TPACPI_BRGHT_
gt; ---
> Changes in v5:
> - Updated with review changes from Andy Shevchenko
> - Added ABI information to thinkpad-acpi.rst
> - improved error handling and parameter passing as recommended
> - code cleanup as recommended
> - added review tag from bnocera
> Changes i
rts the change to use strndup_user() fixing the
> buffer being passed to the ibm_struct.write() call back containing extra
> junk at the end.
Can we simply use memdup_user()?
And thanks for catching this up!
--
With Best Regards,
Andy Shevchenko
_
On Tue, Jul 14, 2020 at 11:21 AM Andy Shevchenko
wrote:
> On Tue, Jul 14, 2020 at 11:15 AM Hans de Goede wrote:
> >
> > Commit 35d13c7a0512 ("platform/x86: thinkpad_acpi: Use strndup_user()
> > in dispatch_proc_write()") cleaned up dispatch_proc_write() by rep
d13c7a0512 ("platform/x86: thinkpad_acpi: Use strndup_user() in
dispatch_proc_write()")
Reported-by: Hans de Goede
Signed-off-by: Andy Shevchenko
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkp
On Tue, Jul 14, 2020 at 12:33 PM Hans de Goede wrote:
> On 7/14/20 10:27 AM, Andy Shevchenko wrote:
> > On Tue, Jul 14, 2020 at 11:21 AM Andy Shevchenko
> > wrote:
> >> On Tue, Jul 14, 2020 at 11:15 AM Hans de Goede wrote:
> >>>
> >>> Commit
On Tue, Jul 14, 2020 at 4:30 PM Hans de Goede wrote:
> On 7/14/20 12:42 PM, Andy Shevchenko wrote:
...
> > + kernbuf = strndup_user(userbuf, min_t(long, count, PAGE_SIZE));
> This is not going to work:
You are right!
> Can we please just go with the revert for now?
Yes,
es by the input
> >>> maintainers:
> >>>
> >>> Acked-by: Henrique de Moraes Holschuh
> >>
> >> Do you want me to merge all 3 through input tree?
> >
> > Hans, Daren, Andy, what do you prefer?
>
&
1 - 100 of 145 matches
Mail list logo
