[ibm-acpi-devel] [PATCH] ACPI / battery: safe unregistering of hooks

2018-06-23 Thread Jouke Witteveen
As unregistering a hook takes it off the hook list, we should use a safe for_each loop when we potentially unregister a hook. Signed-off-by: Jouke Witteveen --- drivers/acpi/battery.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers

Re: [ibm-acpi-devel] [PATCH] ACPI / battery: safe unregistering of hooks

2018-07-04 Thread Jouke Witteveen
On Sat, Jun 23, 2018 at 11:08:51AM +0200, Jouke Witteveen wrote: > As unregistering a hook takes it off the hook list, we should use a safe > for_each loop when we potentially unregister a hook. > > Signed-off-by: Jouke Witteveen > --- I would like to draw attention to this pa

[ibm-acpi-devel] [PATCH v2] ACPI / battery: Safe unregistering of hooks

2018-07-04 Thread Jouke Witteveen
laptops could no longer boot. Additionally, a lock was kept in place and debugging information was printed out of order. Signed-off-by: Jouke Witteveen --- This time with a more informative commit message (no functional changes). drivers/acpi/battery.c | 9 + 1 file changed, 5 insertions

[ibm-acpi-devel] [PATCH 1/2] platform/x86: thinkpad_acpi: Proper model/release matching

2018-07-11 Thread Jouke Witteveen
Modern Thinkpads have three character model designators. Previously, they would be accepted, but recorded incompletely. Revision matching extracted the wrong bytes from the ID string. This made the use of quirks for modern machines impossible. Fixes: 1b0eb5bc2413 Signed-off-by: Jouke Witteveen

[ibm-acpi-devel] [PATCH 2/2] platform/x86: thinkpad_acpi: Support battery quirk

2018-07-11 Thread Jouke Witteveen
Some Thinkpads have a single battery, but expose it as BAT1. Use the quirks engine to force these machines into always addressing the primary battery. Without this, the battery name would resolve to the non-existent secondary battery and ACPI calls would fail. Signed-off-by: Jouke Witteveen

Re: [ibm-acpi-devel] [PATCH 1/2] platform/x86: thinkpad_acpi: Proper model/release matching

2018-07-11 Thread Jouke Witteveen
On Wed, Jul 11, 2018 at 2:06 PM Henrique de Moraes Holschuh wrote: > > On Wed, 11 Jul 2018, Jouke Witteveen wrote: > > Modern Thinkpads have three character model designators. Previously, they > > would be accepted, but recorded incompletely. Revision matching extracted > &

[ibm-acpi-devel] [PATCH v2 1/2] platform/x86: thinkpad_acpi: Proper model/release matching

2018-08-01 Thread Jouke Witteveen
Modern Thinkpads have three character model designators. Previously, they would be accepted, but recorded incompletely. Revision matching extracted the wrong bytes from the ID string. This made the use of quirks for modern machines impossible. Fixes: 1b0eb5bc2413 Signed-off-by: Jouke Witteveen

[ibm-acpi-devel] [PATCH v2 2/2] platform/x86: thinkpad_acpi: Support battery quirk

2018-08-01 Thread Jouke Witteveen
Some Thinkpads have a single battery, but expose it as BAT1. Use the quirks engine to force these machines into always addressing the primary battery. Without this, the battery name would resolve to the non-existent secondary battery and ACPI calls would fail. Signed-off-by: Jouke Witteveen

[ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Extend battery quirk coverage

2018-08-01 Thread Jouke Witteveen
Based on bug reports and a web search for "Thinkpad_acpi: Error probing battery 2" four more models were found that require the battery quirk: Lenovo B5400, Thinkpad 11e (original and gen 3), Thinkpad 13 gen 3. Signed-off-by: Jouke Witteveen --- I could only get someone to veri

[ibm-acpi-devel] [PATCH v2] platform/x86: thinkpad_acpi: extend battery quirk coverage

2018-08-02 Thread Jouke Witteveen
Based on bug reports and a web search for "Thinkpad_acpi: Error probing battery 2" four more models were found that require the battery quirk: Lenovo B5400, Thinkpad 11e, Thinkpad 11e gen 3, Thinkpad 13 gen 3. Signed-off-by: Jouke Witteveen Tested-by: James Cheshire Acked-by: H

Re: [ibm-acpi-devel] 2nd Fan quirk for Thinkpad P50 causes spurios touchpad/trackpoint events on ThinkPad L570

2018-10-23 Thread Jouke Witteveen
On Tue, Oct 23, 2018 at 6:06 AM Henrique de Moraes Holschuh wrote: > > On Mon, 15 Oct 2018, Dmitry Torokhov wrote: > > On Sat, Oct 13, 2018 at 6:32 AM Jaak Ristioja wrote: > > > On 27.08.2018 19:22, Jaak Ristioja wrote: > > > > Upgrading Linux from 4.16 to 4.17, a ThinkPad L570 started receiving

[ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Cleanup quirks macros

2018-11-16 Thread Jouke Witteveen
Signed-off-by: Jouke Witteveen --- The only difference in the generated code is that the quirk values are now within parentheses. drivers/platform/x86/thinkpad_acpi.c | 45 1 file changed, 13 insertions(+), 32 deletions(-) diff --git a/drivers/platform/x86

[ibm-acpi-devel] [PATCH v2] platform/x86: thinkpad_acpi: Cleanup quirks macros

2018-12-05 Thread Jouke Witteveen
- Use generic quirks macros for fan quirks The fan-specific quirks macros were duplicates of the generic ones. - Remove useless #undef lines The referenced macros are not defined anywhere. Signed-off-by: Jouke Witteveen Acked-by: Henrique de Moraes Holschuh --- This time, with a more detailed