Re: [ibm-acpi-devel] suspend/hibernation regression between 2.6.19 and 2.6.20 w/ Thinkpad T41

On Monday, 6 August 2007 16:36, Henrique de Moraes Holschuh wrote: On Mon, 06 Aug 2007, Toralf Förster wrote: Am Montag, 6. August 2007 00:29 schrieb Pavel Machek: Yes, I seen similar reports. Does it happen in all shutdown mode and 2.6.22? Does it happen in platform mode in 2.6.19?

Re: [ibm-acpi-devel] suspend/hibernation regression between 2.6.19 and 2.6.20 w/ Thinkpad T41

On Tuesday, 7 August 2007 15:21, Toralf Förster wrote: Am Dienstag, 7. August 2007 02:21 schrieb Henrique de Moraes Holschuh: On Mon, 06 Aug 2007, Toralf Förster wrote: Because I (1) use the latest BIOS and (2) I'm able to wake up a suspended system via Fn under Windows XP (yes,

Re: [ibm-acpi-devel] [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex

On Tuesday, March 26, 2013 02:09:19 PM Oleg Nesterov wrote: On 03/26, Rafael J. Wysocki wrote: On Thursday, March 07, 2013 06:53:59 PM Oleg Nesterov wrote: hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. We can simply kill this mutex, hotkey_poll_stop_sync() does

Re: [ibm-acpi-devel] [PATCH 4/4] Revert "thinkpad_acpi: Use acpi_video_handles_brightness_key_presses()"

ness_capabilities() must have > > * been called before this point */ > > - if (acpi_video_handles_brightness_key_presses()) { > > + if (acpi_video_get_backlight_type() != acpi_backlight_vendor) { > > pr_info("This ThinkPad has standard ACPI backlight

Re: [ibm-acpi-devel] ibm-acpi developers not responding despite serious bugs and debuggers

Hi, On Saturday, January 30, 2016 01:22:27 PM jono wrote: > Dear Rafael, > Sorry to trouble you, but a number of us are having lots of grief > getting a response from ibm/lenovo regarding acpi bugs in newer models > like the Helix 2. The bugs make these machines difficult to use, and > there are

Re: [ibm-acpi-devel] 6ea8c546f3655 breaks thermal management on thinkpad x60 and t40p

On Mon, Nov 14, 2016 at 8:03 PM, Pavel Machek wrote: > Hi! > > Bisection was not fun, but I've got the result: > > # first bad commit: [6ea8c546f3655a81f82672f24b66dad6095bdd07] ACPICA: > FADT support cleanup Bob? > I've reverted the patch on top of 4.9-rc4, and thermal management

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

On Fri, Dec 15, 2017 at 5:57 PM, Ognjen Galic wrote: > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > of "Unknown" when the battery is between the charge start and > charge stop thresholds. On Windows, it reports "Not Charging" > so the quirk has been added

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

On Sat, Dec 16, 2017 at 1:33 AM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Fri, Dec 15, 2017 at 5:57 PM, Ognjen Galic <smclt...@gmail.com> wrote: >> The EC/ACPI firmware on Lenovo ThinkPads used to report a status >> of "Unknown" when the battery is b

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

On Sat, Dec 16, 2017 at 9:48 AM, Ognjen Galic <smclt...@gmail.com> wrote: > On Sat, Dec 16, 2017 at 01:33:55AM +0100, Rafael J. Wysocki wrote: >> On Fri, Dec 15, 2017 at 5:57 PM, Ognjen Galic <smclt...@gmail.com> wrote: >> > The EC/ACPI firmware on Lenovo Thi

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

On Mon, Dec 18, 2017 at 11:21 AM, Ognjen Galić <smclt...@gmail.com> wrote: > On 16/12/2017, Rafael J. Wysocki <raf...@kernel.org> wrote: >> On Sat, Dec 16, 2017 at 9:48 AM, Ognjen Galic <smclt...@gmail.com> wrote: >>> On Sat, Dec 16, 2017 at 01:33:55AM +0100,

Re: [ibm-acpi-devel] [PATCH 1/3 v6] battery: Add the battery hooking API

On Fri, Dec 15, 2017 at 5:56 PM, Ognjen Galic wrote: > This is a patch that implements a generic hooking API for the > generic ACPI battery driver. > > With this new generic API, drivers can expose platform specific > behaviour via sysfs attributes in

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

On Mon, Dec 18, 2017 at 1:36 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Mon, Dec 18, 2017 at 12:21 PM, Ognjen Galić <smclt...@gmail.com> wrote: >> On 16/12/2017, Rafael J. Wysocki <raf...@kernel.org> wrote: > >>> I would reorder it as the f

Re: [ibm-acpi-devel] [PATCH v10 1/4] battery: Add the battery hooking API

On Sat, Dec 23, 2017 at 11:52 AM, Ognjen Galic wrote: > This is a patch that implements a generic hooking API for the > generic ACPI battery driver. > > With this new generic API, drivers can expose platform specific > behaviour via sysfs attributes in

Re: [ibm-acpi-devel] [PATCH v13 3/4] thinkpad_acpi: Add support for battery thresholds

On Fri, Feb 9, 2018 at 11:39 AM, Sebastian Reichel <s...@kernel.org> wrote: > Hi, > > On Fri, Feb 09, 2018 at 10:22:54AM +0100, Rafael J. Wysocki wrote: >> On Thu, Feb 8, 2018 at 11:03 PM, Sebastian Reichel <s...@kernel.org> wrote: >> > Hi, >> >

Re: [ibm-acpi-devel] [PATCH v13 3/4] thinkpad_acpi: Add support for battery thresholds

On Thu, Feb 8, 2018 at 11:03 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Feb 07, 2018 at 03:58:44PM +0100, Ognjen Galic wrote: >> 1) Charge start threshold >> /sys/class/power_supply/BATN/charge_start_threshold >> >> Valid values are [0, 99]. A value of 0 turns off the >>

Re: [ibm-acpi-devel] [PATCH v12 1/4] battery: Add the battery hooking API

On Wednesday, January 3, 2018 12:58:47 PM CET Ognjen Galic wrote: > This is a patch that implements a generic hooking API for the > generic ACPI battery driver. > > With this new generic API, drivers can expose platform specific > behaviour via sysfs attributes in /sys/class/power_supply/BATn/ >

Re: [ibm-acpi-devel] [PATCH v13 1/4] battery: Add the battery hooking API

On Wed, Feb 7, 2018 at 3:58 PM, Ognjen Galic wrote: > This is a patch that implements a generic hooking API for the > generic ACPI battery driver. > > With this new generic API, drivers can expose platform specific > behaviour via sysfs attributes in

Re: [ibm-acpi-devel] [PATCH v12 1/4] battery: Add the battery hooking API

On Sun, Feb 4, 2018 at 10:11 AM, Ognjen Galić <smclt...@gmail.com> wrote: > On Sun, Feb 04, 2018 at 09:52:33AM +0100, Rafael J. Wysocki wrote: >> On Wednesday, January 3, 2018 12:58:47 PM CET Ognjen Galic wrote: >> > This is a patch that implements a generic hooking API f

Re: [ibm-acpi-devel] [PATCH v13 3/4] thinkpad_acpi: Add support for battery thresholds

On Wed, Feb 7, 2018 at 3:58 PM, Ognjen Galic wrote: > 1) Charge start threshold > /sys/class/power_supply/BATN/charge_start_threshold > > Valid values are [0, 99]. A value of 0 turns off the > start threshold wear control. > > 2) Charge stop threshold >

Re: [ibm-acpi-devel] [PATCH v13 3/4] thinkpad_acpi: Add support for battery thresholds

On Fri, Feb 23, 2018 at 6:21 PM, Andy Shevchenko wrote: > On Sat, Feb 10, 2018 at 10:48 AM, Ognjen Galić wrote: > >> Do you guys want me to send in another revision of the patch with some >> documentation on the sysfs API? > > I noticed I didn't

Re: [ibm-acpi-devel] [PATCH v11 3/5] thinkpad_acpi: Add support for battery thresholds

On Wednesday, January 3, 2018 11:34:55 AM CET Ognjen Galić wrote: > On Mon, Jan 01, 2018 at 12:24:39PM +0200, Andy Shevchenko wrote: > > On Sun, Dec 31, 2017 at 4:17 PM, Ognjen Galic wrote: > > > thinkpad_acpi registers two new attributes for each battery: > > > > > > 1)

Re: [ibm-acpi-devel] [PATCH v11 3/5] thinkpad_acpi: Add support for battery thresholds

On Mon, Jan 1, 2018 at 12:43 PM, Ognjen Galić wrote: > On Mon, Jan 01, 2018 at 12:24:39PM +0200, Andy Shevchenko wrote: >> On Sun, Dec 31, 2017 at 4:17 PM, Ognjen Galic wrote: >> > thinkpad_acpi registers two new attributes for each battery: >> > >> > 1)

Re: [ibm-acpi-devel] [PATCH v13 3/4] thinkpad_acpi: Add support for battery thresholds

On Sat, Feb 24, 2018 at 6:32 PM, Ognjen Galić <smclt...@gmail.com> wrote: > On Sat, Feb 24, 2018 at 10:07:20AM +0100, Rafael J. Wysocki wrote: >> On Fri, Feb 23, 2018 at 6:21 PM, Andy Shevchenko >> <andy.shevche...@gmail.com> wrote: >> > On Sat, Feb 10, 2

Re: [ibm-acpi-devel] [PATCH v2] ACPI / battery: Safe unregistering of hooks

On Wednesday, July 4, 2018 12:27:15 PM CEST Jouke Witteveen wrote: > A hooking API was implemented for 4.17 in fa93854f7a7ed63d followed by > hooks for Thinkpad laptops in 2801b9683f740012. The Thinkpad drivers > did not support the Thinkpad 13 and the hooking API crashes on > unsupported

Re: [ibm-acpi-devel] [PATCH] ACPI / battery: safe unregistering of hooks

On Wed, Jul 4, 2018 at 11:29 AM, Jouke Witteveen wrote: > On Sat, Jun 23, 2018 at 11:08:51AM +0200, Jouke Witteveen wrote: >> As unregistering a hook takes it off the hook list, we should use a safe >> for_each loop when we potentially unregister a hook. >> >> Signed-off-by: Jouke Witteveen >>

Re: [ibm-acpi-devel] Low Latency Tolerance preventing Intel Package from entering deep sleep states

On Friday, May 15, 2020 11:41:16 PM CEST Andy Shevchenko wrote: > +Cc: ACPI ML and Rafael +Cc: David Box > On Fri, May 15, 2020 at 8:36 PM la...@apache.org wrote: > > > > Hi. I hope this is the right forum to raise this... > > > > For a while I have noticed that my CPU (i9-9880H in a Lenovo X1

Re: [ibm-acpi-devel] [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz wrote: > > Inspecting input device's 'users' member should be done under device's > mutex, so add appropriate invocations. > > Signed-off-by: Andrzej Pietrasiewicz This looks like a fix that might be applied independently of the other patches

Re: [ibm-acpi-devel] [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

On Thu, Jun 25, 2020 at 7:23 AM Dmitry Torokhov wrote: > > On Wed, Jun 24, 2020 at 05:00:09PM +0200, Rafael J. Wysocki wrote: > > On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz > > wrote: > > > > > > Inspecting input device's 'users' member should be don

Re: [ibm-acpi-devel] [PATCH v4 0/7] Support inhibiting input devices

On Wed, Jun 10, 2020 at 3:21 PM Hans de Goede wrote: > > Hi, > > On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote: > > Hi All, > > [cut] > > What would it mean to become a wakeup source if there are no users, > > or nobody has ever opened the device? There are no interested > > input handlers

Re: [ibm-acpi-devel] [PATCH v4 0/7] Support inhibiting input devices

On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: > > Hi All, > > On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: > > This is a quick respin of v3, with just two small changes, please see > > the changelog below. > > > > Userspace might want to implement a policy to temporarily disregard

Re: [ibm-acpi-devel] [PATCH] ACPI: battery: Add the ThinkPad "Not Charging" quirk

On Thu, Dec 23, 2021 at 5:36 PM Hans de Goede wrote: > > Hi Thomas, > > On 12/22/21 22:20, Thomas Weißschuh wrote: > > The EC/ACPI firmware on Lenovo ThinkPads used to report a status > > of "Unknown" when the battery is between the charge start and > > charge stop thresholds. On Windows, it

Re: [ibm-acpi-devel] [PATCH v1 1/5] ACPI: utils: Introduce acpi_match_video_device_handle() helper

On Fri, Jul 1, 2022 at 7:47 AM Mika Westerberg wrote: > > Hi Andy, > > On Fri, Jul 01, 2022 at 12:28:15AM +0300, Andy Shevchenko wrote: > > extern long acpi_is_video_device(acpi_handle handle); > > +extern bool acpi_match_video_device_handle(acpi_handle handle); > > I think we can do slightly

Re: [ibm-acpi-devel] [PATCH v1 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child()

On Thu, Jun 9, 2022 at 5:49 PM Andy Shevchenko wrote: > > On Thu, Jun 09, 2022 at 04:09:45PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Instead of walking the list of children of an ACPI device directly, > > use acpi_dev_for_each_child()

[ibm-acpi-devel] [PATCH v2 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child()

From: Rafael J. Wysocki Instead of walking the list of children of an ACPI device directly, use acpi_dev_for_each_child() to carry out an action for all of the given ACPI device's children. This will help to eliminate the children list head from struct acpi_device as it is redundant

[ibm-acpi-devel] [PATCH v1 12/16] platform/x86/thinkpad_acpi: Use acpi_dev_for_each_child()

From: Rafael J. Wysocki Instead of walking the list of children of an ACPI device directly, use acpi_dev_for_each_child() to carry out an action for all of the given ACPI device's children. This will help to eliminate the children list head from struct acpi_device as it is redundant

Re: [ibm-acpi-devel] [PATCH v5 1/3] ACPI: platform-profile: add platform_profile_cycle()

> > > > Signed-off-by: Gergo Koteles > > Thank you for your patch, 1 small remark below, > otherwise this looks good to me. > > Rafael, may I have your Ack for merging this through the pdx86 tree > together with the rest of the series once my remark has been addre