Re: [Imports] Sabbioneta buildings import

2018-02-05 Thread Andrea Musuruane
Ciao Giorgio,
 I always find your e-mails in the spam folder because the "message has
a from address in yahoo.it but has failed yahoo.it's required tests for
authentication".

On Mon, Feb 5, 2018 at 10:09 AM, Giorgio Limonta 
wrote:

> Hi Andrea thank you for your feedbacks
>
> >  I think you're rushing this import. You sent the email on talk-it just
> 4 days >ago. You should allow more time to reviewers to examine your
> proposal.
>
> Yes you right but I have send my first mail about this import to the
> talk-it in october the 17th.
>

You didn't provide any documentation at that time. It was just a single
mail about a possible import. You then disappeared for about 3 and a half
months.


> In add you have to consider that this import is not very complex in term
> of number of features and complexity of the process, but off course I'll be
> waiting the ok of the OSM community first.
>

I do believe it's not a complex import but the review process is performed
to find possible issues and avoid later troubles with bad imported data
(and I already found out some problems with your translated data). There is
no need to rush :-)


> >Your proposal miss some of the parts detailed in the >
> https://wiki.openstreetmap.org/wiki/Import/Plan_Outline. I really suggest
> you >to use it as a template and fill the different sections.
>
> I try to fill all the sections that could be explain well the import
> process
>

The "About & Goals" chapter you use past tenses but most of the actions
still have to happen.

The "Schedule" chapter is missing.

"Import Type" section in "Import Data" chapter is missing. You should
likely say your import is a one-time import, you won't use automated
scripts, all the tags will be entered manually and data will be imported in
the OSM database using JOSM.


> >There is no link to the original data set.
>
> The original dataset is not an online source, but I add this information
> in the proposal.
>

You should upload the original dataset.

>In the licence section, please add the the Municipality of Sabbioneta has
> agreed to license the data under the ODbL. Do not suppose non Italian
> speakers can read the waiver.
>
> You perfectly right, I hope now it's clear.
>

"Data license" should link to a text copy of the ODbL.

"Type of license" should be "ODbL".


> >Tagging the changeset with "source=Carta Tecnica Comunale" is not good
> enough. It does not link the data to your import. It >would be better to
> tag it like the following:
> >source=Comune di Sabbioneta
> >source:license=ODbL
> >type=import
> >url=https://wiki.openstreetmap.org/wiki/Sabbioneta
> >The source tag is mandatory. I strongly encourage to use the other ones
> too.
>
> Could be good "source=Comune di Sabbioneta - Carta Tecnica Comunale"?
>

It's fine for me, but please note that you have entered an unwanted space
in the wiki (source= Comune di Sabbioneta - Carta Tecnica Comunale).


> About the other tags I gonna add all if you think it's the right way to do
> but I wonder: Why remark that the license is ODbl? Isn''t implied?
>

As I said, I strongly encourage to use them.

Source data license is not implied. Different data sources can be
distributed under different licenses.


> >The resulting OSM file has a lot of duplicate nodes and nodes of adjacent
> buildings not connected. You can check them using JOSM >validator.
> >In multi-polygons, there are some tags that are probably a leftover from
> the original dataset: OBJECTID, Entity.
>
> I fixed them, I hope it's all right now.
>

I noticed that logging in is required to download the data. This is not
very friendly towards people without a gmail account. Can you please remove
this limitation?

The data still have some issue:

   - adjacent buildings that are not connected
   - a building has self-intersecting ways
   - churches are tagged with "denominati" (it should be denomination)
   - bell towers are tagged with man_made=campanile (shouldn't it be
   man_made=tower + tower:type=bell_tower?) and without the building tag. See
   https://wiki.openstreetmap.org/wiki/Tag:tower:type%3Dbell_tower
   - some buildings are split in different parts (still tagged as
   building=*) and you assign different heights to them. I'm not an expert
   about this but it seems this is not the right procedure. Please read
   https://wiki.openstreetmap.org/wiki/Key:height#Height_of_buildings and
   https://wiki.openstreetmap.org/wiki/Simple_3D_buildings

>The conflation phase is missing. How do you plan to conflate existing
> buildings and imported ones?
> >The revert plan is missing.
> >The QA phase is missing.
> >I guess you are the only one that will perform this import. Please state
> it in the "Team Approach" section along with your your >current OSM
> username (GiorgioL) and import username (GiorgioL-import).
>
> I hope that I have added all the requested informations.
>

I have some troubles with your conflation phase which is summarized as
"Merge the 

Re: [Imports] Sabbioneta buildings import

2018-02-05 Thread Giorgio Limonta
Hi Andrea thank you for your feedbacks
>  I think you're rushing this import. You sent the email on talk-it just 4 
>days >ago. You should allow more time to reviewers to examine your proposal.

Yes you right but I have send my first mail about this import to the talk-it in 
october the 17th. In add you have to consider that this import is not very 
complex in term of number of features and complexity of the process, but off 
course I'll be waiting the ok of the OSM community first.
>Your proposal miss some of the parts detailed in the 
>>https://wiki.openstreetmap.org/wiki/Import/Plan_Outline. I really suggest you 
>>to use it as a template and fill the different sections.

I try to fill all the sections that could be explain well the import process  
>There is no link to the original data set.
The original dataset is not an online source, but I add this information in the 
proposal.
>In the licence section, please add the the Municipality of Sabbioneta has 
>agreed to license the data under the ODbL. Do not suppose non Italian speakers 
>can read the waiver.
You perfectly right, I hope now it's clear.
>Tagging the changeset with "source=Carta Tecnica Comunale" is not good enough. 
>It does not link the data to your import. It >would be better to tag it like 
>the following:>source=Comune di 
>Sabbioneta>source:license=ODbL>type=import>url=https://wiki.openstreetmap.org/wiki/Sabbioneta>The
> source tag is mandatory. I strongly encourage to use the other ones too.
Could be good "source=Comune di Sabbioneta - Carta Tecnica Comunale"? About the 
other tags I gonna add all if you think it's the right way to do but I wonder: 
Why remark that the license is ODbl? Isn''t implied?
>The resulting OSM file has a lot of duplicate nodes and nodes of adjacent 
>buildings not connected. You can check them using JOSM >validator.>In 
>multi-polygons, there are some tags that are probably a leftover from the 
>original dataset: OBJECTID, Entity.

I fixed them, I hope it's all right now.
>The conflation phase is missing. How do you plan to conflate existing 
>buildings and imported ones?>The revert plan is missing.>The QA phase is 
>missing.>I guess you are the only one that will perform this import. Please 
>state it in the "Team Approach" section along with your your >current OSM 
>username (GiorgioL) and import username (GiorgioL-import).
I hope that I have added all the requested informations.
Many thanks for your help
Giorgio








   ___
Imports mailing list
Imports@openstreetmap.org
https://lists.openstreetmap.org/listinfo/imports


Re: [Imports] Sabbioneta buildings import

2018-02-04 Thread Andrea Musuruane
Hi Pierre,

On Sun, Feb 4, 2018 at 3:16 PM, Pierre Béland  wrote:

> the tag type is used  for relation types and the tag source:license is not
> generally used for imports.
>
> What I generally see on  the changesets is the  import=yes tag and a
> descriptive title about this specific import.  The title could contain
> reference such as
> "Sabioneta UNESCO Heritage site" + specific infos about features imported.
>

Actually all the tags I suggested are listed here:
https://wiki.openstreetmap.org/wiki/Proposed_features/changeset_tags

And they have already been used in other imports.

BR,

Andrea
___
Imports mailing list
Imports@openstreetmap.org
https://lists.openstreetmap.org/listinfo/imports


Re: [Imports] Sabbioneta buildings import

2018-02-04 Thread Pierre Béland
the tag type is used  for relation types and the tag source:license is not 
generally used for imports.
What I generally see on  the changesets is the  import=yes tag and a 
descriptive title about this specific import.  The title could contain 
reference such as"Sabioneta UNESCO Heritage site" + specific infos about 
features imported.
 
Pierre 
 

Le dimanche 4 février 2018 06:06:30 HNE, Andrea Musuruane 
 a écrit :  
 
 Hi!
   I think you're rushing this import. You sent the email on talk-it just 4 
days ago. You should allow more time to reviewers to examine your proposal.

Your proposal miss some of the parts detailed in the 
https://wiki.openstreetmap.org/wiki/Import/Plan_Outline. I really suggest you 
to use it as a template and fill the different sections.

There is no link to the original data set.

In the licence section, please add the the Municipality of Sabbioneta has 
agreed to license the data under the ODbL. Do not suppose non Italian speakers 
can read the waiver.

Tagging the changeset with "source=Carta Tecnica Comunale" is not good enough. 
It does not link the data to your import. It would be better to tag it like the 
following:
   
   -  source=Comune di Sabbioneta
   - source:license=ODbL   

   -  type=import
   -  url=https://wiki.openstreetmap.org/wiki/Sabbioneta
The source tag is mandatory. I strongly encourage to use the other ones too.

The resulting OSM file has a lot of duplicate nodes and nodes of adjacent 
buildings not connected. You can check them using JOSM validator.
In multi-polygons, there are some tags that are probably a leftover from the 
original dataset: OBJECTID, Entity.
The conflation phase is missing. How do you plan to conflate existing buildings 
and imported ones?
The revert plan is missing.

The QA phase is missing.

I guess you are the only one that will perform this import. Please state it in 
the "Team Approach" section along with your your current OSM username 
(GiorgioL) and import username (GiorgioL-import).
Thanks,
Andrea


On Sat, Feb 3, 2018 at 1:51 AM, Giorgio Limonta  
wrote:

I plan to import the buildings from the municipal topographic map of Sabbioneta 
(UNESCO site) that has only few building features in OSM.

Here is the import plan: https://wiki. openstreetmap.org/wiki/ Sabbioneta.
This import has been discussed on the Italian mailing list.
Thanks
GiorgioL

__ _
Imports mailing list
Imports@openstreetmap.org
https://lists.openstreetmap. org/listinfo/imports



___
Imports mailing list
Imports@openstreetmap.org
https://lists.openstreetmap.org/listinfo/imports
  ___
Imports mailing list
Imports@openstreetmap.org
https://lists.openstreetmap.org/listinfo/imports


Re: [Imports] Sabbioneta buildings import

2018-02-04 Thread Andrea Musuruane
Hi!
   I think you're rushing this import. You sent the email on talk-it just 4
days ago. You should allow more time to reviewers to examine your proposal.

Your proposal miss some of the parts detailed in the
https://wiki.openstreetmap.org/wiki/Import/Plan_Outline. I really suggest
you to use it as a template and fill the different sections.

There is no link to the original data set.

In the licence section, please add the the Municipality of Sabbioneta has
agreed to license the data under the ODbL. Do not suppose non Italian
speakers can read the waiver.

Tagging the changeset with "source=Carta Tecnica Comunale" is not good
enough. It does not link the data to your import. It would be better to tag
it like the following:

   - source=Comune di Sabbioneta
   - source:license=ODbL
   - type=import
   - url=https://wiki.openstreetmap.org/wiki/Sabbioneta

The source tag is mandatory. I strongly encourage to use the other ones too.

The resulting OSM file has a lot of duplicate nodes and nodes of adjacent
buildings not connected. You can check them using JOSM validator.

In multi-polygons, there are some tags that are probably a leftover from
the original dataset: OBJECTID, Entity.

The conflation phase is missing. How do you plan to conflate existing
buildings and imported ones?

The revert plan is missing.

The QA phase is missing.

I guess you are the only one that will perform this import. Please state it
in the "Team Approach" section along with your your current OSM username
(GiorgioL) and import username (GiorgioL-import).

Thanks,

Andrea



On Sat, Feb 3, 2018 at 1:51 AM, Giorgio Limonta 
wrote:

> I plan to import the buildings from the municipal topographic map of
> Sabbioneta  (UNESCO site) that
> has only few building features in OSM
> .
>
> Here is the import plan: https://wiki.openstreetmap.org/wiki/Sabbioneta.
>
> This import has been discussed on the Italian mailing list.
>
> Thanks
>
> GiorgioL
>
>
> ___
> Imports mailing list
> Imports@openstreetmap.org
> https://lists.openstreetmap.org/listinfo/imports
>
>
___
Imports mailing list
Imports@openstreetmap.org
https://lists.openstreetmap.org/listinfo/imports