Re: [infinispan-dev] public API/what should be preserve between minor releases?

2012-11-22 Thread Tomas Sykora
Hi guys, is this topic related? https://community.jboss.org/wiki/RollingUpgradesInInfinispan I'd assume that *whole* cluster will be upgraded to some higher version. Running cluster with different versions seems risky to me too. This ^^ process should be smooth but I don't know how about

Re: [infinispan-dev] Magic at JdbcStringBasedCacheStoreTest2

2012-11-22 Thread Thomas Fromm
On 22.11.2012 09:45, Thomas Fromm wrote: So why this test class does not fail in CI? Dan pointed me to the magic thing: Its not executed from CI because naming is not *Test. ;-) ___ infinispan-dev mailing list infinispan-dev@lists.jboss.org

Re: [infinispan-dev] Magic at JdbcStringBasedCacheStoreTest2

2012-11-22 Thread Dan Berindei
There are a few more tests with this issue, I've created https://issues.jboss.org/browse/ISPN-2534 to change their names. On Thu, Nov 22, 2012 at 11:34 AM, Thomas Fromm t...@tfromm.com wrote: On 22.11.2012 09:45, Thomas Fromm wrote: So why this test class does not fail in CI? Dan

Re: [infinispan-dev] Refactoring async operations

2012-11-22 Thread Galder Zamarreño
On Nov 21, 2012, at 4:49 PM, Mircea Markus mmar...@redhat.com wrote: Hi, Part of fixing ISPN-2435, I need to significantly change DistributionInterceptor which at the moment is a very complex pice of code. Building the fix on top of it is extremely difficult and error prone, so I need

Re: [infinispan-dev] ISPN-2463: Hopefully one final question

2012-11-22 Thread Tristan Tarrant
Navin, 6.0 will split core into several jars (names are currently fictional): * infinispan-api (which will only contain interfaces common to all types of caches) * infinispan-commons (common classes) * infinispan-local (local cache functionality) * infinispan-clustered (clustering

[infinispan-dev] no eviction on indexing

2012-11-22 Thread Ales Justin
I was changing cache config a bit, and got this: * https://gist.github.com/4130728 private static void verifyCacheHasNoEviction(AdvancedCache?, ? cache) { if (cache.getConfiguration().getEvictionStrategy().isEnabled()) throw new

Re: [infinispan-dev] no eviction on indexing

2012-11-22 Thread Ales Justin
Ah, OK, it should really be disabled on Lucene caches: replicated-cache name=LuceneIndexesMetadata mode=SYNC transaction mode=NONE/ eviction strategy=NONE/ file-store preload=true purge=false/

Re: [infinispan-dev] no eviction on indexing

2012-11-22 Thread Sanne Grinovero
Right you should never enable eviction on a cache used to store permanent data - like the Lucene index segment. How would you phrase the error message? On 22 November 2012 12:21, Ales Justin ales.jus...@gmail.com wrote: Ah, OK, it should really be disabled on Lucene caches:

Re: [infinispan-dev] no eviction on indexing

2012-11-22 Thread Ales Justin
Right you should never enable eviction on a cache used to store permanent data - like the Lucene index segment. But couldn't you still have eviction if you used store to persist overflown data. How would you phrase the error message? Well, at least put in the *right* cache name somewhere in

Re: [infinispan-dev] Refactoring async operations

2012-11-22 Thread Mircea Markus
Thanks for the feedback Galder! On 22 Nov 2012, at 09:53, Galder Zamarreño wrote: On Nov 21, 2012, at 4:49 PM, Mircea Markus mmar...@redhat.com wrote: Hi, Part of fixing ISPN-2435, I need to significantly change DistributionInterceptor which at the moment is a very complex pice of

Re: [infinispan-dev] Refactoring async operations

2012-11-22 Thread Mircea Markus
On 22 Nov 2012, at 10:16, Dan Berindei wrote: On Thu, Nov 22, 2012 at 11:53 AM, Galder Zamarreño gal...@redhat.com wrote: On Nov 21, 2012, at 4:49 PM, Mircea Markus mmar...@redhat.com wrote: Hi, Part of fixing ISPN-2435, I need to significantly change DistributionInterceptor

Re: [infinispan-dev] public API/what should be preserve between minor releases?

2012-11-22 Thread Mircea Markus
Hi Tomas, On 22 Nov 2012, at 08:46, Tomas Sykora wrote: Hi guys, is this topic related? https://community.jboss.org/wiki/RollingUpgradesInInfinispan Indirectly: in the case of rolling upgrades existing clients still need to be able to operate with new versions, which require an API

Re: [infinispan-dev] Refactoring async operations

2012-11-22 Thread Dan Berindei
On Thu, Nov 22, 2012 at 3:31 PM, Mircea Markus mmar...@redhat.com wrote: On 22 Nov 2012, at 10:16, Dan Berindei wrote: On Thu, Nov 22, 2012 at 11:53 AM, Galder Zamarreño gal...@redhat.comwrote: On Nov 21, 2012, at 4:49 PM, Mircea Markus mmar...@redhat.com wrote: Hi, Part of fixing

Re: [infinispan-dev] ISPN-2463: Hopefully one final question

2012-11-22 Thread Manik Surtani
And this will also determine where the tests live. I think we'll end up with a situation where the existing test suite is broken up and scattered across the different modules. On 22 Nov 2012, at 09:56, Tristan Tarrant ttarr...@redhat.com wrote: Navin, 6.0 will split core into several jars

Re: [infinispan-dev] public API/what should be preserve between minor releases?

2012-11-22 Thread Manik Surtani
On 21 Nov 2012, at 17:02, Mircea Markus mmar...@redhat.com wrote: Hi, Cache, CacheManager and all the API that's in the org.infinispan package needs to be backward compatible. What about more obscure stuff, e.g. RpcManager.invokeRemotelyInFuture(CollectionAddress recipients,

Re: [infinispan-dev] public API/what should be preserve between minor releases?

2012-11-22 Thread Mircea Markus
On 22 Nov 2012, at 17:06, Manik Surtani wrote: On 21 Nov 2012, at 17:02, Mircea Markus mmar...@redhat.com wrote: Hi, Cache, CacheManager and all the API that's in the org.infinispan package needs to be backward compatible. What about more obscure stuff, e.g.

Re: [infinispan-dev] Magic at JdbcStringBasedCacheStoreTest2

2012-11-22 Thread Dan Berindei
I don't like the idea very much, as we'd need one of those tests in each module. On Thu, Nov 22, 2012 at 7:00 PM, Manik Surtani ma...@jboss.org wrote: Maybe we should have a test that detects tests not ending in *Test, and fails accordingly? ___

Re: [infinispan-dev] ISPN-2463: Hopefully one final question

2012-11-22 Thread Navin Surtani
Yeah you're right that the tests will have to be moved about as well. There are still some instances that I'm finding where the old-school configs are being used but you don't see them in imports because of the packages that they exist in. For example, the tests in the