Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Sebastian Łaskawiec
Hey! I'm thinking about some other approach for static code analysis - SonarQube [1]. Apart from FindBugs it performs also PMD and visualizes test coverage (typically measured by Jacoco). Sonar analysis could be performed once day in separate TeamCity job. This way we would have an insight how

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Radim Vansa
Setting up analysis tool is rather easy, the hard part is to get people look into the results and fix what's wrong. And if noone does it, even setting it up is wasted time. my 2c Radim On 03/20/2015 10:48 AM, Sebastian Łaskawiec wrote: Hey! I'm thinking about some other approach for static

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Pedro Ruivo
Hi, There is a findbugs pluging for IntelliJ. I run it against the classes I modified in the PR and solve the existing problems and avoid creating new ones. Pedro On 03/19/2015 04:16 PM, Jakub Markos wrote: Hi, out of curiosity, I ran FindBugs [1] (java static analysis tool) on

Re: [infinispan-dev] org.infinispan.notifications.cachelistener.filter vs org.infinispan.filter

2015-03-20 Thread Galder Zamarreño
Yeah, should do: https://github.com/infinispan/infinispan/pull/3323 :) On 3 Mar 2015, at 16:32, Emmanuel Bernard emman...@hibernate.org wrote: Should it be morphed into a FAQ? On 03 Mar 2015, at 16:23, Galder Zamarreño gal...@redhat.com wrote: Hmm, ok. It's true that down the line the

Re: [infinispan-dev] Infinispan Directory Provider moving from Hibernate Search, suggestions on names

2015-03-20 Thread Pedro Ruivo
On 03/20/2015 02:09 PM, Tristan Tarrant wrote: Hi Gustavo, org.infinispan.directory-provider doesn't actually tell me much, it should be org.infinispan.lucene-directory-provider. I thought that the package name shouldn't have '-', but +1 for the package name As for the package name,

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Alan Field
I really like the idea of forcing a trend of improvement! :-) I agree with Radim that getting the improvement in the code is the hard part. Running static analysis tools on the files you are modifying is a great way to tackle the problem in a manageable fashion. Looking at all of the output

[infinispan-dev] Infinispan Directory Provider moving from Hibernate Search, suggestions on names

2015-03-20 Thread Gustavo Fernandes
Hi all, We are in process of migrating Hibernate Search's Infinispan Directory Provider to the Infinispan codebase. As you know, the Infinispan Lucene Directory has always been part of Infinispan, but not the layer (called 'Directory Provider') that glues it to the Hibernate Search core engine.

[infinispan-dev] Random SocketTimeoutExceptions demonstrate we're not using Netty the right way

2015-03-20 Thread Galder Zamarreño
Hi all, Summary: I've been debugging [1] and found that an unexpected operation throwing a SocketTE was being thrown due to the worker thread pool being too small, but the real problem is the fact that we can block within Netty's worker thread, something we're hoping to fix with Gustavo's work

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Sanne Grinovero
Same for Eclipse. I run it occasionally, but only the modules I'm working on. If everyone could do the same, that helps ;-) There is an option to get Maven to fail the build on specific selectable categories; I've played with that in the past but I had the impression that the annoyance level and

Re: [infinispan-dev] Infinispan Directory Provider moving from Hibernate Search, suggestions on names

2015-03-20 Thread Tristan Tarrant
Hi Gustavo, org.infinispan.directory-provider doesn't actually tell me much, it should be org.infinispan.lucene-directory-provider. As for the package name, that's fine. Tristan On 20/03/2015 14:43, Gustavo Fernandes wrote: Hi all, We are in process of migrating Hibernate Search's

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Alan Field
Hey Dan, Keeping off the thread topic for a bit: I'm all for using a standard formatting and enforcing that on commit, but I don't see how that would make it easy for people to use their preferred code style in their IDEs. Would they reformat everything so it's easier for them to read, and

Re: [infinispan-dev] Random SocketTimeoutExceptions demonstrate we're not using Netty the right way

2015-03-20 Thread Dan Berindei
Hi Galder Using cache.putAsync on the server will use a thread from the async transport executor. While the default number of threads in the transport executor is higher (25), it's still going to be exhausted at some point as you're generating more and more duplicate operations from the client.