Re: [infinispan-dev] Unwrapping exceptions

2016-08-30 Thread Radim Vansa
On 08/30/2016 02:16 PM, Dan Berindei wrote: > On Tue, Aug 30, 2016 at 1:11 PM, Sanne Grinovero wrote: >> Yes please make sure that the kind of end users exceptions are the >> same for the client, regardless if the originator happens to be an >> owner as well. >> >> It's

Re: [infinispan-dev] Unwrapping exceptions

2016-08-30 Thread Dan Berindei
On Tue, Aug 30, 2016 at 1:11 PM, Sanne Grinovero wrote: > Yes please make sure that the kind of end users exceptions are the > same for the client, regardless if the originator happens to be an > owner as well. > > It's valuable to know that the exception happened on another

Re: [infinispan-dev] SKIP_CACHE_LOAD and write skew check

2016-08-30 Thread Dan Berindei
+1 to honor it. I should have done it back when I did ISPN-5643 [1], but I guess I was afraid about breaking more tests. Note that before ISPN-5643 conditional writes also used to ignore SKIP_CACHE_LOAD, and the javadoc encouraged users to enable it together with SKIP_REMOTE_LOOKUP. [1]:

Re: [infinispan-dev] SKIP_CACHE_LOAD and write skew check

2016-08-30 Thread Radim Vansa
On 08/30/2016 12:52 PM, Pedro Ruivo wrote: > The WSC is only performed on the primary owner. But the originator needs > to keep track of the version read in order to the WSC be performed. > > I've changed this behavior for IGNORE_RETURN_VALUE flags, where the > entry is mark as "not-read" (if it

Re: [infinispan-dev] SKIP_CACHE_LOAD and write skew check

2016-08-30 Thread Pedro Ruivo
The WSC is only performed on the primary owner. But the originator needs to keep track of the version read in order to the WSC be performed. I've changed this behavior for IGNORE_RETURN_VALUE flags, where the entry is mark as "not-read" (if it wasn't read before). Then, the WSC is skipped for

Re: [infinispan-dev] Unwrapping exceptions

2016-08-30 Thread Sanne Grinovero
Yes please make sure that the kind of end users exceptions are the same for the client, regardless if the originator happens to be an owner as well. It's valuable to know that the exception happened on another node, but the exception type (and primary message) should be the same. Bonus points to

Re: [infinispan-dev] SKIP_CACHE_LOAD and write skew check

2016-08-30 Thread Sanne Grinovero
I'm not sure why this specific Flag behaves like this, but it's clear that Flags can break many things; I suspect originally they were meant to be internal-only, and I got them exposed when as a user I was having big performance trouble when doing Put operations of 1GB each and the damn thing

[infinispan-dev] SKIP_CACHE_LOAD and write skew check

2016-08-30 Thread Radim Vansa
I've noticed that SKIP_CACHE_LOAD flag is ignored when performing the write skew check (the old entry is loaded from cache store), though, it is not ignored (and the entry is not loaded) when there's CACHE_MODE_LOCAL [2]. Is that intended behaviour, or just "conserved" by tests? The flag