Re: [infinispan-dev] Calling getCache with a template and defined configuration

--Galder ZamarreñoInfinispan, Red HatOn 1 Mar 2017, at 07:01, Dan Berindei wrote:On Wed, Mar 1, 2017 at 10:18 AM, Radim Vansa wrote:I still think that if the cache is already defined, defineConfigurationshould throw an exception. This javadoc was

Re: [infinispan-dev] Calling getCache with a template and defined configuration

Alright seems fine to me. On Wed, Mar 1, 2017, 9:27 AM Tristan Tarrant wrote: > On 01/03/17 13:01, Dan Berindei wrote: > > On Wed, Mar 1, 2017 at 10:18 AM, Radim Vansa wrote: > >> I still think that if the cache is already defined, defineConfiguration >

Re: [infinispan-dev] Calling getCache with a template and defined configuration

On 01/03/17 13:01, Dan Berindei wrote: > On Wed, Mar 1, 2017 at 10:18 AM, Radim Vansa wrote: >> I still think that if the cache is already defined, defineConfiguration >> should throw an exception. This javadoc was written 7 years ago [1], > I agree with throwing an exception

Re: [infinispan-dev] Calling getCache with a template and defined configuration

On Wed, Mar 1, 2017 at 10:18 AM, Radim Vansa wrote: > I still think that if the cache is already defined, defineConfiguration > should throw an exception. This javadoc was written 7 years ago [1], > maybe with a different intention. > Strange and complex combinations don't

Re: [infinispan-dev] Calling getCache with a template and defined configuration

Hi 2017-02-28 22:51 GMT+01:00 William Burns : > So while I was trying to work on this, I have to admit I am even more torn > in regards to what to do. Looking at [1] it looks like the template > should only be applied if the cache configuration is not currently > defined.

Re: [infinispan-dev] Calling getCache with a template and defined configuration

I still think that if the cache is already defined, defineConfiguration should throw an exception. This javadoc was written 7 years ago [1], maybe with a different intention. Strange and complex combinations don't help. We have made a clear separation between templates and cache configurations;

Re: [infinispan-dev] Calling getCache with a template and defined configuration

So while I was trying to work on this, I have to admit I am even more torn in regards to what to do. Looking at [1] it looks like the template should only be applied if the cache configuration is not currently defined. Unfortunately it doesn't work this way and always applies this template to

Re: [infinispan-dev] Calling getCache with a template and defined configuration

On Mon, Feb 27, 2017 at 9:55 AM Dan Berindei wrote: > I would go for option 2. > Do you think a WARN message will be enough? I am a bit weary about this option myself. > > We already started disconnecting the cache definition and retrieval, > at least `getCache(name)`

Re: [infinispan-dev] Calling getCache with a template and defined configuration

I forgot to mention users can define their caches with ... if they want inheritance. So we don't need a way to merge configurations at this level. On Mon, Feb 27, 2017 at 4:52 PM, Dan Berindei wrote: > I would go for option 2. > > We already started disconnecting the

Re: [infinispan-dev] Calling getCache with a template and defined configuration

While we could define the behaviour as in 3), I think that this is most likely a configuration error. Therefore, I'd go with 1), and ideally provide a link to FAQ/docs where you'd explain what exactly happened in the exception message. R. On 02/27/2017 03:31 PM, William Burns wrote: > When

[infinispan-dev] Calling getCache with a template and defined configuration

When working on another project using Infinispan the code being used was a bit interesting and I don't think our template configuration handling was expecting it do so in such a way. Essentially the code defined a template for a distributed cache as well as some named caches. Then whenever a