Re: [infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-29 Thread Radim Vansa
On 10/25/2013 08:17 PM, Pedro Ruivo wrote: Hi guys. I've open a JIRA to tack this: https://issues.jboss.org/browse/ISPN-3664 Suggestions/feedback is appreciated. This is probably be integrated in the next major (but no promises). I was not cleared just ping me. Have a nice weekend folks

Re: [infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-29 Thread Pedro Ruivo
On 10/29/2013 07:58 AM, Radim Vansa wrote: On 10/25/2013 08:17 PM, Pedro Ruivo wrote: Hi guys. I've open a JIRA to tack this: https://issues.jboss.org/browse/ISPN-3664 Suggestions/feedback is appreciated. This is probably be integrated in the next major (but no promises). I was not

Re: [infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-29 Thread Dan Berindei
On Tue, Oct 29, 2013 at 1:33 PM, Pedro Ruivo pe...@infinispan.org wrote: On 10/29/2013 07:58 AM, Radim Vansa wrote: On 10/25/2013 08:17 PM, Pedro Ruivo wrote: Hi guys. I've open a JIRA to tack this: https://issues.jboss.org/browse/ISPN-3664 Suggestions/feedback is appreciated.

Re: [infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-28 Thread Galder Zamarreño
Hi Pedro, I like the idea. Reducing the number of visitX commands for write commands would be a good thing from the POV of adding new interceptors. What would happen with existing visitPutKey…etc methods? Would this dissapear or would they be left there still for those interceptors that want

Re: [infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-28 Thread Pedro Ruivo
Hi, This was discussed in the last day in Farnborough. The idea is to keep the visitX methods for each type of operations (something like): * visitPutCommand * visitRemoveCommand * visitReplaceCommand * visitRemoveIfEqualsCommand * visitReplaceIfEqualsCommand * visitPutIfAbsentCommand and

Re: [infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-28 Thread Mircea Markus
On Oct 28, 2013, at 10:55 AM, Galder Zamarreño gal...@redhat.com wrote: Hi Pedro, I like the idea. Reducing the number of visitX commands for write commands would be a good thing from the POV of adding new interceptors. +1. It would also enforce code reuse between operations that amend

[infinispan-dev] Improve WriteCommand processing code and [possibly] performance

2013-10-25 Thread Pedro Ruivo
Hi guys. I've open a JIRA to tack this: https://issues.jboss.org/browse/ISPN-3664 Suggestions/feedback is appreciated. This is probably be integrated in the next major (but no promises). I was not cleared just ping me. Have a nice weekend folks :) Regards, Pedro Description is the