On 25 Oct 2012, at 16:37, Dan Berindei wrote:
> +1, it doesn't make sense to integrate a test that you know is failing.
+1.
These should be reviewed though and uploaded to the JIRA that tracks the issue
(or create such a JIRA if missing) and then the pull request closed.
Cheers,
--
Mircea Mar
Sanne, that is different. I am talking about tests related to issue
ISPN- which is know to fail as a proof of ISPN- existence. These
tests should be attached/referenced in related JIRA, not merged in
master through PRs.
On 12-10-25 11:37 AM, Sanne Grinovero wrote:
> Hi Vladimir,
> I'm
+1, it doesn't make sense to integrate a test that you know is failing.
On Thu, Oct 25, 2012 at 5:52 PM, Vladimir Blagojevic wrote:
> Hi,
>
> I noticed that we recently have had many PR for unit tests integration
> into master. Would it not make more sense to integrate unit tests with
> actual f
Hi Vladimir,
I'm not sure I understood you. are these pulls you mention having failing tests?
I've sent a test related PR yesterday which was just changing a single
test from using deprecated code to new code, there is nothing to fix.
Sanne
On 25 October 2012 15:52, Vladimir Blagojevic wrote:
>
Hi,
I noticed that we recently have had many PR for unit tests integration
into master. Would it not make more sense to integrate unit tests with
actual fixes rather than having them merged directly to master as PRs?
I'd say leave a unit test attached/referenced in JIRA and a
developer/contrib
