Re: [infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-21 Thread Sanne Grinovero
On 21 December 2011 08:53, Galder Zamarreño gal...@redhat.com wrote: Sanne, what if the previous value has been evicted or passivated? In case of a shared cache store, one of them could go, retrieve the old value and return it. If the cache store is not shared, they could all end up doing it.

Re: [infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-21 Thread Dan Berindei
Dan, thanks for looking. So it ignores the return values: wouldn't it be more efficient to ask the remote node to not serialize it at all in first place? I mean ReplicationInterceptor should send over both Flag.SKIP_CACHE_LOAD (*not* X_LOAD) and Flag.SKIP_REMOTE_LOOKUP on any write

Re: [infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-21 Thread Sanne Grinovero
On 21 December 2011 12:30, Manik Surtani ma...@jboss.org wrote: Interesting thread.  I think this is what we should do, given that the ResponseGenerator already bypasses serialising unnecessary return values. Further, I think loading from a cache store is entirely unnecessary for the remote

Re: [infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-21 Thread Manik Surtani
On 21 Dec 2011, at 11:56, Sanne Grinovero wrote: On 21 December 2011 12:30, Manik Surtani ma...@jboss.org wrote: Interesting thread. I think this is what we should do, given that the ResponseGenerator already bypasses serialising unnecessary return values. Further, I think loading from a

Re: [infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-21 Thread Sanne Grinovero
On 21 December 2011 13:29, Manik Surtani ma...@jboss.org wrote: On 21 Dec 2011, at 11:56, Sanne Grinovero wrote: On 21 December 2011 12:30, Manik Surtani ma...@jboss.org wrote: Interesting thread.  I think this is what we should do, given that the ResponseGenerator already bypasses

Re: [infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-21 Thread Manik Surtani
Also see https://issues.jboss.org/browse/ISPN-1642 and https://github.com/infinispan/infinispan/pull/761 :-) On 21 Dec 2011, at 12:29, Manik Surtani wrote: On 21 Dec 2011, at 11:56, Sanne Grinovero wrote: On 21 December 2011 12:30, Manik Surtani ma...@jboss.org wrote: Interesting thread.

[infinispan-dev] inefficient usage of CacheLoader with REPL

2011-12-20 Thread Sanne Grinovero
Hi all, I just noticed writing a test using REPL that when doing a put operation the other nodes do a CacheLoader LOAD as well. Isn't that totally unnecessary? In fact assuming REPL guarantees consistency across all nodes, any form of remote return value should be implicitly skipped as we can