Thanks Mircea. I've made some comments.
To all:
If you're gonna submit a big pull req, please use the description to *summarise
the changes* in order to help reviewers. This helps focus the attention of the
reviewer to the pieces of code that are most relevant.
On Sep 27, 2011, at 7:10 PM,
On 28 Sep 2011, at 10:05, Galder Zamarreño wrote:
If you're gonna submit a big pull req, please use the description to
*summarise the changes* in order to help reviewers. This helps focus the
attention of the reviewer to the pieces of code that are most relevant.
+1!
--
Manik Surtani
Agreed, even better if we could use the commit description so it stays
with the code, and you can describe a step at a time.
We usually use a single-liner description, but for the more complex
patches we should add a paragraph. I did it occasionally, not sure
anybody noticed :)
Sanne
On 28
On 28 Sep 2011, at 11:31, Sanne Grinovero wrote:
Agreed, even better if we could use the commit description so it stays
with the code, and you can describe a step at a time.
We usually use a single-liner description, but for the more complex
patches we should add a paragraph. I did it
On 28 Sep 2011, at 10:05, Galder Zamarreño wrote:
Thanks Mircea. I've made some comments.
Thanks, I've replied and updated the pull request.
Also added a summary: https://github.com/infinispan/infinispan/pull/551
To all:
If you're gonna submit a big pull req, please use the description
On 28 Sep 2011, at 15:02, Galder Zamarreño wrote:
Thanks Mircea :)
To all: I've had a look and made some comments, but this patch is definitely
worth another look by at least another person.
+1
Manik and Sanne are good candidates.
___
Hi,
I've issued a pull request for SPN-1131 (Add support for optimistic locking).
My last run brought the same number of test failures in master and in my
branch, so might be a good idea to integrate it first and then continue fixing
tests.
Cheers,
Mircea
