Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

Looks good on 2LC, so I've added it to this PR containing 2LC related fixes: https://github.com/infinispan/infinispan/pull/4960 Down to 18 failures on 2LC... Cheers, -- Galder Zamarreño Infinispan, Red Hat > On 10 Mar 2017, at 11:38, Galder Zamarreño wrote: > > Neat! Just

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

Neat! Just tried quickly and seems to work on ISPN test... I'll see if it works in 2LC and if so I'll send a PR. We can then inspect where else this check might be needed. Cheers, -- Galder Zamarreño Infinispan, Red Hat > On 27 Feb 2017, at 14:01, Radim Vansa wrote: > >

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

Hi Galder, another solution came upon my mind (actually after finding this SO question [1]): we could check if (this.key == key || this.key.equals(key)) in SingleKeyNonTxInvocation context instead of just this.key.equals(key) and that could do the trick. Plus, such check maybe needed in

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

On 02/20/2017 03:52 PM, Galder Zamarreño wrote: > I've just verified the problem and the NPE can be reproduced with Infinispan > alone. > > More replies below: > > -- > Galder Zamarreño > Infinispan, Red Hat > >> On 16 Feb 2017, at 10:44, Radim Vansa wrote: >> >> On 02/15/2017

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

I've just verified the problem and the NPE can be reproduced with Infinispan alone. More replies below: -- Galder Zamarreño Infinispan, Red Hat > On 16 Feb 2017, at 10:44, Radim Vansa wrote: > > On 02/15/2017 06:07 PM, Galder Zamarreño wrote: >> -- >> Galder Zamarreño >>

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

On 02/16/2017 02:53 PM, William Burns wrote: > > > On Thu, Feb 16, 2017 at 8:51 AM Radim Vansa > wrote: > > On 02/16/2017 10:44 AM, Radim Vansa wrote: > > On 02/15/2017 06:07 PM, Galder Zamarreño wrote: > >> -- > >> Galder Zamarreño >

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

On Thu, Feb 16, 2017 at 8:51 AM Radim Vansa wrote: > On 02/16/2017 10:44 AM, Radim Vansa wrote: > > On 02/15/2017 06:07 PM, Galder Zamarreño wrote: > >> -- > >> Galder Zamarreño > >> Infinispan, Red Hat > >> > >>> On 15 Feb 2017, at 12:21, Radim Vansa

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

On 02/16/2017 10:44 AM, Radim Vansa wrote: > On 02/15/2017 06:07 PM, Galder Zamarreño wrote: >> -- >> Galder Zamarreño >> Infinispan, Red Hat >> >>> On 15 Feb 2017, at 12:21, Radim Vansa wrote: >>> >>> On 02/15/2017 11:28 AM, Galder Zamarreño wrote: Hey Radim,

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

On 02/15/2017 06:07 PM, Galder Zamarreño wrote: > -- > Galder Zamarreño > Infinispan, Red Hat > >> On 15 Feb 2017, at 12:21, Radim Vansa wrote: >> >> On 02/15/2017 11:28 AM, Galder Zamarreño wrote: >>> Hey Radim, >>> >>> Your changes in ISPN-7029 are causing issues with

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

p.s. I'm yet to verify whether such a misbehaving key produce such NPE in Infinispan... could be the case that this is all caused by my integration efforts in 2LC... Cheers, -- Galder Zamarreño Infinispan, Red Hat > On 15 Feb 2017, at 18:07, Galder Zamarreño wrote: > > >

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

-- Galder Zamarreño Infinispan, Red Hat > On 15 Feb 2017, at 12:21, Radim Vansa wrote: > > On 02/15/2017 11:28 AM, Galder Zamarreño wrote: >> Hey Radim, >> >> Your changes in ISPN-7029 are causing issues with Hibernate 2LC. >> >> In particular [2]. Name.equals() always

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

On 02/15/2017 11:28 AM, Galder Zamarreño wrote: > Hey Radim, > > Your changes in ISPN-7029 are causing issues with Hibernate 2LC. > > In particular [2]. Name.equals() always returns false, so it'll never be > found in the context. So entry is null. That's obviously a bug in the 2LC testsuite,

Re: [infinispan-dev] GetKeyValueCommand NPE with CR1 in Hibernate 2LC - ISPN-7029

Umbrella JIRA: https://issues.jboss.org/browse/ISPN-7475 For this specific issue: https://issues.jboss.org/browse/ISPN-7476 Cheers, -- Galder Zamarreño Infinispan, Red Hat > On 15 Feb 2017, at 11:28, Galder Zamarreño wrote: > > Hey Radim, > > Your changes in ISPN-7029 are