Re: FastMail.FM patchset - new patches

2007-04-05 Thread Bron Gondwana
On Thu, Mar 15, 2007 at 04:12:11PM +1100, Bron Gondwana wrote: All the patches mentioned here are available for download at: http://cyrus.brong.fastmail.fm/ We've been busy working on a bunch of cyrus issues since I last posted. In particular things we have hit cleaning up from the

Re: FastMail.FM patchset - new patches

2007-03-16 Thread David Carter
On Thu, 15 Mar 2007, John Capo wrote: masterconf_getsection() calls add_service() which inits the service structures with have_uuid but have_uuid is not set till after the services are initialized. Ah, have_uuid is new in 2.3. That line definitely needs to move, but I think that the

Re: FastMail.FM patchset - new patches

2007-03-16 Thread David Carter
On Fri, 16 Mar 2007, David Carter wrote: Ah, have_uuid is new in 2.3. That line definitely needs to move, but I think that the message_uuid_master_init() call should stay where it is. Or even (as per the fastmail patch). -- David Carter Email: [EMAIL PROTECTED]

Re: FastMail.FM patchset - new patches

2007-03-15 Thread David Carter
On Thu, 15 Mar 2007, Bron Gondwana wrote: * Make UUIDs work at all. The initialisation order of the UUID subsystem was wrong, so we had very few messages with a non-zero UUID. message_uuid_master_init() should only be called after become_cyrus(). Every time that

Re: FastMail.FM patchset - new patches

2007-03-15 Thread Rob Mueller
Is it safe? - we calulated that with one billion messages you have a one in 1 billion chance of a birthday collision (two random messages with the same UUID). They then have to get in the same MAILBOXES collection to sync_client to affect each other anyway. Isn't the case: UUIDs span

Re: FastMail.FM patchset - new patches

2007-03-15 Thread David Carter
On Thu, 15 Mar 2007, Rob Mueller wrote: May not be true, but: Is it safe? - we calulated that with one billion messages you have a one in 1 billion chance of a birthday collision (two random messages with the same UUID). Is true. Fair enough. With hindsight I should probably have

Re: FastMail.FM patchset - new patches

2007-03-15 Thread Bron Gondwana
On Thu, 15 Mar 2007 13:09:04 + (GMT), David Carter [EMAIL PROTECTED] said: On Thu, 15 Mar 2007, Rob Mueller wrote: May not be true, but: Is it safe? - we calulated that with one billion messages you have a one in 1 billion chance of a birthday collision (two random messages

Re: FastMail.FM patchset - new patches

2007-03-15 Thread John Capo
Quoting David Carter ([EMAIL PROTECTED]): Is MASTER_UUID_FILE owned by a user other than cyrus on your systems? I can't see any other obvious reason that moving message_uuid_master_init() up a few lines would help. service_create() is binding ports, which obviously has to happen as root,

Re: FastMail.FM patchset - new patches

2007-03-15 Thread John Capo
Quoting John Capo ([EMAIL PROTECTED]): Quoting David Carter ([EMAIL PROTECTED]): Is MASTER_UUID_FILE owned by a user other than cyrus on your systems? I can't see any other obvious reason that moving message_uuid_master_init() up a few lines would help. service_create() is binding

Re: FastMail.FM patchset - new patches

2007-03-15 Thread Rob Mueller
With hindsight I should probably have defined message UUIDs to be the full MD5 hash: 128 bits isn't that much worse than 96 bits per message. What is the CPU overhead like for calculating MD5 sums for everything on the fly? That would have been nice, and from an integrity point of view as

FastMail.FM patchset - new patches

2007-03-14 Thread Bron Gondwana
All the patches mentioned here are available for download at: http://cyrus.brong.fastmail.fm/ We've been busy working on a bunch of cyrus issues since I last posted. In particular things we have hit cleaning up from the sync_server left files lying around after a bail out that caused random