Re: POLL: what should reconstruct -f do?
The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) For me 3) sounds ok. I'm only wondering what could happen if there is crap in the directory which Cyrus doesn't expect? Simon Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
On Saturday 23 April 2011 01:07:00 Bron Gondwana wrote: The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) Alright, cast your votes! I'll come back to this thread in a week or so and implement the winner. (4) is the hardest to implement, but even that's not very tricky. I vote for 3. Mainly as I am wondering what will happen in the following situation: A folder X exists on the filesystem, but isn't recorded as a folder. What happens when a user now tries to create folder X? If the reconstruct had recorded it, any possible contents will already be known and no further decision about what to do with that folder has to be made. -- Joost Roeleveld Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
On Saturday 23 April 2011 01:07:00 Bron Gondwana wrote: The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) Alright, cast your votes! I'll come back to this thread in a week or so and implement the winner. (4) is the hardest to implement, but even that's not very tricky. I vote for 3. Mainly as I am wondering what will happen in the following situation: A folder X exists on the filesystem, but isn't recorded as a folder. What happens when a user now tries to create folder X? If the reconstruct had recorded it, any possible contents will already be known and no further decision about what to do with that folder has to be made. What I was wondering, isn't it possible with IMAP to have a folder with no parentfolder? If yes, does a reconstruct then create the parent folder which was not intended to be there? Simon Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
On 2011-04-23 at 10:34, Jeroen van Meeuwen (Kolab Systems) wrote: Bron Gondwana wrote: 3) add the mailbox if there's a directory, don't require cyrus.header. This one has my preference. Mine as well. -- Øyvind Kolbu Postmaster Universitetet i Oslo pgppS7kNclXEU.pgp Description: PGP signature Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
On 04/26/2011 06:52 AM, Øyvind Kolbu wrote: On 2011-04-23 at 10:34, Jeroen van Meeuwen (Kolab Systems) wrote: Bron Gondwana wrote: 3) add the mailbox if there's a directory, don't require cyrus.header. This one has my preference. Mine as well. Everybody seems to like 3. But if you only have an empty directory with no message files or something that resembles a cyrus file what is the point of creating an empty folder? :-) Or does 3 assume there are message files in the directory? Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/ Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
On 2011-04-26 at 07:07, Patrick Boutilier wrote: Everybody seems to like 3. But if you only have an empty directory with no message files or something that resembles a cyrus file what is the point of creating an empty folder? :-) I don't see why we'd suddenly get a spurious empty directory, though it would be added as a new valid empty folder. Or does 3 assume there are message files in the directory? No, 4 is 3 plus attempting to find valid messages in the directory. -- Øyvind Kolbu Postmaster Universitetet i Oslo Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
Original Message Subject: POLL: what should reconstruct -f do? From: Bron Gondwana br...@fastmail.fm To: info-cyrus@lists.andrew.cmu.edu, cyrus-de...@lists.andrew.cmu.edu Date: Friday, April 22, 2011 6:07:00 PM 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) I vote for #3. I could see #1/#4 being implemented as an option. Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
RE: POLL: what should reconstruct -f do?
3) add the mailbox if there's a directory, don't require cyrus.header. I think either 3 is the best answer with 4 being a reasonably close second. I tend to be a person who would rather have extra stuff show up and deal with it rather than run the risk of not getting something that I need. Couldn't agree more. (3) is the best options for me too. I see deleting as an easier option than dealing with the question Wait, there used to be this folder of mine... what was its name? Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
Bron Gondwana wrote: 3) add the mailbox if there's a directory, don't require cyrus.header. This one has my preference. Kind regards, Jeroen van Meeuwen -- Senior Engineer, Kolab Systems AG e: vanmeeu...@kolabsys.com t: +44 144 340 9500 w: http://www.kolabsys.com pgp: 9342 BF08 Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
POLL: what should reconstruct -f do?
The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) Alright, cast your votes! I'll come back to this thread in a week or so and implement the winner. (4) is the hardest to implement, but even that's not very tricky. Bron. Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
Re: POLL: what should reconstruct -f do?
On Sat, 23 Apr 2011, Bron Gondwana wrote: The question came up from the following bug report: http://bugzilla.cyrusimap.org/bugzilla3/show_bug.cgi?id=3449 Where there were spool files on disk, but no meta data left. Reconstruct gave no information about the files on disk at all. I see 4 options, can I'd like some opinions on what people think reconstruct should do. Speak now(ish) or hold your peace! 1) what we do now - require a cyrus.header in the directory or ignore it. 2) like (1) but warn about the directory with no cyrus.header 3) add the mailbox if there's a directory, don't require cyrus.header. 4) like (3) - but check that there's at least one cyrus.* file OR at least one message file in the directory before creating the mailbox. (so an empty directory doesn't generate a bogus mailbox, and neither does one containing nothing that looks like it belongs in a mailbox) I think either 3 is the best answer with 4 being a reasonably close second. I tend to be a person who would rather have extra stuff show up and deal with it rather than run the risk of not getting something that I need. I don't think that there's a real problem with creating 'extra' mailboxes if there are extra directories, it's easy enough for the user to delete them. saying that there needs to be a message or a cyrus.* file is a huristic that sounds like it will work most of the time, but not always. David Lang Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
