Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-26 Thread Bron Gondwana
On Thu, 25 May 2006 09:00:36 -0400, Ken Murchison [EMAIL PROTECTED] said: Robert Mueller wrote: Hi Ken There's still a serious bug in 2.3.5 that causes copied messages to be pseudo invisible in the moved to folder. I can reproduce it as follows: Have you uncovered any other bugs

Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Robert Mueller
Hi Ken There's still a serious bug in 2.3.5 that causes copied messages to be pseudo invisible in the moved to folder. I can reproduce it as follows: . select inbox.Archive * FLAGS (\Answered \Flagged \Draft \Deleted \Seen hasnoatt selected medeleted hasatt) * OK [PERMANENTFLAGS (\Answered

Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Bron Gondwana
I suspect what you're looking for is in the patch attached to this message. You forgot (entirely) to put modseq code in the append_copy path. Since modseq appears to be a property of the target folder rather than the message itself, I'm using the same code as the 2.3.4-2.3.5 diff put into the

Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Bron Gondwana
And again... [this message is brought to you by the my god, I'm coding in C again, I'm too old for this shit department] ... it appears reconstruct just blindly re-applied the value of modseq from the already existing entry without checking if it was valid. The attached patch contains my

Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Bron Gondwana
And again... [Rob suggested this bit might hit some filters, so I'm posting again with it out] ... it appears reconstruct just blindly re-applied the value of modseq from the already existing entry without checking if it was valid. The attached patch contains my previous patch to fix the

Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Ken Murchison
Robert Mueller wrote: Hi Ken There's still a serious bug in 2.3.5 that causes copied messages to be pseudo invisible in the moved to folder. I can reproduce it as follows: Have you uncovered any other bugs that need to be fixed before I embarrass myself again by making a premature 2.3.6

Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Bron Gondwana
On Thu, 25 May 2006 09:00:36 -0400, Ken Murchison [EMAIL PROTECTED] said: Robert Mueller wrote: Hi Ken There's still a serious bug in 2.3.5 that causes copied messages to be pseudo invisible in the moved to folder. I can reproduce it as follows: Have you uncovered any other bugs

Re: Some part of bug from 2.3.4 still in 2.3.5

2006-05-25 Thread Hajimu UMEMOTO
Hi, On Thu, 25 May 2006 18:00:00 +1000 Bron Gondwana [EMAIL PROTECTED] said: brong ... it appears reconstruct just blindly re-applied the value of brong modseq from the already existing entry without checking if it brong was valid. brong The attached patch contains my previous patch to fix