Re: Jenkins CI granting excessive +1s

2015-06-17 Thread Dan Kenigsberg
On Tue, Jun 16, 2015 at 08:48:17PM +0200, dcaro wrote: On 06/16, Eyal Edri wrote: Sounds like a bug. Jenkins should only use the CI flag and not change CR and V flags. Might have been a misunderstanding. David, can you fix it so Jenkins will only update CI flag? Can someone pass me

Re: Jenkins CI granting excessive +1s

2015-06-17 Thread dcaro
I just rolled out the CI flag to all the projects this morning, restricting jenkins to set only that flag, did that happen again after it? On 06/17, Dan Kenigsberg wrote: On Tue, Jun 16, 2015 at 08:48:17PM +0200, dcaro wrote: On 06/16, Eyal Edri wrote: Sounds like a bug. Jenkins should

Re: Jenkins CI granting excessive +1s

2015-06-17 Thread Dan Kenigsberg
On Wed, Jun 17, 2015 at 03:05:52PM +0200, dcaro wrote: I just rolled out the CI flag to all the projects this morning, restricting jenkins to set only that flag, did that happen again after it? No, all seems clear now. Thanks. ___ Infra mailing list

Jenkins CI granting excessive +1s

2015-06-16 Thread Dan Kenigsberg
As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for every patchset that it successfully passed. Was this change somehow intentional? It is confusing and unwanted. Only a human developer can give a meaningful Code-Review. Only a human user/QE can say that a patch solved the

Re: Jenkins CI granting excessive +1s

2015-06-16 Thread Eyal Edri
: ee...@redhat.com; dc...@redhat.com Subject: Jenkins CI granting excessive +1s As of yesterday, Jenkins CI starting granting CR+1, V+1 and CI+1 for every patchset that it successfully passed. Was this change somehow intentional? It is confusing and unwanted. Only a human developer can give

Re: Jenkins CI granting excessive +1s

2015-06-16 Thread dcaro
have the ci flag we can't enforce it globally. E. Eyal Edri Supervisor, RHEV CI Red Hat From: Dan Kenigsberg Sent: Jun 16, 2015 7:06 PM To: infra@ovirt.org Cc: ee...@redhat.com; dc...@redhat.com Subject: Jenkins CI granting excessive +1s As of yesterday, Jenkins CI starting granting