Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

It's disabled (to view by others) by default unless we add special permission. Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1 On Tue, Dec 20, 2016 at 6:24 PM, Tal Nisan

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

It's disabled (to view by others) by default unless we add special permission. Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1 On Tue, Dec 20, 2016 at 6:24 PM, Tal Nisan

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

If you disabled other people from watching it if they are not reviewers then it's fine to leave it like that then On Tue, Dec 20, 2016 at 6:21 PM, Shlomo Ben David wrote: > About the last thing... > When people push drafts only they can view them, unless they add someone >

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

About the last thing... When people push drafts only they can view them, unless they add someone as reviewers before publishing it as a regular patch. That's why I think it is useless permission, but if you still want i can add it. Best Regards, Shlomi Ben-David | Software Engineer | Red Hat

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

Hi Tal/Eyal, I added CR (-/+)2 permission for the ovirt-engine-master-maintainers group on the stable-branches. Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL RHCSA | RHCE IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci) OPEN SOURCE - 1 4 011 && 011 4 1 On Tue,

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

OK, thanks for the clarification. We'll add the missing permission. any other permissions master-branch-maintainers should have on stable branch? On Tue, Dec 20, 2016 at 5:44 PM, Tal Nisan wrote: > That was always the case, master maintainers should have +2 on the stable >

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

That was always the case, master maintainers should have +2 on the stable branches without merge rights, this helps me distinguished between: 1. Who is actually a maintainer from the ones acking the patch 2. If a maintainer meant we're good to go or gave his review yet would like another reviewer

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

I wasn't aware we were allowing +2 permissions without merge rights on stable branch, If this should be supported then we need to update the permissions, so all master branch maintainers need +2 (w/o merge) to stable branches? On Tue, Dec 20, 2016 at 4:58 PM, Tal Nisan wrote:

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

Master On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri wrote: > stable branch maintainers or master branch maintainers? > > On Dec 20, 2016 4:40 PM, "Tal Nisan" wrote: > >> Heard it from a couple of guys, yesterday it appeared to be working fine, >> today it's

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

stable branch maintainers or master branch maintainers? On Dec 20, 2016 4:40 PM, "Tal Nisan" wrote: > Heard it from a couple of guys, yesterday it appeared to be working fine, > today it's not > > > ___ > Infra mailing list >

Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

Heard it from a couple of guys, yesterday it appeared to be working fine, today it's not ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra