[JIRA] (OVIRT-1926) squash identified as a mere message update
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=38661#comment-38661 ] Eyal Edri commented on OVIRT-1926: -- keeping as tracker for the open bug, to see if we'll need to upgrade at some point. > squash identified as a mere message update > -- > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git >Reporter: Yedidyah Bar David >Assignee: infra >Priority: Low > > I had [1] and [2]. Patchset 8 of [2] is a combination of: > - Patchset 7 of it, > - [1] squashed into it, > - Commit message change. > Gerrit commented: > Uploaded patch set 8: Commit message was updated. > In theory it was right, because there was no code change between 7 and > 8. But I'd expect it to either be silent, or to notice that there was > also a squash (and suggest to abandon the squashed patch?). > [1] https://gerrit.ovirt.org/#/c/88669/ > [2] https://gerrit.ovirt.org/#/c/88634/ > -- > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100096) ___ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-le...@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/ILTIIM4F7R4677F5BEXO423BZUFQJ6UV/
[JIRA] (OVIRT-1926) squash identified as a mere message update
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Edri updated OVIRT-1926: - Priority: Low (was: Medium) > squash identified as a mere message update > -- > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git >Reporter: Yedidyah Bar David >Assignee: infra >Priority: Low > > I had [1] and [2]. Patchset 8 of [2] is a combination of: > - Patchset 7 of it, > - [1] squashed into it, > - Commit message change. > Gerrit commented: > Uploaded patch set 8: Commit message was updated. > In theory it was right, because there was no code change between 7 and > 8. But I'd expect it to either be silent, or to notice that there was > also a squash (and suggest to abandon the squashed patch?). > [1] https://gerrit.ovirt.org/#/c/88669/ > [2] https://gerrit.ovirt.org/#/c/88634/ > -- > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100096) ___ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-le...@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/UP56VGKYRFIY5BZHVKTYLPPOGTQYMBLR/
[JIRA] (OVIRT-1926) squash identified as a mere message update
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Edri updated OVIRT-1926: - Issue Type: Bug (was: By-EMAIL) > squash identified as a mere message update > -- > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: Bug >Reporter: Yedidyah Bar David >Assignee: infra > > I had [1] and [2]. Patchset 8 of [2] is a combination of: > - Patchset 7 of it, > - [1] squashed into it, > - Commit message change. > Gerrit commented: > Uploaded patch set 8: Commit message was updated. > In theory it was right, because there was no code change between 7 and > 8. But I'd expect it to either be silent, or to notice that there was > also a squash (and suggest to abandon the squashed patch?). > [1] https://gerrit.ovirt.org/#/c/88669/ > [2] https://gerrit.ovirt.org/#/c/88634/ > -- > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100096) ___ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-le...@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/M6MHO4GK6UHKS63RTGHNFGUV256JIQLE/
[JIRA] (OVIRT-1926) squash identified as a mere message update
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Edri updated OVIRT-1926: - Component/s: Gerrit/git > squash identified as a mere message update > -- > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: Bug > Components: Gerrit/git >Reporter: Yedidyah Bar David >Assignee: infra > > I had [1] and [2]. Patchset 8 of [2] is a combination of: > - Patchset 7 of it, > - [1] squashed into it, > - Commit message change. > Gerrit commented: > Uploaded patch set 8: Commit message was updated. > In theory it was right, because there was no code change between 7 and > 8. But I'd expect it to either be silent, or to notice that there was > also a squash (and suggest to abandon the squashed patch?). > [1] https://gerrit.ovirt.org/#/c/88669/ > [2] https://gerrit.ovirt.org/#/c/88634/ > -- > Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100096) ___ Infra mailing list -- infra@ovirt.org To unsubscribe send an email to infra-le...@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/infra@ovirt.org/message/45FQWYAXLK7T3GSX7P64YBDBZORX64KV/
Re: [JIRA] (OVIRT-1926) squash identified as a mere message update
On Mon, Mar 12, 2018 at 2:09 PM, Barak Korren (oVirt JIRA) < j...@ovirt-jira.atlassian.net> wrote: > [ > https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=36024#comment-36024 > ] > > Barak Korren commented on OVIRT-1926: > > I don't think it has to do with [1], looking in Gerrit, there does not > seem to be any code difference between patchsets 7 and 8 of [2]. > Not sure what you mean. I already wrote that there was no code change. But there definitely was a _squash_. So the git history was very different. Patchsets 7 and 8 had different parents. > In any case this Gerrit behaviour is not something any code we maintain > does. > Fine, so you mean I should file a bug against gerrit itself? OK: https://bugs.chromium.org/p/gerrit/issues/detail?id=8521 > squash identified as a mere message update > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL > Reporter: Yedidyah Bar David > Assignee: infra > > — This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100082) > > ___ > Infra mailing list > Infra@ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > > -- Didi ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
[JIRA] (OVIRT-1926) squash identified as a mere message update
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=36025#comment-36025 ] Yedidyah Bar David commented on OVIRT-1926: --- On Mon, Mar 12, 2018 at 2:09 PM, Barak Korren (oVirt JIRA) < Not sure what you mean. I already wrote that there was no code change. But there definitely was a _squash_. So the git history was very different. Patchsets 7 and 8 had different parents. Fine, so you mean I should file a bug against gerrit itself? OK: https://bugs.chromium.org/p/gerrit/issues/detail?id=8521 -- Didi > squash identified as a mere message update > -- > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL >Reporter: Yedidyah Bar David >Assignee: infra > -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100082) ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
[JIRA] (OVIRT-1926) squash identified as a mere message update
[ https://ovirt-jira.atlassian.net/browse/OVIRT-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=36024#comment-36024 ] Barak Korren commented on OVIRT-1926: - I don't think it has to do with [1], looking in Gerrit, there does not seem to be any code difference between patchsets 7 and 8 of [2]. In any case this Gerrit behaviour is not something any code we maintain does. > squash identified as a mere message update > -- > > Key: OVIRT-1926 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 > Project: oVirt - virtualization made easy > Issue Type: By-EMAIL >Reporter: Yedidyah Bar David >Assignee: infra > -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100082) ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
[JIRA] (OVIRT-1926) squash identified as a mere message update
Yedidyah Bar David created OVIRT-1926: - Summary: squash identified as a mere message update Key: OVIRT-1926 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1926 Project: oVirt - virtualization made easy Issue Type: By-EMAIL Reporter: Yedidyah Bar David Assignee: infra I had [1] and [2]. Patchset 8 of [2] is a combination of: - Patchset 7 of it, - [1] squashed into it, - Commit message change. Gerrit commented: Uploaded patch set 8: Commit message was updated. In theory it was right, because there was no code change between 7 and 8. But I'd expect it to either be silent, or to notice that there was also a squash (and suggest to abandon the squashed patch?). [1] https://gerrit.ovirt.org/#/c/88669/ [2] https://gerrit.ovirt.org/#/c/88634/ -- Didi -- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100082) ___ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
