[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-25 Thread Shlomo Ben David (oVirt JIRA) 

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-900:
---
Resolution: Fixed
Status: Done  (was: To Do)

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-25 Thread Shlomo Ben David (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=24937#comment-24937
 ] 

Shlomo Ben David commented on OVIRT-900:


It was fixed by adding the following permissions as default:

Forge Author Identity ==> set to 'Registered Users' instead of 'Project Owners'
Forge Committer Identity ==> 'Registered Users' instead of 'Project Owners'

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.621.5#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-08 Thread eyal edri [Administrator] (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=24148#comment-24148
 ] 

eyal edri [Administrator] commented on OVIRT-900:
-

[~ybron...@redhat.com] can you check if it works for you now? 

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.620.0#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-08 Thread eyal edri [Administrator] (oVirt JIRA) 

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

eyal edri [Administrator] updated OVIRT-900:

Epic Link: OVIRT-403

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.620.0#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-08 Thread eyal edri [Administrator] (oVirt JIRA) 

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

eyal edri [Administrator] updated OVIRT-900:

Epic Link: OVIRT-403

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.620.0#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread eyal edri [Administrator] (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23827#comment-23827
 ] 

eyal edri [Administrator] commented on OVIRT-900:
-

[~sbend...@redhat.com] can you check if rebasing on someone else patch and 
pushing again requires the 'forget identity' permission or its a different one?

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread ybronhei (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23826#comment-23826
 ] 

ybronhei commented on OVIRT-900:


you can always ignore the patchset and push your version again. otherwise
you cant rebase your patch on it I think

On Sun, Dec 4, 2016 at 3:00 PM, eyal edri [Administrator] (oVirt JIRA) <




-- 
*Yaniv Bronhaim.*


> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread Yaniv Bronheim 
you can always ignore the patchset and push your version again. otherwise
you cant rebase your patch on it I think

On Sun, Dec 4, 2016 at 3:00 PM, eyal edri [Administrator] (oVirt JIRA) <
j...@ovirt-jira.atlassian.net> wrote:

>
> [ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=23824#comment-23824 ]
>
> eyal edri [Administrator] commented on OVIRT-900:
> -
>
> So what you're saying is any 'registered user' should have 'forge author
> identity' permission?
> Isn't that a bit of a security issue?
>
> On Sun, Dec 4, 2016 at 2:58 PM, ybronhei (oVirt JIRA) <
>
>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
>
> > Re: Rebase over other author's patch cannot be pushed to gerrit
> > ---
> >
> > Key: OVIRT-900
> > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> > Project: oVirt - virtualization made easy
> >  Issue Type: By-EMAIL
> >Reporter: Barak Korren
> >Assignee: Shlomo Ben David
> >
> > Forwarding to infra-support.
> > On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > > Not sure since when it was changed, but I noticed that I can't push
> patches
> > > if I'm not the author
> > >
> > > Counting objects: 50, done.
> > > Delta compression using up to 4 threads.
> > > Compressing objects: 100% (50/50), done.
> > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > > Total 50 (delta 34), reused 0 (delta 0)
> > > remote: Resolving deltas: 100% (34/34)
> > > remote: Processing changes: refs: 1, done
> > > remote:
> > > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > > remote: ERROR:  author email address rnach...@redhat.com
> > > remote: ERROR:  does not match your user account.
> > > remote: ERROR:
> > > remote: ERROR:  The following addresses are currently registered:
> > > remote: ERROR:bronh...@gmail.com
> > > remote: ERROR:ybron...@redhat.com
> > > remote: ERROR:
> > > remote: ERROR:  To register an email address, please visit:
> > > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > > remote:
> > > remote:
> > > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> > >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > > error: failed to push some refs to
> > > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> > >
> > > We must have permissions to do that, this is part of the rebasing
> part, and
> > > I think its fine to fix patches on behalf of someone else.. but its
> not the
> > > best practice for reviewing.
> > > anyway, please undo this change, unless its something that related
> only to
> > > my env.. let me know
> > >
> > > Thanks
> > >
> > > --
> > > Yaniv Bronhaim.
> > >
> > > ___
> > > Infra mailing list
> > > Infra@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/infra
> > >
> > --
> > Barak Korren
> > bkor...@redhat.com
> > RHCE, RHCi, RHV-DevOps Team
> > https://ifireball.wordpress.com/
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v1000.610.2#100023)
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>



-- 
*Yaniv Bronhaim.*
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread eyal edri [Administrator] (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23824#comment-23824
 ] 

eyal edri [Administrator] commented on OVIRT-900:
-

So what you're saying is any 'registered user' should have 'forge author
identity' permission?
Isn't that a bit of a security issue?

On Sun, Dec 4, 2016 at 2:58 PM, ybronhei (oVirt JIRA) <




-- 
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)


> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread ybronhei (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23823#comment-23823
 ] 

ybronhei commented on OVIRT-900:


no.. this is not the issue here. I don't try to merge, I try to push a
change on a patch that im not the author of it. everyone should allow to do
so

On Sun, Dec 4, 2016 at 1:25 PM, eyal edri [Administrator] (oVirt JIRA) <




-- 
*Yaniv Bronhaim.*


> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread Yaniv Bronheim 
no.. this is not the issue here. I don't try to merge, I try to push a
change on a patch that im not the author of it. everyone should allow to do
so

On Sun, Dec 4, 2016 at 1:25 PM, eyal edri [Administrator] (oVirt JIRA) <
j...@ovirt-jira.atlassian.net> wrote:

>
> [ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=23821#comment-23821 ]
>
> eyal edri [Administrator] commented on OVIRT-900:
> -
>
> OK, so as I suggested its best to verify the list of people in those
> groups and add/remove people who are missing.
>
> > Re: Rebase over other author's patch cannot be pushed to gerrit
> > ---
> >
> > Key: OVIRT-900
> > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> > Project: oVirt - virtualization made easy
> >  Issue Type: By-EMAIL
> >Reporter: Barak Korren
> >Assignee: Shlomo Ben David
> >
> > Forwarding to infra-support.
> > On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > > Not sure since when it was changed, but I noticed that I can't push
> patches
> > > if I'm not the author
> > >
> > > Counting objects: 50, done.
> > > Delta compression using up to 4 threads.
> > > Compressing objects: 100% (50/50), done.
> > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > > Total 50 (delta 34), reused 0 (delta 0)
> > > remote: Resolving deltas: 100% (34/34)
> > > remote: Processing changes: refs: 1, done
> > > remote:
> > > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > > remote: ERROR:  author email address rnach...@redhat.com
> > > remote: ERROR:  does not match your user account.
> > > remote: ERROR:
> > > remote: ERROR:  The following addresses are currently registered:
> > > remote: ERROR:bronh...@gmail.com
> > > remote: ERROR:ybron...@redhat.com
> > > remote: ERROR:
> > > remote: ERROR:  To register an email address, please visit:
> > > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > > remote:
> > > remote:
> > > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> > >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > > error: failed to push some refs to
> > > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> > >
> > > We must have permissions to do that, this is part of the rebasing
> part, and
> > > I think its fine to fix patches on behalf of someone else.. but its
> not the
> > > best practice for reviewing.
> > > anyway, please undo this change, unless its something that related
> only to
> > > my env.. let me know
> > >
> > > Thanks
> > >
> > > --
> > > Yaniv Bronhaim.
> > >
> > > ___
> > > Infra mailing list
> > > Infra@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/infra
> > >
> > --
> > Barak Korren
> > bkor...@redhat.com
> > RHCE, RHCi, RHV-DevOps Team
> > https://ifireball.wordpress.com/
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v1000.610.2#100023)
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>



-- 
*Yaniv Bronhaim.*
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread eyal edri [Administrator] (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23821#comment-23821
 ] 

eyal edri [Administrator] commented on OVIRT-900:
-

OK, so as I suggested its best to verify the list of people in those groups and 
add/remove people who are missing.

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread Shlomo Ben David (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23820#comment-23820
 ] 

Shlomo Ben David commented on OVIRT-900:


Only the 'vdsm-master-maintainers' group have full permissions on the master 
branch (and 'vdsm-maintainers' group as the owner of the project)
The user has permission as a registered user: push, verify, code-review on the 
'master' branch because he is not a member of that group.

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread eyal edri [Administrator] (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23815#comment-23815
 ] 

eyal edri [Administrator] commented on OVIRT-900:
-

If he has merge rights on master, then yes. 
Maybe its a good idea to ask the vdsm maintainers who should have merge rights 
on master ( i.e belongs in the master maintainers group )

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread Shlomo Ben David (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23809#comment-23809
 ] 

Shlomo Ben David commented on OVIRT-900:


Hi,

Nope, the 'Forge author Identity' is set specifically with the following
permissions:
'vdsm-master-maintainers' group for the 'master' branch
'vdsm-stable-maintainers' group for 'stable' branches


   - The user ybron...@redhat.com is a member of 'vdsm-stable-maintainers'
   and 'vdsm-arch-dependencies' groups
   - The user is not a member of 'vdsm-master-maintainers' group.


Should I add him to the 'vdsm-master-maintainers' group?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Thu, Dec 1, 2016 at 6:17 PM, eyal edri [Administrator] (oVirt JIRA) <



> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-04 Thread Shlomo Ben David 
Hi,

Nope, the 'Forge author Identity' is set specifically with the following
permissions:
'vdsm-master-maintainers' group for the 'master' branch
'vdsm-stable-maintainers' group for 'stable' branches


   - The user ybron...@redhat.com is a member of 'vdsm-stable-maintainers'
   and 'vdsm-arch-dependencies' groups
   - The user is not a member of 'vdsm-master-maintainers' group.


Should I add him to the 'vdsm-master-maintainers' group?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Thu, Dec 1, 2016 at 6:17 PM, eyal edri [Administrator] (oVirt JIRA) <
j...@ovirt-jira.atlassian.net> wrote:

>
> [ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=23633#comment-23633 ]
>
> eyal edri [Administrator] commented on OVIRT-900:
> -
>
> [~sbend...@redhat.com] maybe missing 'forge author identity' permission
> missing to all 'master branch maintaines'?
>
> > Re: Rebase over other author's patch cannot be pushed to gerrit
> > ---
> >
> > Key: OVIRT-900
> > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> > Project: oVirt - virtualization made easy
> >  Issue Type: By-EMAIL
> >Reporter: Barak Korren
> >Assignee: Shlomo Ben David
> >
> > Forwarding to infra-support.
> > On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > > Not sure since when it was changed, but I noticed that I can't push
> patches
> > > if I'm not the author
> > >
> > > Counting objects: 50, done.
> > > Delta compression using up to 4 threads.
> > > Compressing objects: 100% (50/50), done.
> > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > > Total 50 (delta 34), reused 0 (delta 0)
> > > remote: Resolving deltas: 100% (34/34)
> > > remote: Processing changes: refs: 1, done
> > > remote:
> > > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > > remote: ERROR:  author email address rnach...@redhat.com
> > > remote: ERROR:  does not match your user account.
> > > remote: ERROR:
> > > remote: ERROR:  The following addresses are currently registered:
> > > remote: ERROR:bronh...@gmail.com
> > > remote: ERROR:ybron...@redhat.com
> > > remote: ERROR:
> > > remote: ERROR:  To register an email address, please visit:
> > > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > > remote:
> > > remote:
> > > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> > >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > > error: failed to push some refs to
> > > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> > >
> > > We must have permissions to do that, this is part of the rebasing
> part, and
> > > I think its fine to fix patches on behalf of someone else.. but its
> not the
> > > best practice for reviewing.
> > > anyway, please undo this change, unless its something that related
> only to
> > > my env.. let me know
> > >
> > > Thanks
> > >
> > > --
> > > Yaniv Bronhaim.
> > >
> > > ___
> > > Infra mailing list
> > > Infra@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/infra
> > >
> > --
> > Barak Korren
> > bkor...@redhat.com
> > RHCE, RHCi, RHV-DevOps Team
> > https://ifireball.wordpress.com/
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v1000.606.0#100023)
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-01 Thread eyal edri [Administrator] (oVirt JIRA) 

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23633#comment-23633
 ] 

eyal edri [Administrator] commented on OVIRT-900:
-

[~sbend...@redhat.com] maybe missing 'forge author identity' permission missing 
to all 'master branch maintaines'? 

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.606.0#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-01 Thread Barak Korren (oVirt JIRA) 

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barak Korren reassigned OVIRT-900:
--

Assignee: Shlomo Ben David  (was: infra)

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.606.0#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Rebase over other author's patch cannot be pushed to gerrit

2016-12-01 Thread Barak Korren 
Forwarding to infra-support.

On 1 December 2016 at 18:03, Yaniv Bronheim  wrote:
> Not sure since when it was changed, but I noticed that I can't push patches
> if I'm not the author
>
> Counting objects: 50, done.
> Delta compression using up to 4 threads.
> Compressing objects: 100% (50/50), done.
> Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> Total 50 (delta 34), reused 0 (delta 0)
> remote: Resolving deltas: 100% (34/34)
> remote: Processing changes: refs: 1, done
> remote:
> remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> remote: ERROR:  author email address rnach...@redhat.com
> remote: ERROR:  does not match your user account.
> remote: ERROR:
> remote: ERROR:  The following addresses are currently registered:
> remote: ERROR:bronh...@gmail.com
> remote: ERROR:ybron...@redhat.com
> remote: ERROR:
> remote: ERROR:  To register an email address, please visit:
> remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> remote:
> remote:
> To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
>  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> error: failed to push some refs to
> 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
>
> We must have permissions to do that, this is part of the rebasing part, and
> I think its fine to fix patches on behalf of someone else.. but its not the
> best practice for reviewing.
> anyway, please undo this change, unless its something that related only to
> my env.. let me know
>
> Thanks
>
> --
> Yaniv Bronhaim.
>
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>



-- 
Barak Korren
bkor...@redhat.com
RHCE, RHCi, RHV-DevOps Team
https://ifireball.wordpress.com/
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra