Re: Mirrorlist server bug report - behaviour change requested

2019-11-12 Thread Adrian Reber
On Mon, Nov 11, 2019 at 02:15:03PM +0100, Adrian Reber wrote:
> I was contacted by someone working on openSUSE's Open Build System
> (OBS). They are using download.fedoraproject.org and some layout change
> concerning noarch breaks their workflow. The problem is, that the
> redirect service of download.fedoraproject.org based on the mirrorlist
> servers returns a 200 and 'error: invalid path'. See
> 
> https://github.com/adrianreber/mirrorlist-server/issues/1
> 
> So this problem is unrelated to the new mirrorlist implementation. The
> old code did the same. Error message and a 200 return code.
> 
> I think changing the return code to 404 is the correct thing to do, but
> I wanted to check if anybody sees any problems with this behaviour
> change of the mirrorlist server.

The new mirrorlist-server which returns a 404 for non-existing
directories in its database has been released and deployed in staging.
So far everything still seems to work correctly. I will make the
necessary ansible changes tomorrow.

Adrian
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org


Re: patches to review to prepare our ansible scripts for fedora-messaging

2019-11-12 Thread Julen Landa Alustiza
-body=dict(
-playbook=self.playbook_path,
-userid=getlogin(),
-results=results,
-),
+topic="ansible.playbook.complete",
+body=dict(playbook=self.playbook_path, userid=getlogin(), 
results=results),
  )

I think I had read somewhere that we were going to stop using inline dict 
arrays on yaml.

We have tons of them, but if the plan is to reduce them inlining an not inline 
dict is the opposite way to go

:)
Julen Landa Alustiza 
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org


Re: Another patch that makes nagios send the messages with fedora-messaging

2019-11-12 Thread Stephen John Smoogen
will do so.

On Tue, 12 Nov 2019 at 08:58, Karsten Hopp  wrote:
>
> Hi Stephen,
>
> Thanks a lot for reviewing this.
>
> As I don't have write access afaik, could you merge that into the repo,
> please ?
>
>   Thanks, Karsten
>
> Am 11.11.19 um 20:37 schrieb Stephen John Smoogen:
> > Looks good to me as the nagios person
> >
> > On Mon, 11 Nov 2019 at 11:05, Karsten Hopp  wrote:
> >> It helps when patches are attached ;-(
> >>
> >>
> >> Am 09.11.19 um 01:43 schrieb Karsten Hopp:
> >>> Hi all,
> >>> Now that https://pagure.io/releng/pull-request/8940 got merged we can
> >>> migrate nagios  from fedmsg to fedora-messaging.
> >>>
> >>> The attached patches are for switching nagios to fedora-messaging,
> >>> please review and merge if they look sane to you.
> >>>
> >>>
> >>> Thanks, Karsten
> >>>
> >> ___
> >> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> >> To unsubscribe send an email to 
> >> infrastructure-le...@lists.fedoraproject.org
> >> Fedora Code of Conduct: 
> >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >> List Archives: 
> >> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org
> >
> >
> ___
> infrastructure mailing list -- infrastructure@lists.fedoraproject.org
> To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org



-- 
Stephen J Smoogen.
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org


Re: Meeting Agenda Item: Introduction Kevin Sandy

2019-11-12 Thread Matthew Miller
On Tue, Nov 12, 2019 at 06:33:18AM -0500, Kevin Sandy wrote:
> I’m very interested in getting involved in the Infrastructure group. I’ve
> been holding off on this for over a year, waiting to have “more time”, but
> figured I may as well jump in and start small, maybe 3-5 hours per week?

Awesome -- welcome!


-- 
Matthew Miller

Fedora Project Leader
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org


Re: patches to review to prepare our ansible scripts for fedora-messaging

2019-11-12 Thread Karsten Hopp

Hi Jeremy,


Thanks have taking a look.

The first patch should have been squashed with the second, those were 
one black fixes.


I'll attach new patches 13 and 14, please drop the old ones.

0014 implements the exception handling, 0013 is the squashed old 0013+0014


   Karsten


Am 11.11.19 um 17:07 schrieb Jeremy Cline:

On Sat, Nov 09, 2019 at 01:38:32AM +0100, kars...@fedoraproject.org wrote:

Hello,


There is work in progress to migrate our applications from the current
message bus 'fedmsg' to the AMPG based 'fedora-messaging'.

Attached are a couple of patches that prepare our ansible scripts for this.

Please review those patches and comment, thanks !

    Karsten

 From 538f112bc17a511b0117ccac31f6c2e5ff0ee97a Mon Sep 17 00:00:00 2001
From: Karsten Hopp 
Date: Fri, 8 Nov 2019 22:34:47 +0100
Subject: [PATCH 14/14] add callbacks for fedora-messaging


The subject here doesn't reflect at all what is in the patch, which is
pure style changes.


Signed-off-by: Karsten Hopp 
---
  callback_plugins/fedora_messaging_callback.py  | 16 ++--
  callback_plugins/fedora_messaging_callback2.py | 17 +++--
  2 files changed, 13 insertions(+), 20 deletions(-)

diff --git a/callback_plugins/fedora_messaging_callback.py 
b/callback_plugins/fedora_messaging_callback.py
index c83785e9b..31e918dde 100644
--- a/callback_plugins/fedora_messaging_callback.py
+++ b/callback_plugins/fedora_messaging_callback.py
@@ -29,10 +29,11 @@ except ImportError:
  # Ansible v1 compat
  CallbackBase = object
  
+

  def getlogin():
  try:
  user = os.getlogin()
-except OSError, e:
+except OSError as e:
  user = pwd.getpwuid(os.geteuid())[0]
  return user
  
@@ -45,11 +46,10 @@ class CallbackModule(CallbackBase):

  def __init__(self):
  pass
  
-

  def playbook_on_play_start(self, pattern):
  # This gets called once for each play.. but we just issue a message 
once
  # for the first one.  One per "playbook"
-play = getattr(self, 'play', None)
+play = getattr(self, "play", None)
  if play:
  # figure out where the playbook FILE is
  path = os.path.abspath(play.playbook.filename)
@@ -60,7 +60,7 @@ class CallbackModule(CallbackBase):
  
  if not self.playbook_path:

  msg = Message(
-topic='ansible.playbook.start',
+topic="ansible.playbook.start",
  body=dict(
  playbook=path,
  userid=getlogin(),
@@ -79,11 +79,7 @@ class CallbackModule(CallbackBase):
  
  results = dict([(h, stats.summarize(h)) for h in stats.processed])

  msg = Message(
-topic='ansible.playbook.complete',
-body=dict(
-playbook=self.playbook_path,
-userid=getlogin(),
-results=results,
-),
+topic="ansible.playbook.complete",
+body=dict(playbook=self.playbook_path, userid=getlogin(), 
results=results),
  )
  publish(msg)
diff --git a/callback_plugins/fedora_messaging_callback2.py 
b/callback_plugins/fedora_messaging_callback2.py
index 733e159a7..3d1e357ac 100644
--- a/callback_plugins/fedora_messaging_callback2.py
+++ b/callback_plugins/fedora_messaging_callback2.py
@@ -34,10 +34,11 @@ try:
  except ImportError:
  from ansible.utils import md5 as secure_hash
  
+

  def getlogin():
  try:
  user = os.getlogin()
-except OSError, e:
+except OSError as e:
  user = pwd.getpwuid(os.geteuid())[0]
  return user
  
@@ -45,8 +46,8 @@ def getlogin():

  class CallbackModule(CallbackBase):
  """ Publish playbook starts and stops to fedora_messaging. """
  
-CALLBACK_NAME = 'fedora_messaging_callback2'

-CALLBACK_TYPE = 'notification'
+CALLBACK_NAME = "fedora_messaging_callback2"
+CALLBACK_TYPE = "notification"
  CALLBACK_VERSION = 2.0
  CALLBACK_NEEDS_WHITELIST = True
  
@@ -77,7 +78,7 @@ class CallbackModule(CallbackBase):
  
  if not self.playbook_path:

  msg = Message(
-topic='ansible.playbook.start',
+topic="ansible.playbook.start",
  body=dict(
  playbook=path,
  userid=getlogin(),
@@ -96,11 +97,7 @@ class CallbackModule(CallbackBase):
  
  results = dict([(h, stats.summarize(h)) for h in stats.processed])

  msg = Message(
-topic='ansible.playbook.complete',
-body=dict(
-playbook=self.playbook_path,
-userid=getlogin(),
-results=results,
-),
+topic="ansible.playbook.complete",
+body=dict(playbook=self.playbook_path, userid=getlogin(), 
results=results),
  )
  publish(msg)
--
2.21.0

 From 1563b45d15092cd86a636fd32e90a2f02f952169 

Re: Another patch that makes nagios send the messages with fedora-messaging

2019-11-12 Thread Karsten Hopp

Hi Stephen,

Thanks a lot for reviewing this.

As I don't have write access afaik, could you merge that into the repo, 
please ?


 Thanks, Karsten

Am 11.11.19 um 20:37 schrieb Stephen John Smoogen:

Looks good to me as the nagios person

On Mon, 11 Nov 2019 at 11:05, Karsten Hopp  wrote:

It helps when patches are attached ;-(


Am 09.11.19 um 01:43 schrieb Karsten Hopp:

Hi all,
Now that https://pagure.io/releng/pull-request/8940 got merged we can
migrate nagios  from fedmsg to fedora-messaging.

The attached patches are for switching nagios to fedora-messaging,
please review and merge if they look sane to you.


Thanks, Karsten


___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org




___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org


Meeting Agenda Item: Introduction Kevin Sandy

2019-11-12 Thread Kevin Sandy
Hi all!

I’m very interested in getting involved in the Infrastructure group. I’ve been 
holding off on this for over a year, waiting to have “more time”, but figured I 
may as well jump in and start small, maybe 3-5 hours per week?

My IRC nick is ks3. I’ve been using Linux since around 1997, and professionally 
since 1998. Most of that has been RPM based distributions, starting with SuSE 
but fairly quickly moving to Red Hat, then RHEL and CentOS, and even Oracle 
Linux. At home, I’m using Fedora on my servers, including a cluster of Intel 
NUCs that host KVM machines on GlusterFS. At $work, I head up a team of Linux 
admins responsible for around 800 servers, including some smallish HPC 
environments. I *had* the RHCE certification until it expired earlier this 
year. I’m scheduled to take the RHEL8 exams in April 2020.

I have a good amount of scripting experience; lately it’s mostly been bash, 
with Python where SOAP calls or other harder-to-do in bash things were needed. 
I’m also fairly fluent with Perl. I’m also familiar with Puppet (and using 
Vagrant to test Puppet code, and Git to manage the Puppet modules), and to a 
smaller degree Ansible.

In addition to getting involved and giving back to the project (I also work at 
a non-profit, so that’s a bit of a theme...) I’m excited about learning how a 
different environment works and the tech that goes along with it. My main 
interests at the moment are probably Python and automation. I see that the 
Getting Started page mentions a special interest in people with web application 
skills; that’s definitely not my strong suit, but it is also an interest.

I’ve looked through a few of the “Easyfix” issues, and a few do look 
interesting. But at a few hours per week they all look like they’d take a month 
or more to complete, so I don’t really have a good idea of whether those are a 
good starting point or not. I’m definitely open to suggestions on this.


-- kevin
___
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org